DoneJS/quickjs-done-nextgen
1
0
Fork 0
mirror of https://github.com/DoneJS-Runtime/quickjs-done-nextgen.git synced 2025-01-09 17:43:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Simplify close_lexical_var (#726)

Browse source 
Its implementation was borderline wrong: calling it with is_arg=TRUE
segfaults because it looks up the var ref index in the wrong array.

Fortunately, there is only one caller and it only passes FALSE.
This commit is contained in:
Ben Noordhuis 2024-11-26 00:34:46 +01:00 committed by GitHub
parent aca0a09509
commit 0b0b794605
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
quickjs.c
View file

@ -14612,15 +14612,14 @@ static void close_var_refs(JSRuntime *rt, JSStackFrame *sf)
} }
} }
static void close_lexical_var(JSContext *ctx, JSStackFrame *sf, int idx, int is_arg) static void close_lexical_var(JSContext *ctx, JSStackFrame *sf, int var_idx)
{ {
struct list_head *el, *el1; struct list_head *el, *el1;
JSVarRef *var_ref; JSVarRef *var_ref;
int var_idx = idx;
list_for_each_safe(el, el1, &sf->var_ref_list) { list_for_each_safe(el, el1, &sf->var_ref_list) {
var_ref = list_entry(el, JSVarRef, header.link); var_ref = list_entry(el, JSVarRef, header.link);
if (var_idx == var_ref->var_idx && var_ref->is_arg == is_arg) { if (var_idx == var_ref->var_idx && !var_ref->is_arg) {
var_ref->value = js_dup(sf->var_buf[var_idx]); var_ref->value = js_dup(sf->var_buf[var_idx]);
var_ref->pvalue = &var_ref->value; var_ref->pvalue = &var_ref->value;
list_del(&var_ref->header.link); list_del(&var_ref->header.link);
@ -15873,7 +15872,7 @@ static JSValue JS_CallInternal(JSContext *caller_ctx, JSValue func_obj,
int idx; int idx;
idx = get_u16(pc); idx = get_u16(pc);
pc += 2; pc += 2;
close_lexical_var(ctx, sf, idx, FALSE); close_lexical_var(ctx, sf, idx);
} }
BREAK; BREAK;