DoneJS/quickjs-done-nextgen
1
0
Fork 0
mirror of https://github.com/DoneJS-Runtime/quickjs-done-nextgen.git synced 2025-01-09 17:43:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix regexp split with zero-length capture group (#566)

Browse source 
The expected result of `"ab".split(/(c)*/)[1]` is `undefined` but
was in fact `"undefined"` due to unintentional stringification.

Fixes: https://github.com/quickjs-ng/quickjs/issues/565
This commit is contained in:
Ben Noordhuis 2024-10-01 01:05:01 +02:00 committed by GitHub
parent e1564526ea
commit 1eb9608d64
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
quickjs.c
View file

@ -43835,9 +43835,14 @@ static JSValue js_regexp_Symbol_split(JSContext *ctx, JSValue this_val,
if (js_get_length64(ctx, &numberOfCaptures, z)) if (js_get_length64(ctx, &numberOfCaptures, z))
goto exception; goto exception;
for(i = 1; i < numberOfCaptures; i++) { for(i = 1; i < numberOfCaptures; i++) {
sub = JS_ToStringFree(ctx, JS_GetPropertyInt64(ctx, z, i)); sub = JS_GetPropertyInt64(ctx, z, i);
if (JS_IsException(sub)) if (JS_IsException(sub))
goto exception; goto exception;
if (!JS_IsUndefined(sub)) {
sub = JS_ToStringFree(ctx, sub);
if (JS_IsException(sub))
goto exception;
}
if (JS_DefinePropertyValueInt64(ctx, A, lengthA++, sub, JS_PROP_C_W_E | JS_PROP_THROW) < 0) if (JS_DefinePropertyValueInt64(ctx, A, lengthA++, sub, JS_PROP_C_W_E | JS_PROP_THROW) < 0)
goto exception; goto exception;
if (lengthA == lim) if (lengthA == lim)

2
tests/test_builtin.js
View file

@ -783,6 +783,8 @@ function test_regexp()
assert(a, ["a", undefined]); assert(a, ["a", undefined]);
a = /(?:|[\w])+([0-9])/.exec("123a23"); a = /(?:|[\w])+([0-9])/.exec("123a23");
assert(a, ["123a23", "3"]); assert(a, ["123a23", "3"]);
a = "ab".split(/(c)*/);
assert(a, ["a", undefined, "b"]);
} }
function test_symbol() function test_symbol()