DoneJS/quickjs-done-nextgen
1
0
Fork 0
mirror of https://github.com/DoneJS-Runtime/quickjs-done-nextgen.git synced 2025-01-09 17:43:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Align JS_SetOpaque with other similar APIs

Browse source 
Returns < 0 on failure. Also document it in the header file.

Fixes: https://github.com/quickjs-ng/quickjs/issues/695
This commit is contained in:
Saúl Ibarra Corretgé 2024-11-16 09:31:59 +01:00
parent 18b0b9a706
commit 428204b802
2 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
quickjs.c
View file

@ -10096,7 +10096,7 @@ void JS_ResetUncatchableError(JSContext *ctx)
JS_SetUncatchableError(ctx, ctx->rt->current_exception, FALSE); JS_SetUncatchableError(ctx, ctx->rt->current_exception, FALSE);
} }
JS_BOOL JS_SetOpaque(JSValue obj, void *opaque) int JS_SetOpaque(JSValue obj, void *opaque)
{ {
JSObject *p; JSObject *p;
if (JS_VALUE_GET_TAG(obj) == JS_TAG_OBJECT) { if (JS_VALUE_GET_TAG(obj) == JS_TAG_OBJECT) {
@ -10108,7 +10108,7 @@ JS_BOOL JS_SetOpaque(JSValue obj, void *opaque)
} }
} }
return 1; return -1;
} }
/* |obj| must be a JSObject of an internal class. */ /* |obj| must be a JSObject of an internal class. */

3
quickjs.h
View file

@ -755,7 +755,8 @@ JS_EXTERN int JS_DefinePropertyValueStr(JSContext *ctx, JSValue this_obj,
JS_EXTERN int JS_DefinePropertyGetSet(JSContext *ctx, JSValue this_obj, JS_EXTERN int JS_DefinePropertyGetSet(JSContext *ctx, JSValue this_obj,
JSAtom prop, JSValue getter, JSValue setter, JSAtom prop, JSValue getter, JSValue setter,
int flags); int flags);
JS_EXTERN JS_BOOL JS_SetOpaque(JSValue obj, void *opaque); /* Only supported for custom classes, returns 0 on success < 0 otherwise. */
JS_EXTERN int JS_SetOpaque(JSValue obj, void *opaque);
JS_EXTERN void *JS_GetOpaque(JSValue obj, JSClassID class_id); JS_EXTERN void *JS_GetOpaque(JSValue obj, JSClassID class_id);
JS_EXTERN void *JS_GetOpaque2(JSContext *ctx, JSValue obj, JSClassID class_id); JS_EXTERN void *JS_GetOpaque2(JSContext *ctx, JSValue obj, JSClassID class_id);
JS_EXTERN void *JS_GetAnyOpaque(JSValue obj, JSClassID *class_id); JS_EXTERN void *JS_GetAnyOpaque(JSValue obj, JSClassID *class_id);