From c740aa07c19ce4c782169bf81452ea9d4889a6f8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sa=C3=BAl=20Ibarra=20Corretg=C3=A9?= Date: Mon, 9 Sep 2024 10:48:24 +0200 Subject: [PATCH] Fix zero-length gnu_printf format string warning MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ``` src/quickjs/quickjs.c: In function ‘JS_ReadString’: src/quickjs/quickjs.c:34274:26: warning: zero-length gnu_printf format string [-Wformat-zero-length] 34274 | bc_read_trace(s, ""); // hex dump and indentation | ^~ src/quickjs/quickjs.c: In function ‘JS_ReadFunctionBytecode’: src/quickjs/quickjs.c:34334:30: warning: zero-length gnu_printf format string [-Wformat-zero-length] 34334 | bc_read_trace(s, ""); // hex dump + indent ``` Ref: https://github.com/quickjs-ng/quickjs/issues/502 --- quickjs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/quickjs.c b/quickjs.c index 2824637..459eb08 100644 --- a/quickjs.c +++ b/quickjs.c @@ -6529,7 +6529,7 @@ static void build_backtrace(JSContext *ctx, JSValue error_obj, line_num1 = find_line_num(ctx, b, sf->cur_pc - b->byte_code_buf - 1, &col_num1); - atom_str = JS_AtomToCString(ctx, b->filename); + atom_str = b->filename ? JS_AtomToCString(ctx, b->filename) : NULL; dbuf_printf(&dbuf, " (%s", atom_str ? atom_str : ""); JS_FreeCString(ctx, atom_str); if (line_num1 != -1)