DoneJS/quickjs-done-nextgen
1
0
Fork 0
mirror of https://github.com/DoneJS-Runtime/quickjs-done-nextgen.git synced 2025-01-09 17:43:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Improve run-test262 logging (#631)

Browse source 
In verboser mode (-vv):

- show the output of print() calls
- print exception stack traces

Also sneak in a minor bug fix where I forgot to atomically increment
the fixed_errors variable.
This commit is contained in:
Ben Noordhuis 2024-10-27 14:33:00 +01:00 committed by GitHub
parent d2bca87c64
commit eae9b23843
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 20 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
run-test262.c
View file

@ -460,10 +460,14 @@ static JSValue js_print_262(JSContext *ctx, JSValue this_val,
fputc(' ', outfile); fputc(' ', outfile);
fputs(str, outfile); fputs(str, outfile);
} }
if (verbose > 1)
printf("%s%s", &" "[i < 1], str);
JS_FreeCString(ctx, str); JS_FreeCString(ctx, str);
} }
if (outfile) if (outfile)
fputc('\n', outfile); fputc('\n', outfile);
if (verbose > 1)
printf("\n");
return JS_UNDEFINED; return JS_UNDEFINED;
} }
@ -1455,6 +1459,7 @@ static int eval_buf(JSContext *ctx, const char *buf, size_t buf_len,
int s_line; int s_line;
char *s = find_error(filename, &s_line, eval_flags & JS_EVAL_FLAG_STRICT); char *s = find_error(filename, &s_line, eval_flags & JS_EVAL_FLAG_STRICT);
const char *strict_mode = (eval_flags & JS_EVAL_FLAG_STRICT) ? "strict mode: " : ""; const char *strict_mode = (eval_flags & JS_EVAL_FLAG_STRICT) ? "strict mode: " : "";
BOOL is_unexpected_error = TRUE;
if (!JS_IsUndefined(exception_val)) { if (!JS_IsUndefined(exception_val)) {
msg_val = JS_ToString(ctx, exception_val); msg_val = JS_ToString(ctx, exception_val);
@ -1472,6 +1477,7 @@ static int eval_buf(JSContext *ctx, const char *buf, size_t buf_len,
printf("%s:%d: %sOK, now has error %s\n", printf("%s:%d: %sOK, now has error %s\n",
filename, error_line, strict_mode, msg); filename, error_line, strict_mode, msg);
atomic_inc(&fixed_errors); atomic_inc(&fixed_errors);
is_unexpected_error = FALSE;
} }
} else { } else {
if (!s) { // not yet reported if (!s) { // not yet reported
@ -1509,10 +1515,23 @@ static int eval_buf(JSContext *ctx, const char *buf, size_t buf_len,
} else { } else {
if (s) { if (s) {
printf("%s:%d: %sOK, fixed error: %s\n", filename, s_line, strict_mode, s); printf("%s:%d: %sOK, fixed error: %s\n", filename, s_line, strict_mode, s);
fixed_errors++; atomic_inc(&fixed_errors);
is_unexpected_error = FALSE;
} }
} }
} }
if (is_unexpected_error && verbose > 1) {
JSValue val = JS_GetPropertyStr(ctx, exception_val, "stack");
if (!JS_IsException(val) &&
!JS_IsUndefined(val) &&
!JS_IsNull(val)) {
const char *str = JS_ToCString(ctx, val);
if (str)
printf("%s\n", str);
JS_FreeCString(ctx, str);
JS_FreeValue(ctx, val);
}
}
JS_FreeValue(ctx, msg_val); JS_FreeValue(ctx, msg_val);
JS_FreeCString(ctx, msg); JS_FreeCString(ctx, msg);
free(s); free(s);