Various miscelaneous changes (#6496)

src/android/app/src/main/jni/game_info.h

@@ -2,7 +2,6 @@
 // Licensed under GPLv2 or any later version
 // Refer to the license.txt file included.
 
-#include <cstring>
 #include <string>
 
 #include "common/common_types.h"

src/android/app/src/main/jni/input_manager.h

@@ -4,7 +4,6 @@
 
 #pragma once
 
-#include <map>
 #include <memory>
 #include <string>
 #include "core/frontend/input.h"

src/android/app/src/main/jni/native.cpp

@@ -3,8 +3,6 @@
 // Refer to the license.txt file included.
 
 #include <algorithm>
-#include <iostream>
-#include <regex>
 #include <thread>
 
 #include <android/api-level.h>
@@ -666,6 +664,7 @@ void Java_org_citra_citra_1emu_NativeLibrary_InstallCIAS(JNIEnv* env, [[maybe_un
                                                          jobjectArray path) {
     const jsize count{env->GetArrayLength(path)};
     std::vector<std::string> paths;
+    paths.reserve(count);
     for (jsize idx{0}; idx < count; ++idx) {
         paths.emplace_back(
             GetJString(env, static_cast<jstring>(env->GetObjectArrayElement(path, idx))));

src/audio_core/lle/lle.cpp

@@ -69,6 +69,7 @@ Dsp1::Dsp1(const std::vector<u8>& raw) {
     Header header;
     std::memcpy(&header, raw.data(), sizeof(header));
     recv_data_on_start = header.recv_data_on_start != 0;
+    segments.reserve(header.num_segments);
     for (u32 i = 0; i < header.num_segments; ++i) {
         Segment segment;
         segment.data =

src/citra/config.cpp

@@ -6,7 +6,6 @@
 #include <memory>
 #include <sstream>
 #include <type_traits>
-#include <unordered_map>
 #include <SDL.h>
 #include <inih/cpp/INIReader.h>
 #include "citra/config.h"

src/citra/emu_window/emu_window_sdl2.h

@@ -4,8 +4,8 @@
 
 #pragma once
 
-#include <memory>
 #include <utility>
+#include "common/common_types.h"
 #include "core/frontend/emu_window.h"
 
 struct SDL_Window;

src/citra/emu_window/emu_window_sdl2_gl.cpp

@@ -10,6 +10,7 @@
 #include <glad/glad.h>
 #include "citra/emu_window/emu_window_sdl2_gl.h"
 #include "common/scm_rev.h"
+#include "common/settings.h"
 #include "video_core/renderer_base.h"
 #include "video_core/video_core.h"
 

src/citra/emu_window/emu_window_sdl2_sw.cpp

@@ -11,6 +11,7 @@
 #include "citra/emu_window/emu_window_sdl2_sw.h"
 #include "common/color.h"
 #include "common/scm_rev.h"
+#include "common/settings.h"
 #include "core/frontend/emu_window.h"
 #include "core/hw/gpu.h"
 #include "core/memory.h"

src/citra_qt/applets/mii_selector.h

@@ -4,7 +4,6 @@
 
 #pragma once
 
-#include <unordered_map>
 #include <QDialog>
 #include "core/frontend/applets/mii_selector.h"
 

src/citra_qt/applets/swkbd.cpp

@@ -2,6 +2,7 @@
 // Licensed under GPLv2 or any later version
 // Refer to the license.txt file included.
 
+#include <unordered_map>
 #include <QDialogButtonBox>
 #include <QLabel>
 #include <QLineEdit>

src/citra_qt/configuration/config.cpp

@@ -4,7 +4,6 @@
 
 #include <algorithm>
 #include <array>
-#include <unordered_map>
 #include <QKeySequence>
 #include <QSettings>
 #include "citra_qt/configuration/config.h"

src/citra_qt/configuration/configure_input.h

@@ -9,7 +9,6 @@
 #include <memory>
 #include <optional>
 #include <string>
-#include <unordered_map>
 #include <QKeySequence>
 #include <QWidget>
 #include "common/param_package.h"

src/citra_qt/debugger/ipc/recorder.h

@@ -4,9 +4,7 @@
 
 #pragma once
 
-#include <map>
 #include <memory>
-#include <unordered_map>
 #include <QDockWidget>
 #include "core/hle/kernel/ipc_debugger/recorder.h"
 

src/citra_qt/debugger/profiler.cpp

@@ -214,6 +214,7 @@ void MicroProfileDrawLine2D(u32 vertices_length, float* vertices, u32 hex_color)
     // the allocation across calls.
     static std::vector<QPointF> point_buf;
 
+    point_buf.reserve(vertices_length);
     for (u32 i = 0; i < vertices_length; ++i) {
         point_buf.emplace_back(vertices[i * 2 + 0], vertices[i * 2 + 1]);
     }

src/citra_qt/debugger/wait_tree.cpp

@@ -77,8 +77,9 @@ std::size_t WaitTreeItem::Row() const {
 }
 
 std::vector<std::unique_ptr<WaitTreeThread>> WaitTreeItem::MakeThreadItemList() {
-    u32 num_cores = Core::GetNumCores();
+    const u32 num_cores = Core::GetNumCores();
     std::vector<std::unique_ptr<WaitTreeThread>> item_list;
+    item_list.reserve(num_cores);
     for (u32 i = 0; i < num_cores; ++i) {
         const auto& threads =
             Core::System::GetInstance().Kernel().GetThreadManager(i).GetThreadList();

src/citra_qt/game_list.cpp

@@ -32,6 +32,7 @@
 #include "common/settings.h"
 #include "core/file_sys/archive_extsavedata.h"
 #include "core/file_sys/archive_source_sd_savedata.h"
+#include "core/hle/service/am/am.h"
 #include "core/hle/service/fs/archive.h"
 #include "qcursor.h"
 

src/citra_qt/game_list_worker.h

@@ -5,10 +5,8 @@
 #pragma once
 
 #include <atomic>
-#include <map>
 #include <memory>
 #include <string>
-#include <unordered_map>
 #include <QList>
 #include <QObject>
 #include <QRunnable>

src/citra_qt/main.cpp

@@ -3,8 +3,6 @@
 // Refer to the license.txt file included.
 
 #include <clocale>
-#include <filesystem>
-#include <fstream>
 #include <memory>
 #include <thread>
 #include <QDesktopWidget>
@@ -87,6 +85,7 @@
 #include "core/file_sys/archive_source_sd_savedata.h"
 #include "core/frontend/applets/default_applets.h"
 #include "core/gdbstub/gdbstub.h"
+#include "core/hle/service/am/am.h"
 #include "core/hle/service/cfg/cfg.h"
 #include "core/hle/service/fs/archive.h"
 #include "core/hle/service/nfc/nfc.h"

src/citra_qt/main.h

@@ -13,7 +13,6 @@
 #include "citra_qt/hotkeys.h"
 #include "common/announce_multiplayer_room.h"
 #include "core/core.h"
-#include "core/hle/service/am/am.h"
 #include "core/savestate.h"
 
 #ifdef __unix__
@@ -58,6 +57,10 @@ namespace Ui {
 class MainWindow;
 }
 
+namespace Service::AM {
+enum class InstallStatus : u32;
+}
+
 class GMainWindow : public QMainWindow {
     Q_OBJECT
 

src/common/android_storage.cpp

@@ -141,7 +141,8 @@ std::vector<std::string> GetFilesName(const std::string& filepath) {
     jstring j_filepath = env->NewStringUTF(filepath.c_str());
     auto j_object =
         (jobjectArray)env->CallStaticObjectMethod(native_library, get_files_name, j_filepath);
-    jsize j_size = env->GetArrayLength(j_object);
+    const jsize j_size = env->GetArrayLength(j_object);
+    vector.reserve(j_size);
     for (int i = 0; i < j_size; i++) {
         auto string = (jstring)(env->GetObjectArrayElement(j_object, i));
         vector.emplace_back(env->GetStringUTFChars(string, nullptr));

src/common/bit_field.h

@@ -33,7 +33,6 @@
 #include <cstddef>
 #include <limits>
 #include <type_traits>
-#include "common/common_funcs.h"
 #include "common/swap.h"
 
 /*

src/common/file_util.cpp

@@ -3,6 +3,7 @@
 // Refer to the license.txt file included.
 
 #include <array>
+#include <fstream>
 #include <limits>
 #include <memory>
 #include <sstream>

src/common/file_util.h

@@ -6,8 +6,8 @@
 
 #include <array>
 #include <cstdio>
-#include <fstream>
 #include <functional>
+#include <ios>
 #include <limits>
 #include <optional>
 #include <string>

src/common/logging/backend.cpp

@@ -3,12 +3,10 @@
 // Refer to the license.txt file included.
 
 #include <algorithm>
-#include <atomic>
 #include <chrono>
 #include <condition_variable>
 #include <memory>
 #include <mutex>
-#include <regex>
 #include <thread>
 #include <vector>
 #ifdef _WIN32

src/core/arm/dyncom/arm_dyncom_interpreter.cpp

@@ -5,7 +5,6 @@
 #define CITRA_IGNORE_EXIT(x)
 
 #include <algorithm>
-#include <cinttypes>
 #include <cstdio>
 #include "common/common_types.h"
 #include "common/logging/log.h"

src/core/arm/skyeye_common/vfp/vfp_helper.h

@@ -32,7 +32,6 @@
 
 #pragma once
 
-#include <cstdio>
 #include "common/common_types.h"
 #include "core/arm/skyeye_common/armstate.h"
 #include "core/arm/skyeye_common/vfp/asm_vfp.h"

src/core/core.cpp

@@ -2,7 +2,6 @@
 // Licensed under GPLv2 or any later version
 // Refer to the license.txt file included.
 
-#include <fstream>
 #include <memory>
 #include <stdexcept>
 #include <utility>
@@ -377,6 +376,7 @@ System::ResultStatus System::Init(Frontend::EmuWindow& emu_window,
         *memory, *timing, [this] { PrepareReschedule(); }, system_mode, num_cores, n3ds_mode);
 
     exclusive_monitor = MakeExclusiveMonitor(*memory, num_cores);
+    cpu_cores.reserve(num_cores);
     if (Settings::values.use_cpu_jit) {
 #if CITRA_ARCH(x86_64) || CITRA_ARCH(arm64)
         for (u32 i = 0; i < num_cores; ++i) {

src/core/core_timing.cpp

@@ -3,7 +3,6 @@
 // Refer to the license.txt file included.
 
 #include <algorithm>
-#include <cinttypes>
 #include <tuple>
 #include "common/assert.h"
 #include "common/logging/log.h"

src/core/dumping/ffmpeg_backend.cpp

@@ -2,7 +2,7 @@
 // Licensed under GPLv2 or any later version
 // Refer to the license.txt file included.
 
-#include <unordered_set>
+#include <unordered_map>
 #include "common/assert.h"
 #include "common/file_util.h"
 #include "common/logging/log.h"

src/core/file_sys/archive_ncch.cpp

@@ -3,7 +3,6 @@
 // Refer to the license.txt file included.
 
 #include <algorithm>
-#include <cinttypes>
 #include <memory>
 #include <utility>
 #include <vector>

src/core/file_sys/archive_selfncch.cpp

@@ -3,7 +3,6 @@
 // Refer to the license.txt file included.
 
 #include <array>
-#include <cinttypes>
 #include "common/archives.h"
 #include "common/common_types.h"
 #include "common/logging/log.h"

src/core/file_sys/cia_container.cpp

@@ -2,7 +2,6 @@
 // Licensed under GPLv2 or any later version
 // Refer to the license.txt file included.
 
-#include <cinttypes>
 #include <cryptopp/sha.h>
 #include "common/alignment.h"
 #include "common/file_util.h"

src/core/file_sys/disk_archive.cpp

@@ -3,7 +3,6 @@
 // Refer to the license.txt file included.
 
 #include <algorithm>
-#include <cstdio>
 #include <memory>
 #include "common/archives.h"
 #include "common/common_types.h"

src/core/file_sys/ncch_container.cpp

@@ -2,7 +2,6 @@
 // Licensed under GPLv2 or any later version
 // Refer to the license.txt file included.
 
-#include <cinttypes>
 #include <cstring>
 #include <memory>
 #include <cryptopp/aes.h>

src/core/file_sys/plugin_3gx.cpp

@@ -112,6 +112,7 @@ Loader::ResultStatus FileSys::Plugin3GXLoader::Load(
                          header.targets.count * sizeof(u32))) {
             return Loader::ResultStatus::Error;
         }
+        compatible_TID.reserve(header.targets.count); // compatible_TID should be empty right now
         for (u32 i = 0; i < u32(header.targets.count); i++) {
             compatible_TID.push_back(
                 u32_le(*reinterpret_cast<u32*>(raw_TID_data.data() + i * sizeof(u32))));

src/core/file_sys/title_metadata.cpp

@@ -2,7 +2,6 @@
 // Licensed under GPLv2 or any later version
 // Refer to the license.txt file included.
 
-#include <cinttypes>
 #include <cryptopp/sha.h>
 #include "common/alignment.h"
 #include "common/file_util.h"

src/core/frontend/applets/swkbd.h

@@ -4,7 +4,6 @@
 
 #pragma once
 
-#include <unordered_map>
 #include <utility>
 #include <vector>
 #include "common/assert.h"

src/core/frontend/framebuffer_layout.h

@@ -5,7 +5,10 @@
 #pragma once
 
 #include "common/math_util.h"
-#include "common/settings.h"
+
+namespace Settings {
+enum class LayoutOption : u32;
+}
 
 namespace Layout {
 

src/core/gdbstub/gdbstub.cpp

@@ -6,7 +6,6 @@
 
 #include <algorithm>
 #include <atomic>
-#include <climits>
 #include <csignal>
 #include <cstdarg>
 #include <cstdio>

src/core/hle/applets/applet.cpp

@@ -18,23 +18,6 @@
 #include "core/hle/applets/swkbd.h"
 #include "core/hle/result.h"
 
-////////////////////////////////////////////////////////////////////////////////////////////////////
-
-// Specializes std::hash for AppletId, so that we can use it in std::unordered_map.
-// Workaround for libstdc++ bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60970
-namespace std {
-template <>
-struct hash<Service::APT::AppletId> {
-    typedef Service::APT::AppletId argument_type;
-    typedef std::size_t result_type;
-
-    result_type operator()(const argument_type& id_code) const {
-        typedef std::underlying_type<argument_type>::type Type;
-        return std::hash<Type>()(static_cast<Type>(id_code));
-    }
-};
-} // namespace std
-
 namespace HLE::Applets {
 
 static std::unordered_map<Service::APT::AppletId, std::shared_ptr<Applet>> applets;

src/core/hle/kernel/event.cpp

@@ -3,7 +3,6 @@
 // Refer to the license.txt file included.
 
 #include <algorithm>
-#include <map>
 #include <vector>
 #include "common/archives.h"
 #include "common/assert.h"

src/core/hle/kernel/memory.cpp

@@ -3,8 +3,6 @@
 // Refer to the license.txt file included.
 
 #include <algorithm>
-#include <cinttypes>
-#include <map>
 #include <memory>
 #include <utility>
 #include <vector>

src/core/hle/kernel/mutex.cpp

@@ -2,7 +2,6 @@
 // Licensed under GPLv2 or any later version
 // Refer to the license.txt file included.
 
-#include <map>
 #include <vector>
 #include "common/archives.h"
 #include "common/assert.h"

src/core/hle/kernel/svc.cpp

@@ -4,8 +4,6 @@
 
 #include <algorithm>
 #include <array>
-#include <cinttypes>
-#include <map>
 #include <fmt/format.h>
 #include "common/logging/log.h"
 #include "common/microprofile.h"

src/core/hle/kernel/thread.cpp

@@ -4,7 +4,6 @@
 
 #include <algorithm>
 #include <list>
-#include <unordered_map>
 #include <vector>
 #include <boost/serialization/string.hpp>
 #include "common/archives.h"

src/core/hle/kernel/timer.cpp

@@ -2,8 +2,6 @@
 // Licensed under GPLv2 or any later version
 // Refer to the license.txt file included.
 
-#include <cinttypes>
-#include <unordered_map>
 #include "common/archives.h"
 #include "common/assert.h"
 #include "common/logging/log.h"

src/core/hle/service/am/am.cpp

@@ -3,7 +3,6 @@
 // Refer to the license.txt file included.
 
 #include <algorithm>
-#include <cinttypes>
 #include <cstddef>
 #include <cstring>
 #include <cryptopp/aes.h>

src/core/hle/service/am/am.h

@@ -14,6 +14,7 @@
 #include <boost/serialization/vector.hpp>
 #include "common/common_types.h"
 #include "common/construct.h"
+#include "common/swap.h"
 #include "core/file_sys/cia_container.h"
 #include "core/file_sys/file_backend.h"
 #include "core/global.h"

src/core/hle/service/apt/ns.cpp

@@ -2,7 +2,6 @@
 // Licensed under GPLv2 or any later version
 // Refer to the license.txt file included.
 
-#include <cinttypes>
 #include "core/core.h"
 #include "core/hle/service/am/am.h"
 #include "core/hle/service/apt/ns.h"

src/core/hle/service/apt/ns.h

@@ -4,6 +4,7 @@
 
 #pragma once
 
+#include "common/common_types.h"
 #include "core/hle/kernel/process.h"
 #include "core/hle/service/fs/archive.h"
 #include "core/hle/service/service.h"

src/core/hle/service/cfg/cfg.cpp

@@ -313,7 +313,7 @@ void Module::Interface::GetRegionCanadaUSA(Kernel::HLERequestContext& ctx) {
 void Module::Interface::GetSystemModel(Kernel::HLERequestContext& ctx) {
     IPC::RequestParser rp(ctx, 0x05, 0, 0);
     IPC::RequestBuilder rb = rp.MakeBuilder(2, 0);
-    u32 data;
+    u32 data{};
 
     // TODO(Subv): Find out the correct error codes
     rb.Push(cfg->GetConfigInfoBlock(ConsoleModelBlockID, 4, 0x8, reinterpret_cast<u8*>(&data)));
@@ -879,13 +879,13 @@ ResultCode Module::SetConsoleUniqueId(u32 random_number, u64 console_id) {
 }
 
 u64 Module::GetConsoleUniqueId() {
-    u64_le console_id_le;
+    u64_le console_id_le{};
     GetConfigInfoBlock(ConsoleUniqueID2BlockID, sizeof(console_id_le), 0xE, &console_id_le);
     return console_id_le;
 }
 
 EULAVersion Module::GetEULAVersion() {
-    u32_le data;
+    u32_le data{};
     GetConfigInfoBlock(EULAVersionBlockID, sizeof(data), 0xE, &data);
     EULAVersion version;
     version.minor = data & 0xFF;

src/core/hle/service/fs/archive.cpp

@@ -3,7 +3,6 @@
 // Refer to the license.txt file included.
 
 #include <algorithm>
-#include <cinttypes>
 #include <cstddef>
 #include <memory>
 #include <system_error>

src/core/hle/service/fs/fs_user.cpp

@@ -2,7 +2,6 @@
 // Licensed under GPLv2 or any later version
 // Refer to the license.txt file included.
 
-#include <cinttypes>
 #include "common/archives.h"
 #include "common/assert.h"
 #include "common/common_types.h"

src/core/hle/service/http_c.cpp

@@ -3,6 +3,7 @@
 // Refer to the license.txt file included.
 
 #include <atomic>
+#include <unordered_map>
 #include <cryptopp/aes.h>
 #include <cryptopp/modes.h>
 #include "common/archives.h"

src/core/hle/service/ptm/ptm.cpp

@@ -2,7 +2,6 @@
 // Licensed under GPLv2 or any later version
 // Refer to the license.txt file included.
 
-#include <cinttypes>
 #include "common/archives.h"
 #include "common/common_paths.h"
 #include "common/file_util.h"

src/core/hle/service/soc_u.cpp

@@ -5,6 +5,7 @@
 #include <algorithm>
 #include <cstring>
 #include <type_traits>
+#include <unordered_map>
 #include <vector>
 #include "common/archives.h"
 #include "common/assert.h"

src/core/hw/aes/key.cpp

@@ -4,6 +4,7 @@
 
 #include <algorithm>
 #include <exception>
+#include <fstream>
 #include <optional>
 #include <sstream>
 #include <boost/iostreams/device/file_descriptor.hpp>

src/core/loader/ncch.cpp

@@ -3,7 +3,6 @@
 // Refer to the license.txt file included.
 
 #include <algorithm>
-#include <cinttypes>
 #include <codecvt>
 #include <cstring>
 #include <locale>

src/core/savestate.cpp

@@ -67,6 +67,7 @@ static bool ValidateSaveState(const CSTHeader& header, SaveStateInfo& info, u64
 
 std::vector<SaveStateInfo> ListSaveStates(u64 program_id) {
     std::vector<SaveStateInfo> result;
+    result.reserve(SaveStateSlotCount);
     for (u32 slot = 1; slot <= SaveStateSlotCount; ++slot) {
         const auto path = GetSaveStatePath(program_id, slot);
         if (!FileUtil::Exists(path)) {

src/dedicated_room/citra-room.cpp

@@ -6,7 +6,6 @@
 #include <fstream>
 #include <iostream>
 #include <memory>
-#include <regex>
 #include <string>
 #include <thread>
 #include <cryptopp/base64.h>

src/input_common/gcadapter/gc_adapter.h

@@ -9,7 +9,6 @@
 #include <functional>
 #include <mutex>
 #include <thread>
-#include <unordered_map>
 #include <vector>
 #include "common/common_types.h"
 #include "common/threadsafe_queue.h"

src/input_common/sdl/sdl_impl.h

@@ -7,6 +7,7 @@
 #include <atomic>
 #include <memory>
 #include <thread>
+#include <unordered_map>
 #include "common/settings.h"
 #include "common/threadsafe_queue.h"
 #include "input_common/sdl/sdl.h"

src/network/room.cpp

@@ -4,7 +4,6 @@
 
 #include <algorithm>
 #include <atomic>
-#include <iomanip>
 #include <mutex>
 #include <random>
 #include <regex>

src/video_core/rasterizer_cache/rasterizer_cache.cpp

@@ -7,6 +7,7 @@
 #include "common/alignment.h"
 #include "common/logging/log.h"
 #include "common/microprofile.h"
+#include "common/settings.h"
 #include "core/memory.h"
 #include "video_core/custom_textures/custom_tex_manager.h"
 #include "video_core/rasterizer_cache/rasterizer_cache.h"

src/video_core/regs_rasterizer.h

@@ -6,6 +6,7 @@
 
 #include <array>
 #include "common/bit_field.h"
+#include "common/common_funcs.h"
 #include "common/math_util.h"
 #include "common/vector_math.h"
 #include "video_core/pica_types.h"

src/video_core/renderer_base.cpp

@@ -2,6 +2,7 @@
 // Licensed under GPLv2 or any later version
 // Refer to the license.txt file included.
 
+#include "common/settings.h"
 #include "core/core.h"
 #include "core/frontend/emu_window.h"
 #include "core/tracer/recorder.h"

src/video_core/renderer_opengl/gl_format_reinterpreter.h

@@ -4,7 +4,6 @@
 
 #pragma once
 
-#include <unordered_map>
 #include "common/math_util.h"
 #include "video_core/rasterizer_cache/pixel_format.h"
 #include "video_core/renderer_opengl/gl_resource_manager.h"

src/video_core/renderer_opengl/gl_shader_disk_cache.h

@@ -11,7 +11,6 @@
 #include <string>
 #include <tuple>
 #include <unordered_map>
-#include <unordered_set>
 #include <utility>
 #include <vector>
 

src/video_core/renderer_opengl/gl_shader_manager.cpp

@@ -8,6 +8,7 @@
 #include <unordered_map>
 #include <variant>
 #include "common/scope_exit.h"
+#include "core/frontend/emu_window.h"
 #include "video_core/renderer_opengl/gl_driver.h"
 #include "video_core/renderer_opengl/gl_resource_manager.h"
 #include "video_core/renderer_opengl/gl_shader_disk_cache.h"

src/video_core/renderer_opengl/post_processing_opengl.cpp

@@ -2,6 +2,7 @@
 // Licensed under GPLv2 or any later version
 // Refer to the license.txt file included.
 
+#include <fstream>
 #include <sstream>
 #include <string>
 #include <vector>

src/video_core/renderer_software/sw_lighting.cpp

@@ -35,8 +35,8 @@ std::tuple<Common::Vec4<u8>, Common::Vec4<u8>> ComputeFragmentsColors(
         shadow = Common::MakeVec(1.0f, 1.0f, 1.0f, 1.0f);
     }
 
-    Common::Vec3<float> surface_normal;
-    Common::Vec3<float> surface_tangent;
+    Common::Vec3<float> surface_normal{};
+    Common::Vec3<float> surface_tangent{};
 
     if (lighting.config0.bump_mode != LightingRegs::LightingBumpMode::None) {
         Common::Vec3<float> perturbation =

src/video_core/shader/shader_jit_x64_compiler.h

@@ -15,7 +15,6 @@
 #include <vector>
 #include <nihstro/shader_bytecode.h>
 #include <xbyak/xbyak.h>
-#include "common/bit_set.h"
 #include "common/common_types.h"
 #include "video_core/shader/shader.h"
 

src/video_core/video_core.cpp

@@ -7,6 +7,7 @@
 #include "common/logging/log.h"
 #include "common/settings.h"
 #include "core/core.h"
+#include "core/frontend/emu_window.h"
 #include "video_core/pica.h"
 #include "video_core/pica_state.h"
 #include "video_core/renderer_base.h"

src/video_core/video_core.h

@@ -6,9 +6,7 @@
 
 #include <atomic>
 #include <functional>
-#include <iostream>
 #include <memory>
-#include "core/frontend/emu_window.h"
 
 namespace Frontend {
 class EmuWindow;