sneedmca/Lime3DS
1
0
Fork 0
mirror of https://github.com/Lime3DS/Lime3DS synced 2024-12-27 09:32:30 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

post_processing_opengl: Make use of std::string_view with GetPostProcessingShaderCode()

Browse source 
Same behavior, but doesn't result in an allocating copy of the passed in
string. Particularly given the string is only compared against other
existing strings.
This commit is contained in:
Lioncash 2020-04-18 22:27:42 -04:00
parent 397bd1bb73
commit 623cc926ed
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/video_core/renderer_opengl/post_processing_opengl.cpp
View file

@ -150,7 +150,7 @@ std::vector<std::string> GetPostProcessingShaderList(bool anaglyph) {
return shader_names;
}
std::string GetPostProcessingShaderCode(bool anaglyph, std::string shader) {
std::string GetPostProcessingShaderCode(bool anaglyph, std::string_view shader) {
std::string shader_dir = FileUtil::GetUserPath(FileUtil::UserPath::ShaderDir);
std::string shader_path;

3
src/video_core/renderer_opengl/post_processing_opengl.h
View file

@ -5,6 +5,7 @@
#pragma once
#include <string>
#include <string_view>
#include <vector>
namespace OpenGL {
@ -18,6 +19,6 @@ std::vector<std::string> GetPostProcessingShaderList(bool anaglyph);
// If anaglyph is true, it searches the shaders/anaglyph directory rather than
// the shaders directory
// If the shader cannot be loaded, an empty string is returned
std::string GetPostProcessingShaderCode(bool anaglyph, std::string shader_name);
std::string GetPostProcessingShaderCode(bool anaglyph, std::string_view shader_name);
} // namespace OpenGL