sneedmca/suyu
1
0
Fork 0
mirror of https://git.suyu.dev/suyu/suyu synced 2024-12-25 10:52:48 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Merge pull request #6191 from lioncash/vdtor

Browse source 
engine_interface: Add missing virtual destructor
This commit is contained in:
bunnei 2021-04-13 19:59:10 -07:00 committed by GitHub
commit 8146c8c5e7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/video_core/engines/engine_interface.h
View file

@ -4,13 +4,14 @@
#pragma once #pragma once
#include <type_traits>
#include "common/common_types.h" #include "common/common_types.h"
namespace Tegra::Engines { namespace Tegra::Engines {
class EngineInterface { class EngineInterface {
public: public:
virtual ~EngineInterface() = default;
/// Write the value to the register identified by method. /// Write the value to the register identified by method.
virtual void CallMethod(u32 method, u32 method_argument, bool is_last_call) = 0; virtual void CallMethod(u32 method, u32 method_argument, bool is_last_call) = 0;

2
src/video_core/engines/fermi_2d.h
View file

@ -35,7 +35,7 @@ namespace Tegra::Engines {
class Fermi2D final : public EngineInterface { class Fermi2D final : public EngineInterface {
public: public:
explicit Fermi2D(); explicit Fermi2D();
~Fermi2D(); ~Fermi2D() override;
/// Binds a rasterizer to this engine. /// Binds a rasterizer to this engine.
void BindRasterizer(VideoCore::RasterizerInterface* rasterizer); void BindRasterizer(VideoCore::RasterizerInterface* rasterizer);

2
src/video_core/engines/kepler_memory.h
View file

@ -36,7 +36,7 @@ namespace Tegra::Engines {
class KeplerMemory final : public EngineInterface { class KeplerMemory final : public EngineInterface {
public: public:
explicit KeplerMemory(Core::System& system_, MemoryManager& memory_manager); explicit KeplerMemory(Core::System& system_, MemoryManager& memory_manager);
~KeplerMemory(); ~KeplerMemory() override;
/// Write the value to the register identified by method. /// Write the value to the register identified by method.
void CallMethod(u32 method, u32 method_argument, bool is_last_call) override; void CallMethod(u32 method, u32 method_argument, bool is_last_call) override;

2
src/video_core/engines/maxwell_dma.h
View file

@ -188,7 +188,7 @@ public:
static_assert(sizeof(RemapConst) == 12); static_assert(sizeof(RemapConst) == 12);
explicit MaxwellDMA(Core::System& system_, MemoryManager& memory_manager_); explicit MaxwellDMA(Core::System& system_, MemoryManager& memory_manager_);
~MaxwellDMA(); ~MaxwellDMA() override;
/// Write the value to the register identified by method. /// Write the value to the register identified by method.
void CallMethod(u32 method, u32 method_argument, bool is_last_call) override; void CallMethod(u32 method, u32 method_argument, bool is_last_call) override;