11640 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
Lioncash	8b08f82dc7	maxwell_3d: Remove unused variable within GetStageTextures()	2018-07-19 22:38:28 -04:00
Lioncash	dbfe82773d	thread: Convert ThreadStatus into an enum class ... Makes the thread status strongly typed, so implicit conversions can't happen. It also makes it easier to catch mistakes at compile time.	2018-07-19 22:08:56 -04:00
Lioncash	bbd6429ecb	partition_filesystem: Return pfs_dirs member variable within GetSubdirectories() ... This should be returned here, otherwise pfs_dirs is effectively only ever added to, but never read.	2018-07-19 21:08:50 -04:00
Lioncash	364b950515	nso: Silence implicit sign conversion warnings	2018-07-19 20:51:15 -04:00
Lioncash	a25c5b982a	nso: Remove unused function ReadSegment()	2018-07-19 20:49:27 -04:00
Lioncash	f26866ff6a	gl_shader_decompiler: Eliminate variable and declaration shadowing ... Ensures that no identifiers are being hidden, which also reduces compiler warnings.	2018-07-19 20:32:49 -04:00
Lioncash	c2121cb059	gl_shader_decompiler: Remove unnecessary const from return values ... This adds nothing from a behavioral point of view, and can inhibit the move constructor/RVO	2018-07-19 20:11:04 -04:00
Lioncash	1bdb67440b	pl_u: Simplify WriteBuffer() calls in GetSharedFontInOrderOfPriority() ... With the new overload, we can simply pass the container directly.	2018-07-19 19:50:30 -04:00
bunnei	d3cfaf95c8	Merge pull request #726 from lioncash/overload ... hle_ipc: Introduce generic WriteBuffer overload for multiple container types	2018-07-19 16:18:38 -07:00
bunnei	0b13ce1435	Merge pull request #725 from lioncash/bytes ... pl_u: Specify correct size for buffers in GetSharedFontInOrderOfPriority()	2018-07-19 16:16:30 -07:00
bunnei	af08034c71	Merge pull request #728 from Subv/acc_profile ... HLE/ACC: Change the default user id and small improvements to the way we handle profiles	2018-07-19 16:15:01 -07:00
bunnei	2aeb3355e4	Merge pull request #727 from Subv/acc_users ... HLE/ACC: Write a single whole user id in ListAllUsers and ListOpenUsers.	2018-07-19 16:13:45 -07:00
bunnei	c6352ffc58	Merge pull request #724 from lioncash/printf ... pl_u: Remove printf specifier in log call in a log call in GetSharedFontInOrderOfPriority()	2018-07-19 16:13:07 -07:00
bunnei	ec468c990d	Merge pull request #723 from lioncash/gdb ... gdbstub: Get rid of a few signed/unsigned comparisons	2018-07-19 16:12:40 -07:00
bunnei	f43d8ea523	Merge pull request #722 from lioncash/signed ... hid: Resolve a signed/unsigned comparison warning	2018-07-19 16:12:15 -07:00
bunnei	2194308245	Merge pull request #721 from lioncash/svc ... svc: Correct always true assertion case in SetThreadCoreMask	2018-07-19 16:11:40 -07:00
bunnei	b5c77313de	Merge pull request #719 from lioncash/docs ... loader: Amend Doxygen comments	2018-07-19 16:11:09 -07:00
bunnei	dd0446ff43	Merge pull request #718 from lioncash/read ... loader/nso: Check if read succeeded in IdentifyFile() before checking magic value	2018-07-19 16:10:29 -07:00
bunnei	31413f0d2f	Merge pull request #717 from lioncash/explicit ... hle/service: Make constructors explicit where applicable	2018-07-19 16:08:07 -07:00
Subv	05549e45c5	HLE/ACC: Return an IProfile that is consistent with what was requested. ... The default username for now is "yuzu". We should eventually allow the creation of users in the emulator and have the ability to modify their parameters.	2018-07-19 16:53:42 -05:00
Subv	50e2777724	HLE/ACC: Change the default user id to be consistent with what we tell games on startup. ... In IApplicationFunctions::PopLaunchParameter we tell the games that they were launched as user id 1.	2018-07-19 16:51:55 -05:00
Subv	b102815f1f	HLE/ACC: Write a single whole user id in ListAllUsers and ListOpenUsers. ... We only emulate a single user id for now.	2018-07-19 16:19:46 -05:00
bunnei	7244671137	Merge pull request #716 from lioncash/construct ... nvflinger: Emplace Display instances directly	2018-07-19 14:18:29 -07:00
Lioncash	ff500a7b68	hle_ipc: Introduce generic WriteBuffer overload for multiple container types ... This introduces a slightly more generic variant of WriteBuffer(). Notably, this variant doesn't constrain the arguments to only accepting std::vector instances. It accepts whatever adheres to the ContiguousContainer concept in the C++ standard library. This essentially means, std::array, std::string, and std::vector can be used directly with this interface. The interface no longer forces you to solely use containers that dynamically allocate. To ensure our overloads play nice with one another, we only enable the container-based WriteBuffer if the argument is not a pointer, otherwise we fall back to the pointer-based one.	2018-07-19 17:05:12 -04:00
bunnei	eb9b55eafe	Merge pull request #715 from lioncash/const-ref ... nvdrv: Take std::string by const reference in GetDevice()	2018-07-19 13:27:48 -07:00
Sebastian Valle	78dd1cd441	Merge pull request #720 from Subv/getentrytype_root ... Filesystem: Return EntryType::Directory for the root directory.	2018-07-19 15:23:32 -05:00
Lioncash	df001e83b1	pl_u: Specify correct size for buffers in GetSharedFontInOrderOfPriority() ... This WriteBuffer overload expects its size argument to be in bytes, not elements.	2018-07-19 15:57:58 -04:00
Lioncash	b879fb84a2	svc: Correct always true assertion case in SetThreadCoreMask ... The reason this would never be true is that ideal_processor is a u8 and THREADPROCESSORID_DEFAULT is an s32. In this case, it boils down to how arithmetic conversions are performed before performing the comparison. If an unsigned value has a lesser conversion rank (aka smaller size) than the signed type being compared, then the unsigned value is promoted to the signed value (i.e. u8 -> s32 happens before the comparison). No sign-extension occurs here either. An alternative phrasing: Say we have a variable named core and it's given a value of -2. u8 core = -2; This becomes 254 due to the lack of sign. During integral promotion to the signed type, this still remains as 254, and therefore the condition will always be true, because no matter what value the u8 is given it will never be -2 in terms of 32 bits. Now, if one type was a s32 and one was a u32, this would be entirely different, since they have the same bit width (and the signed type would be converted to unsigned instead of the other way around) but would still have its representation preserved in terms of bits, allowing the comparison to be false in some cases, as opposed to being true all the time. --- We also get rid of two signed/unsigned comparison warnings while we're at it.	2018-07-19 15:46:17 -04:00
Lioncash	68c1ffdd1c	pl_u: Remove printf specifier in log call in a log call in GetSharedFontInOrderOfPriority() ... This can just use the fmt specifiers and be type-agnostic.	2018-07-19 15:44:04 -04:00
Sebastian Valle	7eace8f512	Merge pull request #714 from lioncash/index ... hle_ipc: Amend usage of buffer_index within one of HLERequestContext's WriteBuffer() overloads	2018-07-19 14:36:34 -05:00
bunnei	38b35e752b	Merge pull request #712 from lioncash/fsp ... fsp_srv: Misc individual changes	2018-07-19 12:31:33 -07:00
Lioncash	c945226973	gdbstub: Get rid of a few signed/unsigned comparisons ... Ensures both operands in comparisons are the same signedness.	2018-07-19 15:27:01 -04:00
Lioncash	a37a47448d	hid: Use a ranged-for loops in UpdatePadCallback ... Modernizes the loops themselves while also getting rid of a signed/unsigned comparison in a loop condition.	2018-07-19 15:11:08 -04:00
Lioncash	95103a1b7b	hid: Use HID_NUM_LAYOUTS constant for indicating size of the layouts array ... Gets rid of the use of a magic constant	2018-07-19 15:07:36 -04:00
bunnei	427fc4ac6b	Merge pull request #713 from lioncash/filesys ... filesystem: Minor changes	2018-07-19 11:49:06 -07:00
bunnei	e91ba6c057	Merge pull request #711 from lioncash/swap ... common/swap: Minor changes	2018-07-19 11:48:16 -07:00
bunnei	d6c7a05239	Merge pull request #710 from lioncash/unused ... common/common_funcs: Remove unused rotation functions	2018-07-19 11:43:41 -07:00
bunnei	1034bcc742	Merge pull request #694 from lioncash/warn ... loader/{nro, nso}: Resolve compilation warnings	2018-07-19 11:43:14 -07:00
Subv	e5c916a27c	Filesystem: Return EntryType::Directory for the root directory. ... It is unknown if this is correct behavior, but it makes sense and fixes a regression with Stardew Valley.	2018-07-19 13:11:09 -05:00
Lioncash	50d08beed2	loader: Amend Doxygen comments ... These weren't adjusted when VFS was introduced	2018-07-19 14:04:33 -04:00
bunnei	bbc31ba6af	Merge pull request #709 from lioncash/thread-local ... common/misc: Deduplicate code in GetLastErrorMsg()	2018-07-19 10:00:48 -07:00
bunnei	130a02f330	Merge pull request #708 from lioncash/xbyak ... externals: Update Xbyak to 5.65	2018-07-19 10:00:06 -07:00
bunnei	8176ab3a07	Merge pull request #707 from lioncash/catch ... externals: Update catch to v2.2.3	2018-07-19 09:59:44 -07:00
Lioncash	9b22f856c2	loader/nso: Check if read succeeded in IdentifyFile() before checking magic value ... We should always assume the filesystem is volatile and check each IO operation. While we're at it reorganize checks so that early-out errors are near one another.	2018-07-19 12:43:21 -04:00
Lioncash	c061c2bf3c	hle/service: Make constructors explicit where applicable ... Prevents implicit construction and makes these lingering non-explicit constructors consistent with the rest of the other classes in services.	2018-07-19 12:25:02 -04:00
Lioncash	f3daecafeb	nvflinger: Emplace Display instances directly ... We can use emplace_back to construct the Display instances directly, instead of constructing them separately and copying them, avoiding the need to copy std::string and std::vector instances that are part of the Display struct.	2018-07-19 11:50:12 -04:00
bunnei	04f7a7036a	Merge pull request #705 from lioncash/string-ref ... file_util: return string by const reference for GetExeDirectory()	2018-07-19 08:47:06 -07:00
bunnei	cbf43225a9	Merge pull request #704 from lioncash/string ... string_util: Remove AsciiToHex()	2018-07-19 08:46:40 -07:00
bunnei	f1d7486eac	Merge pull request #703 from lioncash/const ... savedata_factory: Make SaveDataDescriptor's DebugInfo() function a const member function	2018-07-19 08:46:15 -07:00
bunnei	b0334af05b	Merge pull request #702 from lioncash/initialize ... partition_filesystem: Ensure all class members of PartitionFilesystem are initialized	2018-07-19 08:45:54 -07:00