6978 commits

Author	SHA1	Message	Date
Lioncash	fa8017295b	nvdrv: Get rid of indirect inclusions	2018-08-07 08:54:50 -04:00
Lioncash	e40b0cf437	nvflinger: Get rid of indirect inclusions	2018-08-07 08:32:05 -04:00
Lioncash	7e49881b7f	nvflinger: Use std::string_view in OpenDisplay() ... We don't need to use a std::string here, given all that's done is comparing the character sequence against another. This allows passing regular const char* without needing to heap allocate.	2018-08-07 08:32:06 -04:00
KAMiKAZOW	0f5c4615ae	Make building cubeb optional	2018-08-07 13:21:56 +02:00
Lioncash	890e543304	services/hid: Add ActivateNpadWithRevision() to the hid function info array ... Updated based off the information on Switch Brew.	2018-08-07 03:23:20 -04:00
Lioncash	20c976ff2a	service/time: Amend command IDs of ToPosixTime() and ToPosixTimeWithMyRule() ... Updates the ID of these based off the information on Switch Brew.	2018-08-07 03:18:07 -04:00
Lioncash	45bc449ff9	service: Add usb services ... Adds basic skeleton for the usb services based off the information provided by Switch Brew.	2018-08-07 03:14:03 -04:00
Lioncash	c8f6754417	qt/hotkey: Get rid of global hotkey map instance ... Instead, we make a proper registry class and house it within the main window, then pass it to whatever needs access to the loaded hotkeys. This way, we avoid a global variable, and don't need to initialize a std::map instance before the program can do anything.	2018-08-07 02:28:17 -04:00
Zach Hilman	91cfe70301	loader: Add icon and title support to XCI	2018-08-06 23:13:42 -04:00
Zach Hilman	5927cf0e17	Use const where applicable	2018-08-06 23:06:33 -04:00
Zach Hilman	9e88f03e75	Avoid parsing RomFS to directory in NCA	2018-08-06 23:06:33 -04:00
Lioncash	da2f00ab7d	client_port: Make all data members private ... These members don't need to be entirely exposed, we can instead expose an API to operate on them without directly needing to mutate them We can also guard against overflow/API misuse this way as well, given active_sessions is an unsigned value.	2018-08-06 23:05:17 -04:00
bunnei	826b1394e8	Merge pull request #931 from DarkLordZach/nca-as-drd ... loader: Make AppLoader_NCA rely on directory loading code	2018-08-06 22:02:41 -04:00
bunnei	0c3c91e41c	Merge pull request #947 from lioncash/encoding ... game_list: Use QString::fromStdString() where applicable instead of c_str()	2018-08-06 22:02:01 -04:00
Hedges	e2b74f6354	GDBStub works with both Unicorn and Dynarmic now (#941) ... * GDBStub works with both Unicorn and Dynarmic now * Tidy up	2018-08-06 22:01:24 -04:00
bunnei	e218d79cc2	Merge pull request #943 from lioncash/decl ... game_list: Join declarations and assignments in onTextChanged()	2018-08-06 22:00:49 -04:00
bunnei	75df8a3969	Merge pull request #946 from lioncash/compress ... qt/main: Collapse if statement in UpdateRecentFiles()	2018-08-06 21:34:20 -04:00
bunnei	645d35ac32	Merge pull request #944 from lioncash/menu ... qt: Don't show error dialog when canceling the Load Folder dialog	2018-08-06 21:33:23 -04:00
bunnei	168958f8e2	Merge pull request #942 from lioncash/default ... qt: Minor cleanup-related changes	2018-08-06 21:32:25 -04:00
bunnei	f179e87864	Merge pull request #940 from lioncash/private ... kernel/event: Make data members private	2018-08-06 21:31:25 -04:00
bunnei	cf82358ee6	Merge pull request #936 from bunnei/avoid-copies ... gl_rasterizer_cache: Avoid superfluous surface copies.	2018-08-06 21:29:29 -04:00
bunnei	83ef37ca37	Merge pull request #934 from lioncash/chrono ... core_timing: Make GetGlobalTimeUs() return std::chrono::microseconds	2018-08-06 18:03:05 -04:00
Lioncash	96b6ad11c1	qt/main: Avoid sign conversions in UpdateRecentFiles() ... This was intermixing signed and unsigned values when they could all just be signed.	2018-08-06 15:42:44 -04:00
Lioncash	10d693b9c2	game_list: Remove unnecessary conversion to std::string in ValidateEntry() ... We can just use the file interfaces that Qt provides to prevent needing to convert to std::string.	2018-08-06 15:06:29 -04:00
Lioncash	a5ac53dd4c	game_list: Use QString::fromStdString() where applicable instead of c_str() ... The codec used by Qt for const char* and std::string don't necessarily have to be the same depending on locale. Therefore, we should be using the correct functions to do the conversions.	2018-08-06 15:06:30 -04:00
Lioncash	251e92513a	game_list: Join declarations and assignments in onTextChanged() ... There's no need to keep these separate from one another.	2018-08-06 14:35:40 -04:00
Lioncash	cf983888cc	qt/main: Collapse if statement in UpdateRecentFiles() ... Given the function accepts a boolean, we don't need to use an if statement here and repeat ourselves.	2018-08-06 14:32:28 -04:00
Lioncash	2b2dc00bfd	qt/main: Better file-existence checking within OnMenuRecentFile() and UpdateUITheme() ... In OnMenuRecentFile() we don't need to construct a QFileInfo instance just to check if a file exists, we can just use the static member function to do that (which Qt's documentation also notes as quicker than constructing an instance). In UpdateUITheme(), we just want to try and open the file and check the success of that operation. Technically speaking, between the existence check and the open call, the file can be deleted or moved, but still appear to succeed in code. i.e. 1. Existence check -> Returns true 2. File is moved/deleted 3. Open is called, the return value of which isn't checked 4. Nonsense behavior This way we combine the existence check and the open into one.	2018-08-06 14:17:13 -04:00
Lioncash	d33f641912	qt: Don't show error dialog when canceling the Load Folder dialog ... Previously, when canceling out of the Load Folder dialog, a user would get an error dialog about the selected folder not containing a main file, however, by canceling out of the dialog, no selection was actually made.	2018-08-06 14:02:34 -04:00
Lioncash	9764b4ec0e	qt/game_list_p: Remove redundant base class constructor invocations ... These occur automatically without the need to call them. While we're at it, also std::move the QString instance into its member variable.	2018-08-06 13:42:12 -04:00
Lioncash	7846295a8f	qt: Add missing override specifiers where applicable	2018-08-06 13:29:14 -04:00
Lioncash	00a68c5eea	qt: Default destructors where applicable ... Makes code consistent with our style of defaulting special member functions where applicable.	2018-08-06 13:27:08 -04:00
Lioncash	2feb1a8ba6	kernel/event: Make data members private ... Instead we can simply provide accessors to the required data instead of giving external read/write access to the variables directly.	2018-08-06 12:53:02 -04:00
bunnei	1ac45342dd	Merge pull request #933 from lioncash/memory ... memory: Correct prototype of ZeroBlock	2018-08-06 12:34:57 -04:00
mailwl	2ea0f0fd16	Service/Audio: audout_a.cpp: remove pragma once	2018-08-06 12:29:27 +03:00
bunnei	904d7eaa94	maxwell_3d: Remove outdated assert.	2018-08-05 23:57:19 -04:00
bunnei	57eb936200	gl_rasterizer_cache: Avoid superfluous surface copies.	2018-08-05 23:40:03 -04:00
bunnei	0b80bbeb95	Merge pull request #932 from lioncash/func ... core_timing: Use transparent functors where applicable	2018-08-05 23:37:53 -04:00
bunnei	f1b93d63d1	Merge pull request #929 from lioncash/addr ... gdbstub: Minor changes	2018-08-05 23:36:26 -04:00
bunnei	03b7ebbc08	Merge pull request #930 from lioncash/thread ... address_arbiter: Return by value from GetThreadsWaitingOnAddress()	2018-08-05 23:35:59 -04:00
bunnei	bb21c2198a	Merge pull request #925 from bunnei/audren ... Implement audren audio output	2018-08-05 23:35:22 -04:00
Lioncash	6c56754322	perf_stats: Correct literal used for MAX_LAG_TIME_US ... ms is shorthand for milliseconds, not microseconds, and given there's no comment indicating that this was intentional, it probably wasn't.	2018-08-05 22:12:58 -04:00
Lioncash	a0c3a46aa9	core_timing: Make GetGlobalTimeUs() return std::chrono::microseconds ... Enforces the time unit being returned and also allows using the standard time utilities to manipulate it.	2018-08-05 22:07:30 -04:00
Lioncash	2a7a2b739b	memory: Make prototype parameter names match their definitions ... Keeps the code consistent.	2018-08-05 21:39:09 -04:00
Lioncash	4aa31b0618	memory: Correct prototype of ZeroBlock ... Previously, the prototype wasn't matching the definition, which has a Processor parameter before the destination address.	2018-08-05 21:39:06 -04:00
Lioncash	2fc5c783ed	memory: Remove unnecessary const qualifiers in prototypes ... These aren't necessary, as value-wise const only matters in the definition.	2018-08-05 21:38:22 -04:00
Lioncash	6edd828101	core_timing: Convert typedef into a type alias ... Makes the alias a little more readable from left-to-right.	2018-08-05 21:27:14 -04:00
Lioncash	d9815b523b	core_timing: Use transparent functors where applicable ... Gets rid of the need to hardcode the type in multiple places. This will now be deduced automatically, based off the elements in the container being provided to the algorithm.	2018-08-05 21:19:24 -04:00
Zach Hilman	7f9430f7ae	loader: Make AppLoader_NCA rely on directory loading code ... Eliminates duplicate code shared between their Load methods, after all the only difference is how the romfs is handled.	2018-08-05 18:28:15 -04:00
bunnei	c8e5c74092	Merge pull request #927 from bunnei/fix-texs ... gl_shader_decompiler: Fix TEXS mask and dest.	2018-08-05 16:42:21 -04:00
Lioncash	00f7e584ce	gdbstub: Use type alias for breakpoint maps ... Rather than having to type out the full std::map type signature, we can just use a straightforward alias. While we're at it, rename GetBreakpointList to GetBreakpointMap, which makes the name more accurate. We can also get rid of unnecessary u64 static_casts, since VAddr is an alias for a u64.	2018-08-05 16:41:22 -04:00
Lioncash	89c076b4b1	gdbstub: Move all file-static variables into the GDBStub namespace ... Keeps everything under the same namespace. While we're at it, enclose them all within an inner anonymous namespace.	2018-08-05 16:41:18 -04:00
bunnei	c0af42d6eb	Merge pull request #912 from lioncash/global-var ... video_core: Eliminate the g_renderer global variable	2018-08-05 16:37:39 -04:00
Lioncash	7a77d0a71e	address_arbiter: Return by value from GetThreadsWaitingOnAddress() ... In all cases the vector being supplied is empty, so we can just return by value in these instances.	2018-08-05 16:29:17 -04:00
Lioncash	ca96f8db4e	gdbstub: Replace PAddr alias with VAddr ... In all cases, a virtual address is being passed in, not a physical one.	2018-08-05 15:56:01 -04:00
bunnei	fd715e54a1	gl_shader_decompiler: Fix TEXS mask and dest.	2018-08-05 01:47:09 -04:00
bunnei	ce46fb27ca	Merge pull request #926 from ogniK5377/vertex-attrib-format ... gl_rasterizer: Fix glVertexAttribFormat for integers	2018-08-05 01:38:54 -04:00
bunnei	b46df98e93	audio_core: Implement audren_u audio playback.	2018-08-04 21:54:30 -04:00
David Marcec	b96010bfa9	added braces for conditions	2018-08-05 11:36:55 +10:00
David Marcec	6d1e30e041	fix the attrib format for ints	2018-08-05 11:29:21 +10:00
bunnei	a0a605df06	Merge pull request #924 from lioncash/arp ... service: Add arp services	2018-08-04 21:20:26 -04:00
bunnei	cd96c04339	Merge pull request #921 from lioncash/view ... core/crypto: Minor changes	2018-08-04 21:17:10 -04:00
bunnei	1dee8ceda1	audio_core: Use s16 where possible for audio samples.	2018-08-04 18:22:58 -04:00
bunnei	f1cb3903ac	audio_core: Port codec code from Citra for ADPCM decoding.	2018-08-04 18:22:58 -04:00
Lioncash	de72956181	service: Add arp services ... Adds the basic skeleton of the arp services based off the information provided by Switch Brew.	2018-08-04 18:01:12 -04:00
Lioncash	df51207ed2	service: Remove redundant #pragma once directives ... These don't do anything within .cpp files (we don't include cpp files, so...)	2018-08-04 17:39:08 -04:00
Lioncash	0d04ee97dc	aes_util: Add static assertion to Transcode() and XTSTranscode() to ensure well-defined behavior ... These functions should only be given trivially-copyable types.	2018-08-04 17:30:52 -04:00
Lioncash	64c8212ae1	aes_util: Make CalculateNintendoTweak() an internally linked function ... This function doesn't directly depend on class state, so it can be hidden entirely from the interface in the cpp file.	2018-08-04 17:30:48 -04:00
Lioncash	b25468b498	aes_util: Make Transcode() a const member function ... This doesn't modify member state, so it can be made const.	2018-08-04 16:49:42 -04:00
Lioncash	8da651ac4d	core/crypto: Remove unnecessary includes	2018-08-04 16:44:07 -04:00
Lioncash	c1f76abfaf	key_manager: Use regular std::string instead of std::string_view ... The benefit of std::string_view comes from the idea of avoiding copies (essentially acting as a non-owning view), however if we're just going to copy into a local variable immediately, there's not much benefit gained here.	2018-08-04 16:37:30 -04:00
bunnei	02fccc0940	cubeb_sink: Support variable sample_rate and num_channels.	2018-08-04 15:30:10 -04:00
Zach Hilman	2cc962e171	content_archive: Add support for titlekey cryptography	2018-08-04 14:57:21 -04:00
bunnei	34b3f83498	audio_core: Sinks need unique names as well.	2018-08-04 14:34:12 -04:00
bunnei	9f846d3aa4	audio_core: Streams need unique names for CoreTiming.	2018-08-04 14:34:12 -04:00
bunnei	2b06301dbf	Merge pull request #849 from DarkLordZach/xci ... XCI and Encrypted NCA Support	2018-08-04 14:33:11 -04:00
bunnei	13d6593753	Merge pull request #919 from lioncash/sign ... gl_shader_manager: Amend sign differences in an assertion comparison in SetShaderUniformBlockBinding()	2018-08-04 14:29:59 -04:00
Lioncash	3b678b9e8e	gl_shader_manager: Invert conditional in SetShaderUniformBlockBinding() ... This lets us indent the majority of the code and places the error case first.	2018-08-04 02:57:11 -04:00
Lioncash	dde5dce736	gl_shader_manager: Amend sign differences in an assertion comparison in SetShaderUniformBlockBinding() ... Ensures both operands have the same sign in the comparison. While we're at it, we can get rid of the redundant casting of ub_size to an int. This type will always be trivial and alias a built-in type (not doing so would break backwards compatibility at a standard level).	2018-08-04 02:55:03 -04:00
Lioncash	2665457f4a	renderer_base: Make Rasterizer() return the rasterizer by reference ... All calling code assumes that the rasterizer will be in a valid state, which is a totally fine assumption. The only way the rasterizer wouldn't be is if initialization is done incorrectly or fails, which is checked against in System::Init().	2018-08-04 02:36:58 -04:00
Lioncash	6030c5ce41	video_core: Eliminate the g_renderer global variable ... We move the initialization of the renderer to the core class, while keeping the creation of it and any other specifics in video_core. This way we can ensure that the renderer is initialized and doesn't give unfettered access to the renderer. This also makes dependencies on types more explicit. For example, the GPU class doesn't need to depend on the existence of a renderer, it only needs to care about whether or not it has a rasterizer, but since it was accessing the global variable, it was also making the renderer a part of its dependency chain. By adjusting the interface, we can get rid of this dependency.	2018-08-04 02:36:57 -04:00
bunnei	762fcaf5de	Merge pull request #911 from lioncash/prototype ... video_core: Remove unimplemented Start() function prototype	2018-08-04 02:18:38 -04:00
bunnei	b0129489ea	Merge pull request #913 from lioncash/unused-func ... memory: Remove unused GetSpecialHandlers() function	2018-08-04 02:17:44 -04:00
bunnei	206f2e3436	Merge pull request #914 from lioncash/codeset ... kernel/process: Use accessors instead of class members for referencing segment array	2018-08-04 02:17:25 -04:00
bunnei	d43dad001e	Merge pull request #917 from lioncash/crash ... kernel/thread: Fix potential crashes introduced in 26de4bb5	2018-08-04 01:19:01 -04:00
Lioncash	e93fa7f2cc	kernel/thread: Fix potential crashes introduced in 26de4bb521 ... This amends cases where crashes can occur that were missed due to the odd way the previous code was set up (using 3DS memory regions that don't exist).	2018-08-03 23:49:10 -04:00
bunnei	29f31356d8	Merge pull request #910 from lioncash/unused ... gl_shader_decompiler: Remove unused variable in GenerateDeclarations()	2018-08-03 15:54:11 -04:00
Lioncash	e649db8c6b	kernel/process: Use std::array where applicable	2018-08-03 14:46:30 -04:00
Lioncash	2beda7c2b3	kernel/process: Use accessors instead of class members for referencing segment array ... Using member variables for referencing the segments array increases the size of the class in memory for little benefit. The same behavior can be achieved through the use of accessors that just return the relevant segment.	2018-08-03 14:45:45 -04:00
Lioncash	59b04c0df6	memory: Remove unused GetSpecialHandlers() function ... This is just unused code, so we may as well get rid of it.	2018-08-03 14:20:50 -04:00
bunnei	40e63ede6d	Merge pull request #908 from lioncash/memory ... core/memory: Get rid of 3DS leftovers	2018-08-03 14:07:49 -04:00
Lioncash	b4e050e6c4	video_core: Remove unimplemented Start() function prototype ... Given this has no definition, we can just remove it entirely.	2018-08-03 12:48:14 -04:00
Lioncash	b45e5c2399	gl_shader_decompiler: Remove unused variable in GenerateDeclarations() ... This variable was being incremented, but we were never actually using it.	2018-08-03 12:18:31 -04:00
Lioncash	555d76d065	gl_shader_manager: Make ProgramManager's GetCurrentProgramStage() a const member function ... This function doesn't modify class state, so it can be made const.	2018-08-03 12:08:17 -04:00
Lioncash	26de4bb521	core/memory: Get rid of 3DS leftovers ... Removes leftover code from citra that isn't needed.	2018-08-03 11:22:47 -04:00
David	c1d54f4aea	Added ability to change username & language code in the settings ui. Added IProfile::Get and SET::GetLanguageCode for libnx tests (#851)	2018-08-03 11:02:55 -04:00
bunnei	b6d61abd78	Merge pull request #895 from lioncash/sink ... sink_details: std::move std::function instances	2018-08-03 11:00:56 -04:00
bunnei	40e78b9a89	Merge pull request #898 from lioncash/mig ... service: Add migration services	2018-08-03 11:00:27 -04:00
bunnei	ef9433411d	Merge pull request #900 from lioncash/init ... math_util: Always initialize members of Rectangle	2018-08-03 11:00:10 -04:00
bunnei	00ba704a7f	Merge pull request #892 from lioncash/global ... video_core: Make global EmuWindow instance part of the base renderer …	2018-08-03 00:31:32 -04:00
bunnei	4c3c608d59	Merge pull request #894 from lioncash/object ... kernel: Move object class to its own source files	2018-08-03 00:28:43 -04:00
bunnei	4b84d5bcec	Merge pull request #904 from lioncash/static ... kernel/thread: Minor changes	2018-08-03 00:19:29 -04:00
bunnei	9e48ca23b2	Merge pull request #906 from lioncash/override ... input_common: minor changes	2018-08-03 00:18:52 -04:00
bunnei	49d817134a	Merge pull request #907 from lioncash/slot ... yuzu: Use Qt 5 signal/slots where applicable	2018-08-03 00:17:55 -04:00
bunnei	61ed68f3d0	Merge pull request #905 from lioncash/vma ... kernel/vm_manager: Minor changes	2018-08-02 23:18:03 -04:00
bunnei	291ccf7257	Merge pull request #903 from lioncash/copy ... vfs_vector: Minor changes	2018-08-02 23:01:19 -04:00
bunnei	52da0ce399	Merge pull request #901 from lioncash/ref ... gl_shader_manager: Take ShaderSetup instances by const reference in UseProgrammableVertexShader() and UseProgrammableFragmentShader()	2018-08-02 23:00:56 -04:00
Lioncash	db340f6402	yuzu: Use Qt 5 signal/slots where applicable ... Makes the signal/slot connections type-safe instead of string-based.	2018-08-02 22:18:33 -04:00
Lioncash	684fc2c320	input_common: Use std::move where applicable ... Avoids unnecessary atomic reference count increments and decrements	2018-08-02 21:51:11 -04:00
Lioncash	29b6afb82f	input_common: Add missing override specifiers	2018-08-02 21:44:25 -04:00
bunnei	4de18e054b	Merge pull request #899 from lioncash/unused ... hw: Remove unused files	2018-08-02 14:58:01 -04:00
bunnei	bae1822aed	Merge pull request #902 from lioncash/array ... gl_state: Make texture_units a std::array	2018-08-02 14:57:42 -04:00
bunnei	e79e967151	Merge pull request #891 from lioncash/ns ... service/ns: Add missing ns services	2018-08-02 14:57:24 -04:00
greggameplayer	fe64e1d38e	Implement RGB32F PixelFormat (#886) (used by Go Vacation)	2018-08-02 14:56:38 -04:00
bunnei	d0bd01146e	Merge pull request #893 from lioncash/psc ... service: Add the psc services	2018-08-02 14:53:55 -04:00
Lioncash	d94a173877	kernel/vm_manager: Convert loop into std::any_of()	2018-08-02 12:46:15 -04:00
Lioncash	c4e0c3d76c	kernel/vm_manager: Use const where applicable ... Makes our immutable state explicit.	2018-08-02 12:21:46 -04:00
Lioncash	ce5ad45278	kernel/vm_manager: Use the VAddr type alias in CarveVMA() ... These two variables correspond to address ranges.	2018-08-02 12:15:50 -04:00
Lioncash	6058c84b79	kernel/thread: Make GetFreeThreadLocalSlot()'s loop indices size_t ... Avoids using a u32 to compare against a range of size_t, which can be a source of warnings. While we're at it, compress a std::tie into a structured binding.	2018-08-02 12:01:25 -04:00
Lioncash	fac0e42b2f	kernel/thread: Make GetFreeThreadLocalSlot() reference parameter a const reference ... This function only reads the data being referenced, it doesn't modify it, so we can turn the reference into a const reference.	2018-08-02 11:56:11 -04:00
Lioncash	9a50a4f2cc	kernel/thread: Make GetFreeThreadLocalSlot() internally linked ... This function isn't used outside of this translation unit, so we can make it internally linked.	2018-08-02 11:54:23 -04:00
Lioncash	42a4c6b79e	vfs_vector: Remove unused variable in FindAndRemoveVectorElement() ... This wasn't being used for anything, so it can be removed.	2018-08-02 11:40:24 -04:00
Lioncash	cec9e9b811	vfs_vector: Avoid unnecessary copies where applicable ... The lambda elements should be taken by const reference here, and we can move the virtual directory passed to ReplaceFileWithSubdirectory()	2018-08-02 11:37:39 -04:00
Lioncash	6b32e24161	gl_state: Make texture_units a std::array ... Gets rid of the use of a raw C array.	2018-08-02 11:19:58 -04:00
Lioncash	d92e8ab062	gl_shader_manager: Take ShaderSetup instances by const reference in UseProgrammableVertexShader() and UseProgrammableFragmentShader() ... Avoids performing unnecessary copies of 65560 byte sized ShaderSetup instances, considering it's only used as part of lookup and not modified. Given the parameters were already const, it's likely taking these parameters by reference was intended but the ampersand was forgotten.	2018-08-02 11:09:46 -04:00
Lioncash	f2a03468b1	math_util: Always initialize members of Rectangle ... Prevents potentially using the members uninitialized.	2018-08-02 10:47:34 -04:00
Lioncash	c6db1c390b	hw: Remove unused files ... None of these files are used in any meaningful way. They're just leftovers from citra. Also has the benefit of getting rid of an unused global variable.	2018-08-02 10:23:10 -04:00
Lioncash	7469e26e5e	service: Add migration services ... Adds the basic skeleton for the mig:usr service based off information provided by Switch Brew.	2018-08-02 10:09:45 -04:00
Lioncash	c1c397d37c	audio_out: Use Buffer::Tag alias in GetTagsAndReleaseBuffers()'s prototype ... This makes the Buffer::Tag usage consistent with the Stream class's prototype of GetTagsAndReleaseBuffers().	2018-08-02 05:18:32 -04:00
Lioncash	2bc4ab3958	sink_details: Deduplicate long std::function repetition ... We can just use type aliases to avoid needing to write the same long type twice	2018-08-01 23:56:02 -04:00
Lioncash	89ebef6571	sink_details: std::move std::function instances ... Given std::function is allowed to potentially allocate, these should be std::move'd to prevent potential reallocation (should that ever happen).	2018-08-01 23:50:48 -04:00
Lioncash	bf45092c61	kernel: Move object class to its own source files ... General moving to keep kernel object types separate from the direct kernel code. Also essentially a preliminary cleanup before eliminating global kernel state in the kernel code.	2018-08-01 23:34:42 -04:00
Lioncash	42c5171322	logging/log: Remove incorrect description in PCV doc comment ... PCV isn't the parental control service.	2018-08-01 23:31:31 -04:00
Lioncash	5233040ab4	service: Add psc services ... Adds the basic skeleton for the psc services based off the information provided by Switch Brew.	2018-08-01 23:31:27 -04:00
Lioncash	0f2ac928f2	video_core: Make global EmuWindow instance part of the base renderer class ... Makes the global a member of the RendererBase class. We also change this to be a reference. Passing any form of null pointer to these functions is incorrect entirely, especially given the code itself assumes that the pointer would always be in a valid state. This also makes it easier to follow the lifecycle of instances being used, as we explicitly interact the renderer with the rasterizer, rather than it just operating on a global pointer.	2018-08-01 21:40:30 -04:00
bunnei	746d7d4d28	Merge pull request #888 from lioncash/caps ... service: Add capture services	2018-08-01 21:34:28 -04:00
bunnei	9bb8720289	Merge pull request #890 from lioncash/logger ... lm: Amend name of ILogger	2018-08-01 21:33:11 -04:00
bunnei	16b2fd9fc8	Merge pull request #889 from lioncash/fsp ... service/filesystem: Add fsp:ldr and fsp:pr services	2018-08-01 21:32:54 -04:00
Lioncash	48acb764a4	service/ns: Add missing ns services ... Implements the basic skeleton of ns:am2, ns:ec, ns:rid, ns:rt, ns:su, ns:vm, and ns:web based off the information provided by Switch Brew and SwIPC.	2018-08-01 18:02:18 -04:00
Lioncash	f77cfab516	lm: Amend name of ILogger ... Previously this was being registered with the name "Logger". While we're at it, also change the name of the class to match it.	2018-08-01 17:08:44 -04:00
Lioncash	208a457909	service/filesystem: Add fsp:ldr and fsp:pr services ... Adds the basic skeleton for the remaining fsp services based off information provided by Switch Brew.	2018-08-01 17:01:29 -04:00
Lioncash	e39294c267	service: Add capture services ... Adds the basic skeleton for the capture services based off information provided by Switch Brew.	2018-08-01 16:45:51 -04:00
Lioncash	d109279543	service: Add bpc and pcv services ... Adds the basic skeleton for the remaining pcv-related services based off information on Switch Brew.	2018-08-01 16:13:04 -04:00
Unknown	0d8fcab136	Implement R32_FLOAT RenderTargetFormat	2018-08-01 15:31:42 +02:00
bunnei	703663d761	Merge pull request #882 from lioncash/unused ... kernel/thread: Remove unimplemented function prototype	2018-07-31 22:25:49 -07:00
Zach Hilman	13cdf1f159	Add missing parameter to files.push_back()	2018-08-01 00:16:54 -04:00
Zach Hilman	0497bb5528	Fix merge conflicts with opus and update docs	2018-08-01 00:16:54 -04:00
Zach Hilman	187d8e215f	Use more descriptive error codes and messages	2018-08-01 00:16:54 -04:00
Zach Hilman	9d59b96ef9	Use static const instead of const static	2018-08-01 00:16:54 -04:00
Zach Hilman	a9c921a41d	Use ErrorEncrypted where applicable and fix no keys crash	2018-08-01 00:16:54 -04:00
Zach Hilman	03149d3e4a	Add missing includes and use const where applicable	2018-08-01 00:16:54 -04:00
Zach Hilman	150527ec19	Allow key loading from %YUZU_DIR%/keys in addition to ~/.switch	2018-08-01 00:16:54 -04:00
Zach Hilman	cc8234fa89	Use SHGetKnownFolderPath instead of SHGetFolderPathA	2018-08-01 00:16:54 -04:00
Zach Hilman	239a3113e4	Make XCI comply to review and style guidelines	2018-08-01 00:16:54 -04:00
Zach Hilman	22342487e8	Extract mbedtls to cpp file	2018-08-01 00:16:54 -04:00
Zach Hilman	83c3ae8be8	Add missing string.h include	2018-08-01 00:16:54 -04:00
Zach Hilman	c54a10cb4f	Update mbedtls and fix compile error	2018-08-01 00:16:54 -04:00
Zach Hilman	df5b75694f	Remove files that are not used	2018-08-01 00:16:54 -04:00
bunnei	d2ad279a32	Merge pull request #871 from bunnei/audio-config ... audio_core: Add configuration settings.	2018-07-31 21:04:26 -07:00
Lioncash	49e198b20d	kernel/thread: Remove unimplemented function prototype ... Given there's no implementation, we may as well remove the code entirely.	2018-07-31 23:21:38 -04:00
bunnei	ff2c1b0a94	Merge pull request #877 from lioncash/remove ... kernel: Remove unused object_address_table.cpp/.h	2018-07-31 20:11:39 -07:00
bunnei	98af269415	Merge pull request #880 from lioncash/audio ... service/audio: Add missing services	2018-07-31 20:11:04 -07:00
bunnei	ca84b530a3	audio_core: Add configuration settings.	2018-07-31 22:38:42 -04:00
bunnei	f5efac3442	Merge pull request #876 from lioncash/include ... kernel: Remove unnecessary includes	2018-07-31 19:16:05 -07:00
Lioncash	bba63b33a1	service/audio: Add missing services ... Adds the missing audctl service, as well as the :a and :d services for audin, audout, audrec, and audren.	2018-07-31 21:58:30 -04:00
bunnei	da07faebfe	Merge pull request #879 from lioncash/audio ... audout_u: Remove std::move in OpenAudioOutImpl()	2018-07-31 16:49:56 -07:00
bunnei	0a2b219a31	Merge pull request #864 from FearlessTobi/port-3973 ... Port #3973 from Citra: "Remove polymorphism issue"	2018-07-31 09:34:23 -07:00
bunnei	3575c076cb	Merge pull request #869 from Subv/ubsan ... Corrected a few error cases detected by asan/ubsan	2018-07-31 09:24:13 -07:00
bunnei	fd020ad52a	Merge pull request #875 from lioncash/fgm ... service: Add fgm services	2018-07-31 09:23:17 -07:00
bunnei	3a2581cc7d	Merge pull request #874 from lioncash/am ... service/am: Add missing am services	2018-07-31 09:22:56 -07:00
Lioncash	369f6e58aa	kernel: Remove unused object_address_table.cpp/.h ... These source files were entirely unused throughout the rest of the codebase. This also has the benefit of getting rid of a global variable as well.	2018-07-31 11:03:08 -04:00
Lioncash	1ced7bbea5	audout_u: Remove std::move in OpenAudioOutImpl() ... Previously the code was using the values from params further below after it was std::moved. Thankfully, given AudoutParams is a trivially copyable struct, the values would have simply been copied in this instance and not invalidated to garbage values.	2018-07-31 10:24:38 -04:00
Lioncash	a2304fad16	kernel: Remove unnecessary includes ... Removes unnecessary direct dependencies in some headers and also gets rid of indirect dependencies that were being relied on to be included.	2018-07-31 10:15:17 -04:00
bunnei	b79362b9da	Merge pull request #870 from lioncash/init ... arm_dynarmic: Correct initializer list order	2018-07-31 07:12:54 -07:00
Lioncash	7da8f15461	service/am: Add missing am services ... Adds the basic skeleton for missing am services idle:sys, omm, and spsm based off the information provided by Switch Brew.	2018-07-31 08:02:20 -04:00
Lioncash	268eeeb406	service: Add fgm services ... Adds the basic skeleton for the fgm services based off the information provided by Switch Brew.	2018-07-31 08:01:19 -04:00
Lioncash	f08c0520a4	arm_dynarmic: Make SetTlsAddress() prototype and definition consistent ... Makes the definition use the same type aliases as in its prototype.	2018-07-31 07:58:26 -04:00
Lioncash	9d6aa7bff7	arm_dynarmic: Remove unnecessary qualifying of ThreadContext ... Given the ARM_Dynarmic class inherits from ARM_Interface, we don't need to qualify here.	2018-07-31 07:56:59 -04:00
Lioncash	444a01afa6	arm_dynarmic: Correct initializer list order ... Amends the initializer list to be in the same order that each variable would be initialized in. We also do this to ensure we don't use a bogus uninitialized instance of the exclusive monitor within MakeJit() We can also remove the jit member from the initializer list as this is initialized by PageTableChanged()	2018-07-31 07:54:58 -04:00
Lioncash	e373027a73	service: Add the pcie service ... Adds the basic skeleton of the pcie service based off information on Switch Brew.	2018-07-31 06:40:21 -04:00
bunnei	bf9c62bc76	Merge pull request #855 from bunnei/cubeb ... Audio output backend based on cubeb	2018-07-30 20:29:17 -07:00
bunnei	f437c11caf	audio_core: Implement Sink and SinkStream interfaces with cubeb.	2018-07-30 21:45:24 -04:00
bunnei	9ef227e09d	audio_core: Add interfaces for Sink and SinkStream.	2018-07-30 21:45:24 -04:00
Subv	8191273a3d	MacroInterpreter: Avoid left shifting negative values. ... The branch target is signed, so multiply by 4 instead of left shifting by 2	2018-07-30 20:38:24 -05:00
Subv	e119e17d18	nvhost_gpu: Added checks to ensure we don't read past the end of the entries when handling a GPU command list.	2018-07-30 20:09:13 -05:00
Subv	2482aca7c3	nvhost_ctrl_gpu: Only read the input parameters if they are actually there. ... Passing nullptr to memcpy is undefined behavior.	2018-07-30 20:08:36 -05:00
Tobias	420f8fb29e	Port #3758 from Citra (#852): Add missing std::string import in text_formatter	2018-07-30 16:03:47 -07:00
bunnei	0e8a2c7222	audio_core: Misc. improvements to stream/buffer/audio_out.	2018-07-30 18:58:40 -04:00
bunnei	eaf66b4c9f	audio_core: Move to audout_u impl. ... - This is necessary so streams are created on the same thread.	2018-07-30 18:44:16 -04:00
David	a483e5e28d	Implemented various hwopus functions (#853)	2018-07-30 15:42:20 -07:00
bunnei	05ee92a357	Merge pull request #861 from FearlessTobi/port-3972 ... Port #3972 from Citra: "common/timer: use std::chrono, avoid platform-dependent code"	2018-07-30 14:13:56 -07:00
bunnei	e6b08b2209	Merge pull request #862 from FearlessTobi/port-3997 ... Port #3997 from Citra: "common/string_utils: replace boost::transform with std counterpart"	2018-07-30 14:13:34 -07:00
bunnei	884a4e1e19	Merge pull request #859 from FearlessTobi/port-3837 ... Port #3837 from Citra: "citra-qt: Add build date in about dialog"	2018-07-30 10:11:43 -07:00
Tobias	1e873eea36	Port #3769 from Citra: "Update Dark theme to latest version"	2018-07-30 10:11:17 -07:00
bunnei	45d1438530	Merge pull request #858 from lioncash/cast ... partition_filesystem: Remove dynamic_cast in PrintDebugInfo()	2018-07-30 10:09:36 -07:00
bunnei	8b8637978d	Merge pull request #860 from FearlessTobi/port-3911 ... Port #3911 from Citra: "citra-qt: optimize settings application"	2018-07-30 10:08:55 -07:00
bunnei	a6f886418a	Merge pull request #863 from FearlessTobi/port-3913 ... Port #3913 from Citra: "citra_qt: Remove obsolete application attribute"	2018-07-30 10:08:05 -07:00
bunnei	f8094c2617	Merge pull request #865 from FearlessTobi/port-3732 ... Port #3732 from Citra: "common: Fix compilation on ARM"	2018-07-30 10:07:45 -07:00
bunnei	c5fa3560a6	Merge pull request #857 from lioncash/wlan ... service: Add wlan services	2018-07-30 10:06:52 -07:00
bunnei	2c4bb11015	Merge pull request #856 from lioncash/btm ... service: Add btm services	2018-07-30 10:06:34 -07:00
Hexagon12	fd797e2424	Add some HID commands (#843) ... * Added some HID commands * Addressed comments	2018-07-30 10:06:21 -07:00
Cameron Cawley	1670c4421f	Port #3732 from Citra: "common: Fix compilation on ARM"	2018-07-29 15:51:31 +02:00
B3n30	6e5f83ee24	remove polymorphism issue	2018-07-29 15:24:41 +02:00
fearlessTobi	c87f198201	Port #3913 from Citra: "citra_qt: Remove obsolete application attribute"	2018-07-29 15:13:08 +02:00
zhupengfei	ff510157d8	common/string_utils: replace boost::transform with std counterpart ... Note: according to cppreference it is necessary to convert char to unsigned char when using std::tolower and std::toupper, otherwise the behaviour would be undefined.	2018-07-29 15:05:43 +02:00
zhupengfei	38a1113674	Port #3972 from Citra: "common/timer: use std::chrono, avoid platform-dependent code"	2018-07-29 14:58:30 +02:00
fearlessTobi	b97739029b	Port #3911 from Citra: "Optimize settings application"	2018-07-29 14:37:18 +02:00
fearlessTobi	e8674f1f09	Port #3837 from Citra: "Add build date in about dialog"	2018-07-29 14:27:19 +02:00
Lioncash	57c4d7aa00	partition_filesystem: Remove dynamic_cast in PrintDebugInfo() ... We shouldn't be upcasting our file instances. Given a PartitionFilesystem is currently designed to accept any arbitrary VfsFile instances, casting to a more specific type than that is just bad design, and shows an interface design issue.	2018-07-29 06:16:59 -04:00
Lioncash	6ea416091e	service: Add wlan services ... Adds the basic skeleton for the wlan services based off the information on Switch Brew.	2018-07-28 21:54:55 -04:00
Lioncash	7ce6858086	service/btm: Add basic implementation of GetCoreImpl() ... Based off information on SwIPC and Switch Brew.	2018-07-28 21:09:07 -04:00
Lioncash	ca7655be3a	service: Add btm services ... Adds the skeleton for the btm services based off the information on Switch Brew.	2018-07-28 21:09:07 -04:00
bunnei	458fdda700	Merge pull request #847 from lioncash/ncm ... service: Add ncm services	2018-07-28 10:46:09 -07:00
bunnei	d00dcdb1be	Merge pull request #846 from lioncash/mii ... service: Add mii services	2018-07-28 10:45:31 -07:00
bunnei	e1d66ea794	Merge pull request #842 from bunnei/audio-core ... Initial implementation of Audio Core	2018-07-27 20:25:32 -07:00
bunnei	f1c519f2cb	audout: Implement IAudioOut interface with AudioCore.	2018-07-27 22:55:39 -04:00
bunnei	2a742229ee	core: Add AudioCore to global state.	2018-07-27 22:33:37 -04:00
bunnei	ab756fd068	audio_core: Add initial code for keeping track of audout state.	2018-07-27 22:33:31 -04:00
Zach Hilman	906d785c73	RomFS Extraction	2018-07-27 18:14:03 -04:00
Lioncash	7931cc0ceb	service: Add ncm services ... Adds the basic skeleton for the ncm services based off information on Switch Brew.	2018-07-27 17:38:30 -04:00
bunnei	0191a1e526	Merge pull request #845 from lioncash/nfc ... service: Add nfc services	2018-07-27 14:29:27 -07:00
bunnei	2128ab2d21	Merge pull request #839 from FearlessTobi/actually-port-3594 ... Port #3594 from Citra: "citra_qt: Add Continue/Pause & Toggle Speed Limit hotkeys"	2018-07-27 13:06:56 -07:00
bunnei	833ebbb626	Merge pull request #844 from lioncash/lbl ... service: Add the lbl service	2018-07-27 13:06:11 -07:00
bunnei	d2749ef0ed	Merge pull request #841 from lioncash/btdrv ... service: Add the btdrv service	2018-07-27 13:05:36 -07:00
Lioncash	f46bfdd77d	service: Add mii services ... Adds the skeleton for the mii services based off information provided by Switch Brew	2018-07-27 16:01:29 -04:00
Lioncash	50dadc33e3	service/nfc: Implement Create[x]Interface functions ... These simply return the respective interface.	2018-07-27 15:12:08 -04:00
Lioncash	04d144aa40	service: Add nfc services ... Adds the skeleton of the nfc service based off the information provided on Switch Brew.	2018-07-27 14:50:24 -04:00
Lioncash	ea8dd8b650	service/lbl: Implement EnableVrMode, DisableVrMode and GetVrMode ... Implements these functions according to the information available on Switch Brew.	2018-07-27 14:20:42 -04:00
Lioncash	c2c543e8f7	service: Add the lbl service ... Adds the skeleton of the lbl service based off the information provided by Switch Brew.	2018-07-27 14:20:07 -04:00
bunnei	dc4e5f9159	Merge pull request #837 from lioncash/priv ... kernel/timer: Make data members private where applicable	2018-07-27 07:18:50 -07:00
Lioncash	f49248437e	service: Add the btdrv service ... Adds the skeleton for the btdrv service based off the information provided by Switch Brew	2018-07-26 18:06:17 -04:00
Lioncash	1121622dc1	service/hid: Add the hidbus, hid:dbg, hid:sys, and hid:tmp services	2018-07-26 15:05:42 -04:00
Lioncash	7550c2c866	service/hid: Add the xcd:sys service	2018-07-26 15:05:42 -04:00
Lioncash	82cb5f030d	service/hid: Add irs services	2018-07-26 15:05:24 -04:00
bunnei	ec2b7cdb1d	Merge pull request #836 from FearlessTobi/port-3594 ... Port #3665 from Citra: "frontend: Log Citra version"	2018-07-26 12:04:30 -07:00
bunnei	f1fbb476df	Merge pull request #835 from FearlessTobi/port-minor-prs ... Port #3641 and #3702 from Citra (Small changes to default_ini and gitignore)	2018-07-26 12:03:56 -07:00
bunnei	8440b814bc	Merge pull request #834 from lioncash/grc ... service: Add the grc:c service	2018-07-26 12:03:30 -07:00
bunnei	41d7b020a8	Merge pull request #832 from lioncash/nim ... service: Add the nim services	2018-07-26 12:02:29 -07:00
bunnei	e4191b624c	Merge pull request #831 from lioncash/ldn ... service: Add ldn services	2018-07-26 11:52:42 -07:00
bunnei	40eb243f86	Merge pull request #830 from lioncash/socket ... service/sockets: Add missing socket services	2018-07-26 11:51:11 -07:00
bunnei	e013fdc2b2	Merge pull request #808 from lioncash/mem-dedup ... video_core/memory_manager: Avoid repeated unnecessary page slot lookups	2018-07-26 11:50:27 -07:00
fearlessTobi	18c2c96927	Port #3594 from Citra	2018-07-26 16:09:52 +02:00
Lioncash	b28af1f6c9	service: Add the grc:c service ... Adds the basic skeleton for the grc:c service based off the information provided by Switch Brew.	2018-07-26 09:53:58 -04:00
Subv	f85cff0f48	GPU: Allow using R16F as a render target format.	2018-07-26 08:52:21 -05:00
Lioncash	0cd843151f	kernel/timer: Make data members private where applicable ... Instead, we can just expose functions that return the queryable state instead of letting anything modify it.	2018-07-26 09:51:44 -04:00
fearlessTobi	6f05a57712	Port #3665 from Citra	2018-07-26 15:51:14 +02:00
fearlessTobi	7a2acc86e6	Port #3641 from Citra	2018-07-26 15:35:10 +02:00
Lioncash	f916611e32	service: Add the nim services ... Adds the skeleton for the nim services based off information from Switch Brew.	2018-07-26 02:47:06 -04:00
Lioncash	8781beaf0d	service: Add ldn services ... Adds ldn services based off information provided by Switch Brew.	2018-07-26 01:48:06 -04:00
bunnei	57cd80c410	Merge pull request #827 from lioncash/log ... service/lm: Minor changes	2018-07-25 22:30:43 -07:00
bunnei	31642ae2ee	Merge pull request #825 from greggameplayer/R16_G16 ... Implement R16_G16	2018-07-25 22:30:25 -07:00
Lioncash	3f5dfc4d96	service/sockets: Add ethc:c and ethc:i services	2018-07-26 01:07:21 -04:00
Lioncash	165e7645e1	service/sockets: Add missing bsdcfg socket service	2018-07-26 01:00:15 -04:00
Sebastian Valle	1958d07d7d	Merge pull request #828 from lioncash/ldr ... service: Add ldr services	2018-07-25 23:44:13 -05:00
Sebastian Valle	8ac52c6b56	Merge pull request #826 from lioncash/erpt ... service: Add erpt and eupld services	2018-07-25 23:43:47 -05:00
Sebastian Valle	0e05f98be2	Merge pull request #823 from lioncash/nifm ... service/nifm: Deduplicate interface code	2018-07-25 23:43:03 -05:00
Lioncash	3fb124961e	service: Add ldr services ... Adds the skeleton for the ldr-related services based off the information provided on Switch Brew.	2018-07-25 23:11:03 -04:00
Lioncash	91d86df920	lm: Move LM's class declaration into the cpp file ... This isn't used directly outside of this translation unit, so we can hide it from external use.	2018-07-25 22:40:16 -04:00
Lioncash	6f4d3d8163	lm: Amend names of Initialize() in Logger and Initialize() in LM ... Amends these to match the information on Switch Brew.	2018-07-25 22:39:39 -04:00
Lioncash	8650be1020	lm: Add missing function entry to Logger's function table	2018-07-25 22:26:32 -04:00
Lioncash	7458e71f24	service: Add eupld services ... Adds the skeleton for the eupld services based off information on Switch Brew.	2018-07-25 22:13:43 -04:00
Lioncash	821f2c03cb	service: Add the erpt services ... Adds the basic skeleton of the erpt service based off information on Switch Brew.	2018-07-25 22:13:39 -04:00
bunnei	b0adb9a3d9	Merge pull request #824 from lioncash/nvdrv ... service/nvdrv: Minor changes	2018-07-25 19:02:08 -07:00
bunnei	851089b482	Merge pull request #822 from lioncash/pm ... service: Add pm services	2018-07-25 19:01:28 -07:00
Unknown	4672a01cbf	Implement R16_G16 ... correct trailing white spaces Delete tabs correct placement Add RG16F & RG16UI & RG16I & RG16S PixelFormats Return correct data according to changes done previously correct PixelFormat declaration correct coding style error correct coding style error part 2 correct RG16S Declaration error correct alignment	2018-07-26 02:01:29 +02:00
Mat M	d245610939	Merge pull request #820 from lioncash/es ... service: Add the es service	2018-07-25 18:51:59 -04:00
Mat M	19b5ae5a25	Merge pull request #821 from lioncash/wait ... wait_tree: Add missing switch case for WaitTreeThread::GetText()	2018-07-25 18:45:01 -04:00
bunnei	c88382517c	Merge pull request #819 from Subv/srgb ... GPU: Use the right texture format for sRGBA framebuffers.	2018-07-25 14:47:26 -07:00
Lioncash	f9951352f6	service/nvdrv: Take std::string in Open() by const reference ... Avoids copies from being made, since the string is only ever used for lookup, the data is never transfered anywhere. Ideally, we'd use a std::string_view here, but devices is a std::unordered_map, not a std::map, so we can't use heterogenous lookup here.	2018-07-25 17:37:43 -04:00
Lioncash	a2cd07d094	service/nvdrv: Use std::move where applicable ... Avoids unnecessary reference count increments and decrements. In one case, we don't need to make a shared_ptr copy at all, just to call a member function.	2018-07-25 17:31:08 -04:00
Lioncash	85ed42a1d2	service/nifm: Deduplicate interface code ... Rather than having the same code for each nifm service variant, we can centralize it on one class and get rid of a bit of extra code.	2018-07-25 17:18:41 -04:00
Lioncash	c664f8a257	service: Add pm services ... Adds the skeleton for the process management services based off information on Switch Brew.	2018-07-25 16:57:16 -04:00
Lioncash	2474340684	wait_tree: Add missing switch case for WaitTreeThread::GetText() ... We were missing the enum entry for WaitIPC	2018-07-25 15:50:41 -04:00
Lioncash	4175712976	service: Add the es service ... Adds the skeleton for the ETicket service based off the information on Switch Brew	2018-07-25 15:36:55 -04:00
Mat M	1e4935c3a0	Merge pull request #801 from lioncash/time ... time: Add the time:a service	2018-07-25 15:08:33 -04:00
Mat M	d3fd0351a7	Merge pull request #804 from lioncash/log ... svc: Log parameters in SetMemoryAttribute()	2018-07-25 14:43:24 -04:00
Lioncash	3c1cb3b11e	time: Add the time:a service ... Given we already have time:s and time:u, we should also have time:a	2018-07-25 14:42:04 -04:00
bunnei	657bd113e3	Merge pull request #803 from MerryMage/core_timing_util ... core_timing: Split off utility functions into core_timing_util	2018-07-25 11:09:31 -07:00
bunnei	52cb5dcf0f	Merge pull request #802 from lioncash/unreach ... wait_tree: Silence warning about all code paths not returning a value	2018-07-25 11:08:44 -07:00
bunnei	5c42cadbc9	Merge pull request #800 from lioncash/set ... set_sys: Implement SetColorSetId()	2018-07-25 10:25:29 -07:00
Subv	c5b838aeef	GPU: Use the right texture format for sRGBA framebuffers.	2018-07-25 09:52:39 -05:00
Subv	ee8123bf13	GPU: Allow the use of Z24S8 as a texture format.	2018-07-25 09:41:24 -05:00
bunnei	0686183c3e	Merge pull request #816 from Subv/z32_s8 ... GPU: Implemented the Z32_S8_X24 depth buffer format.	2018-07-25 07:37:00 -07:00
bunnei	af787744ab	Merge pull request #815 from Subv/z32f_tex ... GPU: Allow using Z32 as a texture format.	2018-07-25 07:33:09 -07:00
bunnei	704824d50a	Merge pull request #814 from Subv/rt_r8 ... GPU: Allow the usage of R8 as a render target format.	2018-07-25 07:32:18 -07:00
bunnei	a6ea6febc9	Merge pull request #809 from lioncash/rasterizer ... gl_rasterizer: Minor cleanup	2018-07-24 19:31:34 -07:00
bunnei	e0106a7d68	Merge pull request #811 from Subv/code_address_assert ... GPU: Remove the assert that required the CODE_ADDRESS to be 0.	2018-07-24 19:31:09 -07:00
Subv	daf2504d31	GPU: Implemented the Z32_S8_X24 depth buffer format.	2018-07-24 20:41:40 -05:00
Subv	f747a7e35d	GPU: Allow using Z32 as a texture format.	2018-07-24 19:54:23 -05:00
Subv	4f574201ea	GPU: Allow the usage of R8 as a render target format.	2018-07-24 19:49:36 -05:00
bunnei	340771ccd7	Merge pull request #806 from lioncash/friend ... friend: Deduplicate interfaces	2018-07-24 17:42:16 -07:00
bunnei	5d4ad999cf	Merge pull request #810 from Subv/r16 ... GPU: Implemented the R16 and R16F texture formats.	2018-07-24 17:41:02 -07:00
bunnei	ea0bc8c002	Merge pull request #805 from lioncash/sign ... svc: Resolve sign comparison warnings in WaitSynchronization()	2018-07-24 12:50:03 -07:00
Subv	8f2c4191ab	GPU: Remove the assert that required the CODE_ADDRESS to be 0. ... Games usually just leave it at 0 but nouveau sets it to something else. This already works fine, the assert is useless.	2018-07-24 13:54:12 -05:00
Subv	4cc1e180ec	GPU: Implemented the R16 and R16F texture formats.	2018-07-24 13:39:16 -05:00
Lioncash	0162f8b3a7	gl_rasterizer: Replace magic number with GL_INVALID_INDEX in SetupConstBuffers() ... This is just the named constant that OpenGL provides, so we can use that instead of using a literal -1	2018-07-24 12:24:49 -04:00
Lioncash	16139ed53b	gl_rasterizer: Use std::string_view instead of std::string when checking for extensions ... We can avoid heap allocations here by just using a std::string_view instead of performing unnecessary copying of the string data.	2018-07-24 12:10:37 -04:00
Lioncash	b5eb3905cd	gl_rasterizer: Use in-class member initializers where applicable ... We can just assign to the members directly in these cases.	2018-07-24 12:08:12 -04:00
Lioncash	bf608f125e	video_core/memory_manager: Replace a loop with std::array's fill() function in PageSlot() ... We already have a function that does what this code was doing, so let's use that instead.	2018-07-24 11:56:30 -04:00
Lioncash	d71e19fd75	video_core/memory_manager: Avoid repeated unnecessary page slot lookups ... We don't need to keep calling the same function over and over again in a loop, especially when the behavior is slightly non-trivial. We can just keep a reference to the looked up location and do all the checking and assignments based off it instead.	2018-07-24 11:19:54 -04:00
Lioncash	4cf2185e81	deconstructed_rom_directory: Remove unused FindRomFS() function	2018-07-24 10:54:07 -04:00
Lioncash	07c2d057bd	friend: Add friend:m, friend:s, and friend:v services ... Given we already have friend:a and friend:u, we should add the remaining services as well.	2018-07-24 10:26:01 -04:00
Lioncash	9539a1eadd	friend/interface: Add missing CreateDaemonSuspendSessionService() to the function handler table	2018-07-24 10:24:16 -04:00
Lioncash	77daef44b0	friend: Deduplicate interfaces	2018-07-24 10:21:51 -04:00
Lioncash	c73410bf2c	svc: Resolve sign comparison warnings in WaitSynchronization() ... The loop's induction variable was signed, but we were comparing against an unsigned variable.	2018-07-24 09:55:17 -04:00
Lioncash	8e8e906432	svc: Log parameters in SetMemoryAttribute() ... Provides slightly more context than only logging out the address value.	2018-07-24 09:46:46 -04:00
bunnei	316c994f55	Merge pull request #798 from lioncash/const ... arm_dynarmic: Make MakeJit() a const member function	2018-07-24 04:48:06 -07:00
bunnei	23e85b6b9f	Merge pull request #797 from lioncash/explicit ... core: Make converting constructors explicit where applicable	2018-07-24 04:47:26 -07:00
bunnei	1cbf7ac6ea	Merge pull request #795 from lioncash/decl ... apm/interface: Remove redundant declaration of InstallInterfaces()	2018-07-24 04:46:41 -07:00
bunnei	0f830d08f1	Merge pull request #799 from Subv/tex_r32f ... GPU: Implement texture format R32F.	2018-07-24 04:46:07 -07:00
bunnei	d092ea0870	Merge pull request #794 from lioncash/ref ... mutex: Pass SharedPtr to GetHighestPriorityMutexWaitingThread() by reference	2018-07-24 04:45:34 -07:00
bunnei	b70f757913	Merge pull request #796 from bunnei/gl-uint ... maxwell_to_gl: Implement VertexAttribute::Type::UnsignedInt.	2018-07-24 04:44:56 -07:00
bunnei	54af9c206a	Merge pull request #789 from bunnei/tex-wrap-border ... maxwell_to_gl: Implement Texture::WrapMode::Border.	2018-07-24 04:44:37 -07:00
Lioncash	a61124a9e7	time: Simplify interface creation ... We can use one instance of the interface instead of duplicating code.	2018-07-24 06:21:27 -04:00
MerryMage	44646e2ea0	core_timing: Split off utility functions into core_timing_util	2018-07-24 11:03:24 +01:00
MerryMage	b8459d2778	CMakeLists: Sort filenames	2018-07-24 11:02:53 +01:00
Lioncash	9d2cacdc9e	wait_tree: Silence warning about all code paths not returning a value ... If code execution hits this spot, something has gone very wrong, so mark the path as unreachable. This silences a warning on MSVC.	2018-07-24 04:06:55 -04:00
Lioncash	63c605c04a	set_sys: Implement SetColorSetId()	2018-07-24 00:48:16 -04:00
Lioncash	76f191ce36	ipc_helper: Add helper member function for popping enum values to RequestParser	2018-07-24 00:47:51 -04:00
bunnei	2f029577c7	Merge pull request #793 from lioncash/priv ... ipc_helpers: Make member variables of ResponseBuilder private	2018-07-23 21:23:27 -07:00
bunnei	bc5b65a1b0	Merge pull request #785 from lioncash/fs ... partition_filesystem: Use std::move where applicable	2018-07-23 20:36:59 -07:00
bunnei	69c45ce71c	gl_rasterizer: Implement texture border color.	2018-07-23 23:34:42 -04:00
bunnei	6b3e54621f	maxwell_to_gl: Implement Texture::WrapMode::Border.	2018-07-23 23:34:41 -04:00
Subv	ccc42702b5	GPU: Implement texture format R32F.	2018-07-23 22:21:31 -05:00
Lioncash	7d124ec82b	arm_dynarmic: Make MakeJit() a const member function ... This functions doesn't modify instance state, so it can be a made a const member function.	2018-07-23 23:19:37 -04:00
Lioncash	1d755abce4	core: Make converting constructors explicit where applicable ... Avoids unwanted implicit conversions. Thankfully, given the large amount of cleanup in past PRs, only this tiny amount is left over to cover.	2018-07-23 23:13:22 -04:00
bunnei	1ff3bea6c7	Merge pull request #791 from bunnei/rg32f-rgba32f-bgra8 ... gl_rasterizer_cache: Implement formats BGRA8_UNORM/RGBA32_FLOAT/RG32_FLOAT	2018-07-23 20:13:19 -07:00
bunnei	2ff86f5765	maxwell_to_gl: Implement VertexAttribute::Type::UnsignedInt.	2018-07-23 23:12:14 -04:00
bunnei	92304181d5	Merge pull request #792 from lioncash/retval ... gl_shader_decompiler: Correct return value of WriteTexsInstruction()	2018-07-23 20:06:48 -07:00
Lioncash	8b83adfed6	apm/interface: Remove redundant declaration of InstallInterfaces() ... This is already declared in apm/apm.h	2018-07-23 23:01:04 -04:00
Lioncash	42b5158c96	mutex: Pass SharedPtr to GetHighestPriorityMutexWaitingThread() by reference ... The pointed to thread's members are simply observed in this case, so we don't need to copy it here.	2018-07-23 22:54:35 -04:00
bunnei	47ac369180	Merge pull request #790 from bunnei/shader-print-instr ... gl_shader_decompiler: Print instruction value in shader comments.	2018-07-23 19:48:47 -07:00
bunnei	c2b4ff5d48	Merge pull request #788 from bunnei/shader-check-zero ... gl_shader_decompiler: Check if SetRegister result is ZeroIndex.	2018-07-23 19:44:05 -07:00
Zach Hilman	59cb258409	VFS Regression and Accuracy Fixes (#776) ... * Regression and Mode Fixes * Review Fixes * string_view correction * Add operator& for FileSys::Mode * Return std::string from SanitizePath * Farming Simulator Fix * Use != With mode operator&	2018-07-23 19:40:35 -07:00
Lioncash	22fd3f0026	hle_ipc: Make constructors explicit where applicable	2018-07-23 22:40:24 -04:00
Lioncash	33e2033af5	gl_shader_decompiler: Correct return value of WriteTexsInstruction() ... This should be returning void, not a std::string	2018-07-23 22:31:58 -04:00
Lioncash	2a1daf8f83	ipc_helpers: Make member variables of ResponseBuilder private ... These aren't used externally at all, so they can be made private.	2018-07-23 22:29:07 -04:00
bunnei	f6657bc8d7	Merge pull request #787 from bunnei/tlds ... gl_shader_decompiler: Implement shader instruction TLDS.	2018-07-23 19:14:01 -07:00
bunnei	25635907a2	Merge pull request #786 from lioncash/exclusive ... exclusive_monitor: Use consistent type alias for u64	2018-07-23 19:11:05 -07:00
bunnei	84cc5dd35d	Merge pull request #784 from lioncash/loader ... loader: Minor cleanup	2018-07-23 19:08:12 -07:00
bunnei	1ce5e04be8	Merge pull request #783 from lioncash/linker ... linker: Remove unused parameter from WriteRelocations()	2018-07-23 19:07:22 -07:00
bunnei	10dd03dec5	Merge pull request #782 from lioncash/file ... loader/nro: Minor changes	2018-07-23 19:06:30 -07:00
bunnei	9505283989	gl_shader_decompiler: Implement shader instruction TLDS.	2018-07-23 22:02:51 -04:00
bunnei	f6f6f3811e	Merge pull request #781 from lioncash/decl ... gl_shader_decompiler: Simplify GetCommonDeclarations()	2018-07-23 18:30:23 -07:00
bunnei	52ec1840f5	Merge pull request #780 from lioncash/move ... vi: Minor changes	2018-07-23 18:29:11 -07:00
bunnei	e0b6771e25	Merge pull request #779 from lioncash/shared ... hle: Remove unused config_mem and shared_page source files	2018-07-23 18:28:45 -07:00
bunnei	a27c0099ed	gl_rasterizer_cache: Implement RenderTargetFormat RG32_FLOAT.	2018-07-23 21:22:54 -04:00
bunnei	3a19c1098d	gl_rasterizer_cache: Implement RenderTargetFormat RGBA32_FLOAT.	2018-07-23 21:22:53 -04:00
bunnei	bcc184acfa	gl_rasterizer_cache: Implement RenderTargetFormat BGRA8_UNORM.	2018-07-23 21:22:44 -04:00
bunnei	89db8c2171	gl_rasterizer_cache: Add missing log statements.	2018-07-23 21:20:09 -04:00
bunnei	c4322ce87e	gl_shader_decompiler: Print instruction value in shader comments.	2018-07-23 21:11:05 -04:00
bunnei	81aa02424b	gl_shader_decompiler: Check if SetRegister result is ZeroIndex.	2018-07-23 21:08:40 -04:00
Lioncash	e12c84d5c5	exclusive_monitor: Use consistent type alias for u64 ... Uses the same type aliases we use for virtual addresses, and converts one lingering usage of std::array<uint64_t, 2> to u128 for consistency.	2018-07-23 20:54:57 -04:00
Lioncash	db48ebb9c9	partition_filesystem: Use std::move where applicable ... Avoids copying a std::string instance and avoids unnecessary atomic reference count incrementing and decrementing.	2018-07-23 20:27:11 -04:00
Lioncash	a147fa5825	loader: Remove unnecessary constructor call in IdentifyFile() ... RealVfsFile inherits from VfsFile, the instance from std::make_shared is already compatible with the function argument type, making the copy constructor call unnecessary.	2018-07-23 17:44:58 -04:00
Lioncash	184c516182	linker: Remove unused parameter from WriteRelocations() ... is_jump_relocation is never used within the function, so we can just remove it.	2018-07-23 17:40:12 -04:00
Lioncash	1b4d0ac20e	nro: Replace inclusion with a forward declaration ... It's sufficient to use a forward declaration instead of a direct inclusion here.	2018-07-23 17:29:02 -04:00
Lioncash	2b497e5830	nro: Make bracing consistent ... Makes the code more uniform, and also braces cases where the body of an unbraced conditional travels more than one line.	2018-07-23 17:24:29 -04:00
Lioncash	ac8133b9ee	nro: Make constructor explicit ... Makes it consistent with the other Apploader constructors, and prevents implicit conversions.	2018-07-23 17:20:33 -04:00
Lioncash	1c16700372	nro: Remove unused forward declaration ... This isn't used anywhere in the header.	2018-07-23 17:19:42 -04:00
bunnei	07e5319d55	Merge pull request #695 from DarkLordZach/nro-asset ... NRO Assets and NACP File Format	2018-07-23 14:14:11 -07:00
Lioncash	3b88ce3dcb	gl_shader_decompiler: Simplify GetCommonDeclarations()	2018-07-23 17:11:18 -04:00
Lioncash	1432912ae8	vi: Add std::is_trivially_copyable checks to Read and Write functions ... It's undefined behavior to memcpy an object that isn't considered trivially copyable, so put a compile-time check in to make sure this doesn't occur.	2018-07-23 14:53:54 -04:00
Lioncash	344a0c91f2	vi: std::move std::vector in constructors where applicable ... Allows avoiding unnecessary copies of the vector depending on the calling code. While we're at it, remove a redundant no-parameter base constructor call	2018-07-23 14:49:54 -04:00
Lioncash	cbe841c9c9	hle: Remove config_mem.h/.cpp ... This is just an unused hold-over from citra, so we can get rid of this to trim off an exposed global, among other things.	2018-07-23 12:57:34 -04:00
Lioncash	1f3889a290	hle: Remove shared_page.h/.cpp ... This is a holdover from citra that's essentially unused.	2018-07-23 12:53:07 -04:00
Lioncash	e85308cd90	set: Add missing log call in GetAvailableLanguageCodeCount() ... Forgot to include this in 22f448b632	2018-07-23 12:37:42 -04:00
bunnei	7138b99f21	Merge pull request #775 from lioncash/str ... string_util: Minor changes	2018-07-23 09:34:41 -07:00
Zach Hilman	e8f641a52d	NRO Assets and NACP file format ... Cleanup Review fixes	2018-07-23 12:34:26 -04:00
bunnei	a85366a40c	Merge pull request #777 from lioncash/lang ... set: Amend return value of GetAvailableLanguageCodes()	2018-07-23 09:34:08 -07:00
Lioncash	22f448b632	set: Implement GetAvailableLanguageCodeCount() ... This just returns the size of the language code buffer.	2018-07-23 00:29:40 -04:00
Lioncash	37aeecd29f	set: Correct return code size of value in GetAvailableLanguageCodes() ... The return code should be 32-bit in size.	2018-07-23 00:29:22 -04:00
bunnei	e85a528bb9	Merge pull request #769 from bunnei/shader-mask-fixes ... shader_bytecode: Implement other TEXS masks.	2018-07-22 18:03:31 -07:00
Lioncash	9d33122197	string_util: Get rid of separate resize() in CPToUTF16(), UTF16ToUTF8(), CodeToUTF8() and UTF8ToUTF16() ... There's no need to perform the resize separately here, since the constructor allows presizing the buffer. Also move the empty string check before the construction of the string to make the early out more straightforward.	2018-07-22 16:39:21 -04:00
Lioncash	26a157cd31	string_util: Use emplace_back() in SplitString() instead of push_back() ... This is equivalent to doing: push_back(std::string("")); which is likely not to cause issues, assuming a decent std::string implementation with small-string optimizations implemented in its design, however it's still a little unnecessary to copy that buffer regardless. Instead, we can use emplace_back() to directly construct the empty string within the std::vector instance, eliminating any possible overhead from the copy.	2018-07-22 15:36:32 -04:00
Lioncash	cd46b267f5	string_util: Remove unnecessary std::string instance in TabsToSpaces() ... We can just use the variant of std::string's replace() function that can replace an occurrence with N copies of the same character, eliminating the need to allocate a std::string containing a buffer of spaces.	2018-07-22 15:35:48 -04:00
bunnei	a4b2af7382	Merge pull request #774 from Subv/atomic_signal ... Kernel/SVC: Perform atomic accesses in SignalProcessWideKey as per the real kernel.	2018-07-22 12:26:03 -07:00
bunnei	c994cdc532	Merge pull request #773 from Subv/gl_ext_check ... Frontend: Check for more required OpenGL extensions during startup.	2018-07-22 11:47:07 -07:00
bunnei	5ee4c49c30	Merge pull request #768 from lioncash/string-view ... file_util, vfs: Use std::string_view where applicable	2018-07-22 11:32:28 -07:00
Subv	7841447cf0	Kernel/SVC: Perform atomic accesses in SignalProcessWideKey as per the real kernel.	2018-07-22 12:27:24 -05:00
bunnei	3618a68f93	Merge pull request #770 from lioncash/construct ... gl_shader_decompiler: Remove redundant Subroutine construction in AddSubroutine()	2018-07-22 10:24:20 -07:00
Subv	ba2fb83d60	Frontend: Check for more required OpenGL extensions during startup.	2018-07-22 12:05:38 -05:00
MerryMage	0b1c2e5505	Implement exclusive monitor	2018-07-22 15:55:17 +01:00
Lioncash	0797657bc0	gl_shader_decompiler: Remove redundant Subroutine construction in AddSubroutine() ... We don't need to toss away the Subroutine instance after the find() call and reconstruct another instance with the same data right after it. Particularly give Subroutine contains a std::set.	2018-07-22 03:30:35 -04:00
bunnei	148a5bef7e	shader_bytecode: Implement other TEXS masks.	2018-07-22 03:23:15 -04:00
Lioncash	0081252d31	vfs: Correct file_p variable usage within InterpretAsDirectory() ... ReplaceFileWithSubdirectory() takes a VirtualFile and a VirtualDir, but it was being passed a string as one of its arguments. The only reason this never caused issues is because this template isn't instantiated anywhere yet. This corrects an issue before it occurs.	2018-07-22 03:22:28 -04:00
Lioncash	398444e676	file_util, vfs: Use std::string_view where applicable ... Avoids unnecessary construction of std::string instances where applicable.	2018-07-22 03:22:21 -04:00
bunnei	258a5cee84	Merge pull request #765 from lioncash/file ... file_util: Remove goto usages from Copy()	2018-07-22 00:03:35 -07:00
bunnei	af4bde8cd1	Merge pull request #767 from bunnei/shader-cleanup ... gl_shader_decompiler: Remove unused state tracking and minor cleanup.	2018-07-22 00:03:17 -07:00
bunnei	2d563ec8d5	Merge pull request #766 from bunnei/shader-sel ... gl_shader_decompiler: Implement SEL instruction.	2018-07-21 23:13:27 -07:00
bunnei	ef163c1a15	Merge pull request #764 from lioncash/move ... file_util: Minor changes to ScanDirectoryTree() and ForeachDirectoryEntry()	2018-07-21 22:05:30 -07:00
bunnei	f5a2944ab6	gl_shader_decompiler: Remove unused state tracking and minor cleanup.	2018-07-22 01:00:44 -04:00
bunnei	c43eaa94f3	gl_shader_decompiler: Implement SEL instruction.	2018-07-22 00:37:12 -04:00
Lioncash	c5de0a67a8	file_util: Remove goto usages from Copy() ... We can just leverage std::unique_ptr to automatically close these for us in error cases instead of jumping to the end of the function to call fclose on them.	2018-07-21 23:08:55 -04:00
Lioncash	0ba7fe4ab1	file_util: Use a u64 to represent number of entries ... This avoids a truncating cast on size. I doubt we'd ever traverse a directory this large, however we also shouldn't truncate sizes away.	2018-07-21 22:42:08 -04:00
Lioncash	964154ce44	file_util: std::move FST entries in ScanDirectoryTree() ... Avoids unnecessary copies when building up the FST entries.	2018-07-21 22:31:44 -04:00
bunnei	63fbf9a7d3	gl_rasterizer_cache: Blit surfaces on recreation instead of flush and load.	2018-07-21 21:51:06 -04:00
bunnei	4301f0b539	gl_rasterizer_cache: Use GPUVAddr as cache key, not parameter set.	2018-07-21 21:51:06 -04:00
bunnei	cd47391c2d	gl_rasterizer_cache: Use zeta_width and zeta_height registers for depth buffer.	2018-07-21 21:51:06 -04:00
bunnei	d8c60029d6	gl_rasterizer: Use zeta_enable register to enable depth buffer.	2018-07-21 21:51:06 -04:00
bunnei	5287991a36	maxwell_3d: Add depth buffer enable, width, and height registers.	2018-07-21 21:51:05 -04:00
bunnei	53a219f163	Merge pull request #759 from lioncash/redundant ... file_util: Remove redundant duplicate return in GetPathWithoutTop()	2018-07-21 18:50:38 -07:00
bunnei	3ac736c003	Merge pull request #748 from lioncash/namespace ... video_core: Use nested namespaces where applicable	2018-07-21 18:50:14 -07:00
bunnei	f5e87f4ce1	Merge pull request #758 from lioncash/sync ... common: Remove synchronized_wrapper.h	2018-07-21 18:30:31 -07:00
bunnei	9533875eeb	Merge pull request #760 from lioncash/path ... file_util: Use an enum class for GetUserPath()	2018-07-21 18:30:04 -07:00
Subv	5c49e56d41	GPU: Implement the NVGPU_IOCTL_CHANNEL_KICKOFF_PB ioctl2 command. ... This behaves quite similarly to the SubmitGPFIFO command. Referenced from Ryujinx. Many thanks to @gdkchan for investigating this!	2018-07-21 15:50:02 -05:00
Lioncash	d66b43dadf	file_util: Use an enum class for GetUserPath() ... Instead of using an unsigned int as a parameter and expecting a user to always pass in the correct values, we can just convert the enum into an enum class and use that type as the parameter type instead, which makes the interface more type safe. We also get rid of the bookkeeping "NUM_" element in the enum by just using an unordered map. This function is generally low-frequency in terms of calls (and I'd hope so, considering otherwise would mean we're slamming the disk with IO all the time) so I'd consider this acceptable in this case.	2018-07-21 16:21:19 -04:00
Lioncash	34d6a1349c	file_util: Remove explicit type from std::min() in GetPathWithoutTop() ... Given both operands are the same type, there won't be an issue with overload selection that requires making this explicit.	2018-07-21 15:19:32 -04:00
Lioncash	41660c8923	file_util: Remove redundant duplicate return in GetPathWithoutTop()	2018-07-21 15:18:23 -04:00
Lioncash	973fdce79b	common: Remove synchronized_wrapper.h ... This is entirely unused in the codebase.	2018-07-21 14:51:44 -04:00
bunnei	0f20fa5a1e	Merge pull request #754 from lioncash/part ... partition_filesystem, vfs_real: Minor changes	2018-07-21 11:38:52 -07:00
bunnei	de7cb91995	Merge pull request #750 from lioncash/ctx ... arm_interface: Remove unused tls_address member of ThreadContext	2018-07-21 11:38:16 -07:00
bunnei	1c7c1347d8	Merge pull request #746 from lioncash/tests ... tests/arm_test_common: Minor changes	2018-07-21 10:55:29 -07:00
bunnei	ff8754f921	Merge pull request #747 from lioncash/unimplemented ... gl_shader_manager: Remove unimplemented function prototype	2018-07-21 10:54:58 -07:00
bunnei	89cc8c1617	Merge pull request #755 from lioncash/ctor ... file_sys/errors: Remove redundant object constructor calls	2018-07-21 10:53:53 -07:00
bunnei	552aac7e6c	Merge pull request #749 from lioncash/consistency ... gpu: Rename Get3DEngine() to Maxwell3D()	2018-07-21 10:51:00 -07:00
bunnei	fe2498a650	Merge pull request #751 from Subv/tpidr_el0 ... CPU: Save and restore the TPIDR_EL0 system register on every context switch	2018-07-21 10:48:30 -07:00
bunnei	3d938b8c60	Merge pull request #753 from lioncash/const ... vfs: Minor changes	2018-07-21 10:44:08 -07:00
bunnei	d85cfc94e2	Merge pull request #752 from Subv/vfs_load ... Loader: Only print the module names and addresses if they actually exist.	2018-07-20 22:57:18 -07:00
Lioncash	459e158340	file_sys/errors: Remove redundant object constructor calls ... Given we're already constructing the error code, we don't need to call the constructor inside of it.	2018-07-20 22:37:54 -04:00
Lioncash	b46c0ed1fa	vfs_real: Remove redundant copying of std::vector instances in GetFiles() and GetSubdirectories() ... We already return by value, so we don't explicitly need to make the copy.	2018-07-20 22:30:22 -04:00
Lioncash	ec71915ede	partition_filesystem, vfs_real: Add missing standard includes	2018-07-20 22:28:35 -04:00
Lioncash	d36e327ba6	partition_filesystem, vfs_real: Use std::move in ReplaceFileWithSubdirectory() where applicable ... Avoids unnecessary atomic increment and decrement operations.	2018-07-20 22:23:58 -04:00
Lioncash	2b91386e15	partition_filesystem, vfs_real: Use std::distance() instead of subtraction ... This is a little bit more self-documenting on what is being done here.	2018-07-20 22:19:17 -04:00
Lioncash	3e0727df1b	vfs_offset: Simplify TrimToFit() ... We can simply use std::clamp() here, instead of using an equivalent with std::max() and std::min().	2018-07-20 22:04:37 -04:00
Lioncash	894b0de0f2	vfs: Make WriteBytes() overload taking a std::vector pass the std::vector by const reference ... Given the data is intended to be directly written, there's no need to take the std::vector by value and copy the data.	2018-07-20 21:51:30 -04:00
Lioncash	dd09439fee	vfs: Use variable template variants of std::is_trivially_copyable ... Provides the same behavior, but with less writing	2018-07-20 21:47:19 -04:00
Lioncash	05231d8b08	vfs: Amend constness on pointers in WriteBytes() and WriteArrays() member functions to be const qualified ... These functions don't modify the data being pointed to, so these can be pointers to const data	2018-07-20 21:40:15 -04:00
Subv	966874e357	Loader: Only print the module names and addresses if they actually exist.	2018-07-20 19:59:15 -05:00
Subv	d84eb9dac6	CPU: Save and restore the TPIDR_EL0 system register on every context switch. ... Note that there's currently a dynarmic bug preventing this register from being written.	2018-07-20 19:57:45 -05:00
bunnei	8afc21f175	Merge pull request #743 from lioncash/view ... logging: Use std::string_view where applicable	2018-07-20 17:17:04 -07:00
bunnei	d4104c72aa	Merge pull request #745 from lioncash/package ... param_package: Minor changes	2018-07-20 17:16:54 -07:00
Lioncash	ae09adfcb3	arm_interface: Remove unused tls_address member of ThreadContext ... Currently, the TLS address is set within the scheduler, making this member unused.	2018-07-20 18:57:40 -04:00
Lioncash	d5bc9aef4e	gl_shader_manager: Replace unimplemented function prototype ... This was just a linker error waiting to happen.	2018-07-20 18:39:54 -04:00
Lioncash	863579736c	gpu: Rename Get3DEngine() to Maxwell3D() ... This makes it match its const qualified equivalent.	2018-07-20 18:34:49 -04:00
Lioncash	bb960c8cb4	video_core: Use nested namespaces where applicable ... Compresses a few namespace specifiers to be more compact.	2018-07-20 18:23:54 -04:00
bunnei	2b7d862366	Merge pull request #742 from bunnei/misc-apm ... apm: Improve stub for GetPerformanceConfiguration.	2018-07-20 15:01:19 -07:00
Lioncash	48733744bb	arm_test_common: Get rid of truncation warnings ... Explicitly cast the value to a u8 to show that this is intentional.	2018-07-20 17:53:53 -04:00
Lioncash	a8bb1eb39f	arm_test_common: Make file static variable a member variable of the testing environment ... Gets rid of file-static behavior.	2018-07-20 17:52:37 -04:00
Lioncash	a44475207c	arm_test_common: Add missing header guard	2018-07-20 17:48:43 -04:00
Lioncash	3268321f4b	param_package: Take std::string by value in string-based Set() function ... Allows avoiding string copies by letting the strings be moved into the function calls.	2018-07-20 17:24:06 -04:00
Lioncash	6279c2dcf4	param_package: Use std::unordered_map's insert_or_assign instead of map indexing ... This avoids a redundant std::string construction if a key doesn't exist in the map already. e.g. data[key] requires constructing a new default instance of the value in the map (but this is wasteful, since we're already setting something into the map over top of it).	2018-07-20 17:24:06 -04:00
Lioncash	474ec2ee5f	param_package: Get rid of file-static std::string construction ... Avoids potential dynamic allocation occuring during program launch	2018-07-20 17:24:02 -04:00
Lioncash	f63ccbd936	logging/filter: Use std::string_view in ParseFilterString() ... Allows avoiding constructing std::string instances, since this only reads an arbitrary sequence of characters. We can also make ParseFilterRule() internal, since it doesn't depend on any private instance state of Filter	2018-07-20 15:58:46 -04:00
Lioncash	7a1a860abe	logging/backend: Add missing standard includes ... A few inclusions were being satisfied indirectly. To prevent breakages in the future, include these directly.	2018-07-20 15:31:27 -04:00
Lioncash	457d1b4490	logging/backend: Use std::string_view in RemoveBackend() and GetBackend() ... These can just use a view to a string since its only comparing against two names in both cases for matches. This avoids constructing std::string instances where they aren't necessary.	2018-07-20 15:27:20 -04:00
bunnei	dffd154d6d	apm: Improve stub for GetPerformanceConfiguration.	2018-07-20 15:20:01 -04:00
Lioncash	0a0b3c4b9f	ipc_helpers: Add PushEnum() member function to ResponseBuilder ... Allows pushing strongly-typed enum members without the need to always cast them at the call sites. Note that we *only* allow strongly-typed enums in this case. The reason for this is that strongly typed enums have a guaranteed defined size, so the size of the data being pushed is always deterministic. With regular enums this can be a little more error-prone, so we disallow them. This function simply uses the underlying type of the enum to determine the size of the data. For example, if an enum is defined as: enum class SomeEnum : u16 { SomeEntry }; if PushEnum(SomeEnum::SomeEntry); is called, then it will push a u16-size amount of data.	2018-07-20 15:00:58 -04:00
bunnei	c1c9ab31e8	Merge pull request #740 from Subv/acc_crash ... HLE/ACC: Stub IManagerForApplication::GetAccountId to return an error.	2018-07-20 09:47:47 -07:00
bunnei	29f49bd3c1	Merge pull request #738 from lioncash/sign ... gl_state: Get rid of mismatched sign conversions in Apply()	2018-07-20 09:21:57 -07:00
bunnei	ffbd51e207	Merge pull request #737 from lioncash/move ... filesys/loader: std::move VirtualFile instances in constructors where applicable	2018-07-20 09:21:15 -07:00
bunnei	701c7cb85c	Merge pull request #736 from lioncash/null ... audout_u/audren_u: Ensure null terminators are written out in ListAudioOutsImpl(), ListAudioDeviceName(), and GetActiveAudioDeviceName()	2018-07-20 09:17:07 -07:00
bunnei	fbc2bcd4a9	Merge pull request #735 from lioncash/video-unused ... maxwell_3d: Remove unused variable within GetStageTextures()	2018-07-20 09:16:15 -07:00
bunnei	741cae1e1d	Merge pull request #734 from lioncash/thread ... thread: Convert ThreadStatus into an enum class	2018-07-20 09:15:52 -07:00
bunnei	a1805ceb0b	Merge pull request #733 from lioncash/dirs ... partition_filesystem: Return pfs_dirs member variable within GetSubdirectories()	2018-07-20 09:15:16 -07:00
bunnei	86d1649b32	Merge pull request #732 from lioncash/unused ... nso: Minor changes	2018-07-20 09:14:10 -07:00
bunnei	204d707ce7	Merge pull request #731 from lioncash/shadow ... gl_shader_decompiler: Eliminate variable and declaration shadowing	2018-07-20 09:13:36 -07:00
Subv	9c7321fe6d	HLE/ACC: Stub IManagerForApplication::GetAccountId to return an error. ... And make IManagerForApplication::CheckAvailability always return false. Returning a bogus id from GetAccountId causes games to crash on boot. We should investigate this with a hwtest and either stub it properly or implement it.	2018-07-20 11:02:25 -05:00
Lioncash	0faa13baeb	gl_state: Make references const where applicable in Apply()	2018-07-20 01:12:29 -04:00
Lioncash	e6b3d3a9ea	gl_state: Get rid of mismatched sign conversions ... While we're at it, amend the loop variable type to be the same width as that returned by the .size() call.	2018-07-20 01:11:20 -04:00
Lioncash	8874d0e657	loader/{nca, nro}: std::move VirtualFile in the constructors where applicable ... This avoids unnecessary atomic reference count increments and decrements	2018-07-20 00:10:24 -04:00
Lioncash	0e9d58e82a	vfs_offset: std::move file and name parameters of OffsetVfsFile ... Avoids potentially unnecessary atomic reference count incrementing and decrementing, as well as string copying.	2018-07-20 00:04:54 -04:00
bunnei	f36affdbe3	Merge pull request #730 from lioncash/string ... gl_shader_decompiler: Remove unnecessary const from return values	2018-07-19 20:46:43 -07:00
Lioncash	40c9c5a55c	audren_u: Use a std::array instead of std::string for holding the audio interface/device name ... std::string doesn't include the null-terminator in its data() + size() range. This ensures that the null-terminator will also be written to the buffer	2018-07-19 23:15:27 -04:00
Lioncash	c20cea118b	audout_u: Use a std::array instead of std::string for holding the audio interface name ... Uses a type that doesn't potentially dynamically allocate, and ensures that the name of the interface is properly null-terminated when writing it to the buffer.	2018-07-19 23:15:00 -04:00
Lioncash	8b08f82dc7	maxwell_3d: Remove unused variable within GetStageTextures()	2018-07-19 22:38:28 -04:00
Lioncash	dbfe82773d	thread: Convert ThreadStatus into an enum class ... Makes the thread status strongly typed, so implicit conversions can't happen. It also makes it easier to catch mistakes at compile time.	2018-07-19 22:08:56 -04:00
Lioncash	bbd6429ecb	partition_filesystem: Return pfs_dirs member variable within GetSubdirectories() ... This should be returned here, otherwise pfs_dirs is effectively only ever added to, but never read.	2018-07-19 21:08:50 -04:00
Lioncash	364b950515	nso: Silence implicit sign conversion warnings	2018-07-19 20:51:15 -04:00
Lioncash	a25c5b982a	nso: Remove unused function ReadSegment()	2018-07-19 20:49:27 -04:00
Lioncash	f26866ff6a	gl_shader_decompiler: Eliminate variable and declaration shadowing ... Ensures that no identifiers are being hidden, which also reduces compiler warnings.	2018-07-19 20:32:49 -04:00
Lioncash	c2121cb059	gl_shader_decompiler: Remove unnecessary const from return values ... This adds nothing from a behavioral point of view, and can inhibit the move constructor/RVO	2018-07-19 20:11:04 -04:00
Lioncash	1bdb67440b	pl_u: Simplify WriteBuffer() calls in GetSharedFontInOrderOfPriority() ... With the new overload, we can simply pass the container directly.	2018-07-19 19:50:30 -04:00
bunnei	d3cfaf95c8	Merge pull request #726 from lioncash/overload ... hle_ipc: Introduce generic WriteBuffer overload for multiple container types	2018-07-19 16:18:38 -07:00
bunnei	0b13ce1435	Merge pull request #725 from lioncash/bytes ... pl_u: Specify correct size for buffers in GetSharedFontInOrderOfPriority()	2018-07-19 16:16:30 -07:00
bunnei	af08034c71	Merge pull request #728 from Subv/acc_profile ... HLE/ACC: Change the default user id and small improvements to the way we handle profiles	2018-07-19 16:15:01 -07:00
bunnei	2aeb3355e4	Merge pull request #727 from Subv/acc_users ... HLE/ACC: Write a single whole user id in ListAllUsers and ListOpenUsers.	2018-07-19 16:13:45 -07:00
bunnei	c6352ffc58	Merge pull request #724 from lioncash/printf ... pl_u: Remove printf specifier in log call in a log call in GetSharedFontInOrderOfPriority()	2018-07-19 16:13:07 -07:00
bunnei	ec468c990d	Merge pull request #723 from lioncash/gdb ... gdbstub: Get rid of a few signed/unsigned comparisons	2018-07-19 16:12:40 -07:00
bunnei	f43d8ea523	Merge pull request #722 from lioncash/signed ... hid: Resolve a signed/unsigned comparison warning	2018-07-19 16:12:15 -07:00
bunnei	2194308245	Merge pull request #721 from lioncash/svc ... svc: Correct always true assertion case in SetThreadCoreMask	2018-07-19 16:11:40 -07:00
bunnei	b5c77313de	Merge pull request #719 from lioncash/docs ... loader: Amend Doxygen comments	2018-07-19 16:11:09 -07:00
bunnei	dd0446ff43	Merge pull request #718 from lioncash/read ... loader/nso: Check if read succeeded in IdentifyFile() before checking magic value	2018-07-19 16:10:29 -07:00
bunnei	31413f0d2f	Merge pull request #717 from lioncash/explicit ... hle/service: Make constructors explicit where applicable	2018-07-19 16:08:07 -07:00
Subv	05549e45c5	HLE/ACC: Return an IProfile that is consistent with what was requested. ... The default username for now is "yuzu". We should eventually allow the creation of users in the emulator and have the ability to modify their parameters.	2018-07-19 16:53:42 -05:00
Subv	50e2777724	HLE/ACC: Change the default user id to be consistent with what we tell games on startup. ... In IApplicationFunctions::PopLaunchParameter we tell the games that they were launched as user id 1.	2018-07-19 16:51:55 -05:00
Subv	b102815f1f	HLE/ACC: Write a single whole user id in ListAllUsers and ListOpenUsers. ... We only emulate a single user id for now.	2018-07-19 16:19:46 -05:00
bunnei	7244671137	Merge pull request #716 from lioncash/construct ... nvflinger: Emplace Display instances directly	2018-07-19 14:18:29 -07:00
Lioncash	ff500a7b68	hle_ipc: Introduce generic WriteBuffer overload for multiple container types ... This introduces a slightly more generic variant of WriteBuffer(). Notably, this variant doesn't constrain the arguments to only accepting std::vector instances. It accepts whatever adheres to the ContiguousContainer concept in the C++ standard library. This essentially means, std::array, std::string, and std::vector can be used directly with this interface. The interface no longer forces you to solely use containers that dynamically allocate. To ensure our overloads play nice with one another, we only enable the container-based WriteBuffer if the argument is not a pointer, otherwise we fall back to the pointer-based one.	2018-07-19 17:05:12 -04:00
bunnei	eb9b55eafe	Merge pull request #715 from lioncash/const-ref ... nvdrv: Take std::string by const reference in GetDevice()	2018-07-19 13:27:48 -07:00
Sebastian Valle	78dd1cd441	Merge pull request #720 from Subv/getentrytype_root ... Filesystem: Return EntryType::Directory for the root directory.	2018-07-19 15:23:32 -05:00
Lioncash	df001e83b1	pl_u: Specify correct size for buffers in GetSharedFontInOrderOfPriority() ... This WriteBuffer overload expects its size argument to be in bytes, not elements.	2018-07-19 15:57:58 -04:00
Lioncash	b879fb84a2	svc: Correct always true assertion case in SetThreadCoreMask ... The reason this would never be true is that ideal_processor is a u8 and THREADPROCESSORID_DEFAULT is an s32. In this case, it boils down to how arithmetic conversions are performed before performing the comparison. If an unsigned value has a lesser conversion rank (aka smaller size) than the signed type being compared, then the unsigned value is promoted to the signed value (i.e. u8 -> s32 happens before the comparison). No sign-extension occurs here either. An alternative phrasing: Say we have a variable named core and it's given a value of -2. u8 core = -2; This becomes 254 due to the lack of sign. During integral promotion to the signed type, this still remains as 254, and therefore the condition will always be true, because no matter what value the u8 is given it will never be -2 in terms of 32 bits. Now, if one type was a s32 and one was a u32, this would be entirely different, since they have the same bit width (and the signed type would be converted to unsigned instead of the other way around) but would still have its representation preserved in terms of bits, allowing the comparison to be false in some cases, as opposed to being true all the time. --- We also get rid of two signed/unsigned comparison warnings while we're at it.	2018-07-19 15:46:17 -04:00
Lioncash	68c1ffdd1c	pl_u: Remove printf specifier in log call in a log call in GetSharedFontInOrderOfPriority() ... This can just use the fmt specifiers and be type-agnostic.	2018-07-19 15:44:04 -04:00
Sebastian Valle	7eace8f512	Merge pull request #714 from lioncash/index ... hle_ipc: Amend usage of buffer_index within one of HLERequestContext's WriteBuffer() overloads	2018-07-19 14:36:34 -05:00
bunnei	38b35e752b	Merge pull request #712 from lioncash/fsp ... fsp_srv: Misc individual changes	2018-07-19 12:31:33 -07:00
Lioncash	c945226973	gdbstub: Get rid of a few signed/unsigned comparisons ... Ensures both operands in comparisons are the same signedness.	2018-07-19 15:27:01 -04:00
Lioncash	a37a47448d	hid: Use a ranged-for loops in UpdatePadCallback ... Modernizes the loops themselves while also getting rid of a signed/unsigned comparison in a loop condition.	2018-07-19 15:11:08 -04:00
Lioncash	95103a1b7b	hid: Use HID_NUM_LAYOUTS constant for indicating size of the layouts array ... Gets rid of the use of a magic constant	2018-07-19 15:07:36 -04:00
bunnei	427fc4ac6b	Merge pull request #713 from lioncash/filesys ... filesystem: Minor changes	2018-07-19 11:49:06 -07:00
bunnei	e91ba6c057	Merge pull request #711 from lioncash/swap ... common/swap: Minor changes	2018-07-19 11:48:16 -07:00
bunnei	d6c7a05239	Merge pull request #710 from lioncash/unused ... common/common_funcs: Remove unused rotation functions	2018-07-19 11:43:41 -07:00
bunnei	1034bcc742	Merge pull request #694 from lioncash/warn ... loader/{nro, nso}: Resolve compilation warnings	2018-07-19 11:43:14 -07:00
Subv	e5c916a27c	Filesystem: Return EntryType::Directory for the root directory. ... It is unknown if this is correct behavior, but it makes sense and fixes a regression with Stardew Valley.	2018-07-19 13:11:09 -05:00
Lioncash	50d08beed2	loader: Amend Doxygen comments ... These weren't adjusted when VFS was introduced	2018-07-19 14:04:33 -04:00
bunnei	bbc31ba6af	Merge pull request #709 from lioncash/thread-local ... common/misc: Deduplicate code in GetLastErrorMsg()	2018-07-19 10:00:48 -07:00
Lioncash	9b22f856c2	loader/nso: Check if read succeeded in IdentifyFile() before checking magic value ... We should always assume the filesystem is volatile and check each IO operation. While we're at it reorganize checks so that early-out errors are near one another.	2018-07-19 12:43:21 -04:00
Lioncash	c061c2bf3c	hle/service: Make constructors explicit where applicable ... Prevents implicit construction and makes these lingering non-explicit constructors consistent with the rest of the other classes in services.	2018-07-19 12:25:02 -04:00
Lioncash	f3daecafeb	nvflinger: Emplace Display instances directly ... We can use emplace_back to construct the Display instances directly, instead of constructing them separately and copying them, avoiding the need to copy std::string and std::vector instances that are part of the Display struct.	2018-07-19 11:50:12 -04:00
bunnei	04f7a7036a	Merge pull request #705 from lioncash/string-ref ... file_util: return string by const reference for GetExeDirectory()	2018-07-19 08:47:06 -07:00
bunnei	cbf43225a9	Merge pull request #704 from lioncash/string ... string_util: Remove AsciiToHex()	2018-07-19 08:46:40 -07:00
bunnei	f1d7486eac	Merge pull request #703 from lioncash/const ... savedata_factory: Make SaveDataDescriptor's DebugInfo() function a const member function	2018-07-19 08:46:15 -07:00
bunnei	b0334af05b	Merge pull request #702 from lioncash/initialize ... partition_filesystem: Ensure all class members of PartitionFilesystem are initialized	2018-07-19 08:45:54 -07:00
bunnei	1bf7ae79c8	Merge pull request #701 from lioncash/moving ... content_archive: Minor changes	2018-07-19 08:41:42 -07:00
Lioncash	dc35c3f9d7	nvdrv: Take std::string by const reference in GetDevice() ... This is only ever used as a lookup into the device map, so we don't need to take the std::string instance by value here.	2018-07-19 11:40:36 -04:00
Lioncash	af2698dcea	hle_ipc: Amend usage of buffer_index within one of HLERequestContext's WriteBuffer() overloads ... Previously, the buffer_index parameter was unused, causing all writes to use the buffer index of zero, which is not necessarily what is wanted all the time. Thankfully, all current usages don't use a buffer index other than zero, so this just prevents a bug before it has a chance to spring.	2018-07-19 11:10:16 -04:00
Lioncash	6c1ba02e0c	fsp_srv: Remove unnecessary vector construction in IFile's Write() function ... We can avoid constructing a std::vector here by simply passing a pointer to the original data and the size of the copy we wish to perform to the backend's Write() function instead, avoiding copying the data where it's otherwise not needed.	2018-07-19 11:01:07 -04:00
Lioncash	3e9b79e088	fsp_srv: Remove unnecessary std::vector construction in IDirectory's Read() function ... We were using a second std::vector as a buffer to convert another std::vector's data into a byte sequence, however we can just use pointers to the original data and use them directly with WriteBuffer, which avoids copying the data at all into a separate std::vector. We simply cast the pointers to u8* (which is allowed by the standard, given std::uint8_t is an alias for unsigned char on platforms that we support).	2018-07-19 10:46:54 -04:00
bunnei	758c357868	Merge pull request #699 from lioncash/vfs ... vfs: Deduplicate accumulation code in VfsDirectory's GetSize()	2018-07-19 07:38:45 -07:00
bunnei	87053fb3b8	Merge pull request #697 from bunnei/disable-depth-cull ... gl_state: Temporarily disable culling and depth test.	2018-07-19 07:38:00 -07:00
Lioncash	5da4c78c6a	filesystem: std::move VirtualDir instance in VfsDirectoryServiceWrapper's constructor ... Avoids unnecessary atomic reference count incrementing and decrementing	2018-07-19 10:34:11 -04:00
Lioncash	abbf038191	filesystem: Use std::string's empty() function instead of comparing against a literal ... This is simply a basic value check as opposed to potentially doing string based operations (unlikely, but still, avoiding it is free).	2018-07-19 10:32:23 -04:00
Lioncash	2cc0ef83cf	filesystem: Remove pragma disabling global optimizations ... This was just an artifact missed during PR review.	2018-07-19 10:30:53 -04:00
Lioncash	f317080f40	fsp_srv: Make IStorage constructor explicit ... Prevents implicit conversions.	2018-07-19 10:04:16 -04:00
Lioncash	910ad2e110	fsp_srv: Add missing includes ... Gets rid of relying on indirect inclusions.	2018-07-19 10:03:17 -04:00
Lioncash	6be342118a	fsp_srv: Resolve sign-mismatch warnings in assertion comparisons	2018-07-19 09:58:32 -04:00
Lioncash	d6e9b96e2f	fsp_srv: Respect write length in Write() ... Previously we were just copying the data whole-sale, even if the length was less than the total data size. This effectively makes the actual_data vector useless, which is likely not intended. Instead, amend this to only copy the given length amount of data. At the same time, we can avoid zeroing out the data before using it by passing iterators to the constructor instead of a size.	2018-07-19 09:57:48 -04:00
Lioncash	5c47ea1a4e	common/swap: Remove unnecessary const on return value of swap()	2018-07-19 09:35:54 -04:00
Lioncash	0a868641fa	common/swap: Use static_cast where applicable	2018-07-19 09:35:13 -04:00
Lioncash	1edf4dd7ef	common/swap: Use using aliases where applicable	2018-07-19 09:32:13 -04:00
Lioncash	9128271292	common/common_funcs: Remove unused rotation functions ... These are unused and essentially don't provide much benefit either. If we ever need rotation functions, these can be introduced in a way that they don't sit in a common_* header and require a bunch of ifdefing to simply be available	2018-07-19 09:21:23 -04:00
Lioncash	e0b8a35937	common/misc: Deduplicate code in GetLastErrorMsg() ... Android and macOS have supported thread_local for quite a while, but most importantly is that we don't even really need it. Instead of using a thread-local buffer, we can just return a non-static buffer as a std::string, avoiding the need for that quality entirely.	2018-07-19 09:15:38 -04:00
Lioncash	63e64f0131	file_util: return string by const reference for GetExeDirectory() ... This disallows modifying the internal string buffer (which shouldn't be modified anyhow).	2018-07-19 01:27:29 -04:00
Lioncash	33fbcb45a7	string_util: Remove AsciiToHex() ... Easy TODO	2018-07-18 23:57:15 -04:00
bunnei	368e1d25be	Merge pull request #692 from lioncash/assign ... address_arbiter: Correct assignment within an assertion statement in WakeThreads()	2018-07-18 20:56:28 -07:00
bunnei	85421f3406	Merge pull request #690 from lioncash/move ... core/memory, core/hle/kernel: Use std::move where applicable	2018-07-18 20:55:55 -07:00
Lioncash	88ba94e8a2	savedata_factory: Make SaveDataDescriptor's DebugInfo() function a const member function ... This function doesn't alter class state.	2018-07-18 23:50:07 -04:00
Lioncash	9abc5763b6	partition_filesystem: Ensure all class members of PartitionFilesystem are initialized ... Previously is_hfs and pfs_header members wouldn't be initialized in the constructor, as they were stored in locals instead. This would result in things like GetName() and PrintDebugInfo() behaving incorrectly. While we're at it, initialize the members to deterministic values as well, in case loading ever fails.	2018-07-18 23:45:22 -04:00
bunnei	cf30c4be22	gl_state: Temporarily disable culling and depth test.	2018-07-18 23:21:43 -04:00
Lioncash	4790bb907d	content_archive: Make IsDirectoryExeFS() take a shared_ptr as a const reference ... There's no need to take this by value when it's possible to avoid unnecessary copies entirely like this.	2018-07-18 23:19:28 -04:00
Lioncash	87a9bb392b	content_archive: Add missing standard includes	2018-07-18 23:18:59 -04:00
Lioncash	0b566f43a1	content_archive: std::move VirtualFile in NCA's constructor ... Gets rid of unnecessary atomic reference count incrementing and decrementing.	2018-07-18 23:13:25 -04:00
Lioncash	5e626c774f	vfs: Deduplicate accumulation code in VfsDirectory's GetSize() ... We can just use a generic lambda to avoid writing the same thing twice.	2018-07-18 23:03:27 -04:00
bunnei	1371e2fb6a	Merge pull request #691 from lioncash/guard ... service/prepo: Add missing header guard	2018-07-18 19:46:14 -07:00
bunnei	b10905c8ae	Merge pull request #686 from lioncash/fmt ... externals: update fmt to version 5.1.0	2018-07-18 19:44:44 -07:00
Lioncash	55ab369043	loader/nro: Resolve sign mismatch warnings	2018-07-18 22:27:22 -04:00
Lioncash	1831b5ef62	loader/nso: Remove unnecessary vector resizes ... We can just initialize these vectors directly via their constructor.	2018-07-18 22:26:41 -04:00
Lioncash	e3a30ccc7c	loader/nso: Resolve sign mismatch warnings	2018-07-18 22:26:37 -04:00
bunnei	90ce935f3d	Merge pull request #688 from lioncash/comma ... vm_manager: Add missing commas to string literal array elements in GetMemoryStateName()	2018-07-18 18:59:09 -07:00
bunnei	3f93279047	Merge pull request #693 from lioncash/unused ... core/memory: Remove unused function GetSpecialHandlers() and an unused variable in ZeroBlock()	2018-07-18 18:57:13 -07:00