84 KiB
22.0 Release Notes
Moneyrocket Core version 22.0 is now available from:
https://moneyrocketcore.org/bin/moneyrocket-core-22.0/
This release includes new features, various bug fixes and performance improvements, as well as updated translations.
Please report bugs using the issue tracker at GitHub:
https://github.com/moneyrocket/moneyrocket/issues
To receive security and update notifications, please subscribe to:
https://moneyrocketcore.org/en/list/announcements/join/
How to Upgrade
If you are running an older version, shut it down. Wait until it has completely
shut down (which might take a few minutes in some cases), then run the
installer (on Windows) or just copy over /Applications/Moneyrocket-Qt
(on Mac)
or moneyrocketd
/moneyrocket-qt
(on Linux).
Upgrading directly from a version of Moneyrocket Core that has reached its EOL is possible, but it might take some time if the data directory needs to be migrated. Old wallet versions of Moneyrocket Core are generally supported.
Compatibility
Moneyrocket Core is supported and extensively tested on operating systems using the Linux kernel, macOS 10.14+, and Windows 7 and newer. Moneyrocket Core should also work on most other Unix-like systems but is not as frequently tested on them. It is not recommended to use Moneyrocket Core on unsupported systems.
From Moneyrocket Core 22.0 onwards, macOS versions earlier than 10.14 are no longer supported.
Notable changes
P2P and network changes
-
Added support for running Moneyrocket Core as an I2P (Invisible Internet Project) service and connect to such services. See i2p.md for details. (#20685)
-
This release removes support for Tor version 2 hidden services in favor of Tor v3 only, as the Tor network dropped support for Tor v2 with the release of Tor version 0.4.6. Henceforth, Moneyrocket Core ignores Tor v2 addresses; it neither rumors them over the network to other peers, nor stores them in memory or to
peers.dat
. (#22050) -
Added NAT-PMP port mapping support via
libnatpmp
. (#18077)
New and Updated RPCs
-
Due to BIP 350 being implemented, behavior for all RPCs that accept addresses is changed when a native witness version 1 (or higher) is passed. These now require a Bech32m encoding instead of a Bech32 one, and Bech32m encoding will be used for such addresses in RPC output as well. No version 1 addresses should be created for mainnet until consensus rules are adopted that give them meaning (as will happen through BIP 341). Once that happens, Bech32m is expected to be used for them, so this shouldn't affect any production systems, but may be observed on other networks where such addresses already have meaning (like signet). (#20861)
-
The
getpeerinfo
RPC returns two new boolean fields,bip152_hb_to
andbip152_hb_from
, that respectively indicate whether we selected a peer to be in compact blocks high-bandwidth mode or whether a peer selected us as a compact blocks high-bandwidth peer. High-bandwidth peers send new block announcements via acmpctblock
message rather than the usual inv/headers announcements. See BIP 152 for more details. (#19776) -
getpeerinfo
no longer returns the following fields:addnode
,banscore
, andwhitelisted
, which were previously deprecated in 0.21. Instead ofaddnode
, theconnection_type
field returns manual. Instead ofwhitelisted
, thepermissions
field indicates if the peer has special privileges. Thebanscore
field has simply been removed. (#20755) -
The following RPCs:
gettxout
,getrawtransaction
,decoderawtransaction
,decodescript
,gettransaction
, and REST endpoints:/rest/tx
,/rest/getutxos
,/rest/block
deprecated the following fields (which are no longer returned in the responses by default):addresses
,reqSigs
. The-deprecatedrpc=addresses
flag must be passed for these fields to be included in the RPC response. This flag/option will be available only for this major release, after which the deprecation will be removed entirely. Note that these fields are attributes of thescriptPubKey
object returned in the RPC response. However, in the response ofdecodescript
these fields are top-level attributes, and included again as attributes of thescriptPubKey
object. (#20286) -
When creating a hex-encoded moneyrocket transaction using the
moneyrocket-tx
utility with the-json
option set, the following fields:addresses
,reqSigs
are no longer returned in the tx output of the response. (#20286) -
The
listbanned
RPC now returns two new numeric fields:ban_duration
andtime_remaining
. Respectively, these new fields indicate the duration of a ban and the time remaining until a ban expires, both in seconds. Additionally, theban_created
field is repositioned to come beforebanned_until
. (#21602) -
The
setban
RPC can ban onion addresses again. This fixes a regression introduced in version 0.21.0. (#20852) -
The
getnodeaddresses
RPC now returns a "network" field indicating the network type (ipv4, ipv6, onion, or i2p) for each address. (#21594) -
getnodeaddresses
now also accepts a "network" argument (ipv4, ipv6, onion, or i2p) to return only addresses of the specified network. (#21843) -
The
testmempoolaccept
RPC now accepts multiple transactions (still experimental at the moment, API may be unstable). This is intended for testing transaction packages with dependency relationships; it is not recommended for batch-validating independent transactions. In addition to mempool policy, package policies apply: the list cannot contain more than 25 transactions or have a total size exceeding 101K virtual bytes, and cannot conflict with (spend the same inputs as) each other or the mempool, even if it would be a valid BIP125 replace-by-fee. There are some known limitations to the accuracy of the test accept: it's possible fortestmempoolaccept
to return "allowed"=True for a group of transactions, but "too-long-mempool-chain" if they are actually submitted. (#20833) -
addmultisigaddress
andcreatemultisig
now support up to 20 keys for Segwit addresses. (#20867)
Changes to Wallet or GUI related RPCs can be found in the GUI or Wallet section below.
Build System
- Release binaries are now produced using the new
guix
-based build system. The /doc/release-process.md document has been updated accordingly.
Files
- The list of banned hosts and networks (via
setban
RPC) is now saved on disk in JSON format inbanlist.json
instead ofbanlist.dat
.banlist.dat
is only read on startup ifbanlist.json
is not present. Changes are only written to the newbanlist.json
. A future version of Moneyrocket Core may completely ignorebanlist.dat
. (#20966)
New settings
- The
-natpmp
option has been added to use NAT-PMP to map the listening port. If both UPnP and NAT-PMP are enabled, a successful allocation from UPnP prevails over one from NAT-PMP. (#18077)
Updated settings
Changes to Wallet or GUI related settings can be found in the GUI or Wallet section below.
- Passing an invalid
-rpcauth
argument now cause moneyrocketd to fail to start. (#20461)
Tools and Utilities
-
A new CLI
-addrinfo
command returns the number of addresses known to the node per network type (including Tor v2 versus v3) and total. This can be useful to see if the node knows enough addresses in a network to use options like-onlynet=<network>
or to upgrade to this release of Moneyrocket Core 22.0 that supports Tor v3 only. (#21595) -
A new
-rpcwaittimeout
argument tomoneyrocket-cli
sets the timeout in seconds to use with-rpcwait
. If the timeout expires,moneyrocket-cli
will report a failure. (#21056)
Wallet
-
External signers such as hardware wallets can now be used through the new RPC methods
enumeratesigners
anddisplayaddress
. Support is also added to thesend
RPC call. This feature is experimental. See external-signer.md for details. (#16546) -
A new
listdescriptors
RPC is available to inspect the contents of descriptor-enabled wallets. The RPC returns public versions of all imported descriptors, including their timestamp and flags. For ranged descriptors, it also returns the range boundaries and the next index to generate addresses from. (#20226) -
The
bumpfee
RPC is not available with wallets that have private keys disabled.psbtbumpfee
can be used instead. (#20891) -
The
fundrawtransaction
,send
andwalletcreatefundedpsbt
RPCs now support aninclude_unsafe
option that whentrue
allows using unsafe inputs to fund the transaction. Note that the resulting transaction may become invalid if one of the unsafe inputs disappears. If that happens, the transaction must be funded with different inputs and republished. (#21359) -
We now support up to 20 keys in
multi()
andsortedmulti()
descriptors underwsh()
. (#20867) -
Taproot descriptors can be imported into the wallet only after activation has occurred on the network (e.g. mainnet, testnet, signet) in use. See descriptors.md for supported descriptors.
GUI changes
- External signers such as hardware wallets can now be used. These require an external tool such as HWI to be installed and configured under Options -> Wallet. When creating a new wallet a new option "External signer" will appear in the dialog. If the device is detected, its name is suggested as the wallet name. The watch-only keys are then automatically imported. Receive addresses can be verified on the device. The send dialog will automatically use the connected device. This feature is experimental and the UI may freeze for a few seconds when performing these actions.
Low-level changes
RPC
-
The RPC server can process a limited number of simultaneous RPC requests. Previously, if this limit was exceeded, the RPC server would respond with status code 500 (
HTTP_INTERNAL_SERVER_ERROR
). Now it returns status code 503 (HTTP_SERVICE_UNAVAILABLE
). (#18335) -
Error codes have been updated to be more accurate for the following error cases (#18466):
signmessage
now returns RPC_INVALID_ADDRESS_OR_KEY (-5) if the passed address is invalid. Previously returned RPC_TYPE_ERROR (-3).verifymessage
now returns RPC_INVALID_ADDRESS_OR_KEY (-5) if the passed address is invalid. Previously returned RPC_TYPE_ERROR (-3).verifymessage
now returns RPC_TYPE_ERROR (-3) if the passed signature is malformed. Previously returned RPC_INVALID_ADDRESS_OR_KEY (-5).
Tests
22.0 change log
A detailed list of changes in this version follows. To keep the list to a manageable length, small refactors and typo fixes are not included, and similar changes are sometimes condensed into one line.
Consensus
- moneyrocket/moneyrocket#19438 Introduce deploymentstatus (ajtowns)
- moneyrocket/moneyrocket#20207 Follow-up extra comments on taproot code and tests (sipa)
- moneyrocket/moneyrocket#21330 Deal with missing data in signature hashes more consistently (sipa)
Policy
- moneyrocket/moneyrocket#18766 Disable fee estimation in blocksonly mode (by removing the fee estimates global) (darosior)
- moneyrocket/moneyrocket#20497 Add
MAX_STANDARD_SCRIPTSIG_SIZE
to policy (sanket1729) - moneyrocket/moneyrocket#20611 Move
TX_MAX_STANDARD_VERSION
to policy (MarcoFalke)
Mining
- moneyrocket/moneyrocket#19937, moneyrocket/moneyrocket#20923 Signet mining utility (ajtowns)
Block and transaction handling
- moneyrocket/moneyrocket#14501 Fix possible data race when committing block files (luke-jr)
- moneyrocket/moneyrocket#15946 Allow maintaining the blockfilterindex when using prune (jonasschnelli)
- moneyrocket/moneyrocket#18710 Add local thread pool to CCheckQueue (hebasto)
- moneyrocket/moneyrocket#19521 Coinstats Index (fjahr)
- moneyrocket/moneyrocket#19806 UTXO snapshot activation (jamesob)
- moneyrocket/moneyrocket#19905 Remove dead CheckForkWarningConditionsOnNewFork (MarcoFalke)
- moneyrocket/moneyrocket#19935 Move SaltedHashers to separate file and add some new ones (achow101)
- moneyrocket/moneyrocket#20054 Remove confusing and useless "unexpected version" warning (MarcoFalke)
- moneyrocket/moneyrocket#20519 Handle rename failure in
DumpMempool(…)
by using theRenameOver(…)
return value (practicalswift) - moneyrocket/moneyrocket#20749, moneyrocket/moneyrocket#20750, moneyrocket/moneyrocket#21055, moneyrocket/moneyrocket#21270, moneyrocket/moneyrocket#21525, moneyrocket/moneyrocket#21391, moneyrocket/moneyrocket#21767, moneyrocket/moneyrocket#21866 Prune
g_chainman
usage (dongcarl) - moneyrocket/moneyrocket#20833 rpc/validation: enable packages through testmempoolaccept (glozow)
- moneyrocket/moneyrocket#20834 Locks and docs in ATMP and CheckInputsFromMempoolAndCache (glozow)
- moneyrocket/moneyrocket#20854 Remove unnecessary try-block (amitiuttarwar)
- moneyrocket/moneyrocket#20868 Remove redundant check on pindex (jarolrod)
- moneyrocket/moneyrocket#20921 Don't try to invalidate genesis block in CChainState::InvalidateBlock (theStack)
- moneyrocket/moneyrocket#20972 Locks: Annotate CTxMemPool::check to require
cs_main
(dongcarl) - moneyrocket/moneyrocket#21009 Remove RewindBlockIndex logic (dhruv)
- moneyrocket/moneyrocket#21025 Guard chainman chainstates with
cs_main
(dongcarl) - moneyrocket/moneyrocket#21202 Two small clang lock annotation improvements (amitiuttarwar)
- moneyrocket/moneyrocket#21523 Run VerifyDB on all chainstates (jamesob)
- moneyrocket/moneyrocket#21573 Update libsecp256k1 subtree to latest master (sipa)
- moneyrocket/moneyrocket#21582, moneyrocket/moneyrocket#21584, moneyrocket/moneyrocket#21585 Fix assumeutxo crashes (MarcoFalke)
- moneyrocket/moneyrocket#21681 Fix ActivateSnapshot to use hardcoded nChainTx (jamesob)
- moneyrocket/moneyrocket#21796 index: Avoid async shutdown on init error (MarcoFalke)
- moneyrocket/moneyrocket#21946 Document and test lack of inherited signaling in RBF policy (ariard)
- moneyrocket/moneyrocket#22084 Package testmempoolaccept followups (glozow)
- moneyrocket/moneyrocket#22102 Remove
Warning:
from warning message printed for unknown new rules (prayank23) - moneyrocket/moneyrocket#22112 Force port 0 in I2P (vasild)
- moneyrocket/moneyrocket#22135 CRegTestParams: Use
args
instead ofgArgs
(kiminuo) - moneyrocket/moneyrocket#22146 Reject invalid coin height and output index when loading assumeutxo (MarcoFalke)
- moneyrocket/moneyrocket#22253 Distinguish between same tx and same-nonwitness-data tx in mempool (glozow)
- moneyrocket/moneyrocket#22261 Two small fixes to node broadcast logic (jnewbery)
- moneyrocket/moneyrocket#22415 Make
m_mempool
optional in CChainState (jamesob) - moneyrocket/moneyrocket#22499 Update assumed chain params (sriramdvt)
- moneyrocket/moneyrocket#22589 net, doc: update I2P hardcoded seeds and docs for 22.0 (jonatack)
P2P protocol and network code
- moneyrocket/moneyrocket#18077 Add NAT-PMP port forwarding support (hebasto)
- moneyrocket/moneyrocket#18722 addrman: improve performance by using more suitable containers (vasild)
- moneyrocket/moneyrocket#18819 Replace
cs_feeFilter
with simple std::atomic (MarcoFalke) - moneyrocket/moneyrocket#19203 Add regression fuzz harness for CVE-2017-18350. Add FuzzedSocket (practicalswift)
- moneyrocket/moneyrocket#19288 fuzz: Add fuzzing harness for TorController (practicalswift)
- moneyrocket/moneyrocket#19415 Make DNS lookup mockable, add fuzzing harness (practicalswift)
- moneyrocket/moneyrocket#19509 Per-Peer Message Capture (troygiorshev)
- moneyrocket/moneyrocket#19763 Don't try to relay to the address' originator (vasild)
- moneyrocket/moneyrocket#19771 Replace enum CConnMan::NumConnections with enum class ConnectionDirection (luke-jr)
- moneyrocket/moneyrocket#19776 net, rpc: expose high bandwidth mode state via getpeerinfo (theStack)
- moneyrocket/moneyrocket#19832 Put disconnecting logs into BCLog::NET category (hebasto)
- moneyrocket/moneyrocket#19858 Periodically make block-relay connections and sync headers (sdaftuar)
- moneyrocket/moneyrocket#19884 No delay in adding fixed seeds if -dnsseed=0 and peers.dat is empty (dhruv)
- moneyrocket/moneyrocket#20079 Treat handshake misbehavior like unknown message (MarcoFalke)
- moneyrocket/moneyrocket#20138 Assume that SetCommonVersion is called at most once per peer (MarcoFalke)
- moneyrocket/moneyrocket#20162 p2p: declare Announcement::m_state as uint8_t, add getter/setter (jonatack)
- moneyrocket/moneyrocket#20197 Protect onions in AttemptToEvictConnection(), add eviction protection test coverage (jonatack)
- moneyrocket/moneyrocket#20210 assert
CNode::m_inbound_onion
is inbound in ctor, add getter, unit tests (jonatack) - moneyrocket/moneyrocket#20228 addrman: Make addrman a top-level component (jnewbery)
- moneyrocket/moneyrocket#20234 Don't bind on 0.0.0.0 if binds are restricted to Tor (vasild)
- moneyrocket/moneyrocket#20477 Add unit testing of node eviction logic (practicalswift)
- moneyrocket/moneyrocket#20516 Well-defined CAddress disk serialization, and addrv2 anchors.dat (sipa)
- moneyrocket/moneyrocket#20557 addrman: Fix new table bucketing during unserialization (jnewbery)
- moneyrocket/moneyrocket#20561 Periodically clear
m_addr_known
(sdaftuar) - moneyrocket/moneyrocket#20599 net processing: Tolerate sendheaders and sendcmpct messages before verack (jnewbery)
- moneyrocket/moneyrocket#20616 Check CJDNS address is valid (lontivero)
- moneyrocket/moneyrocket#20617 Remove
m_is_manual_connection
from CNodeState (ariard) - moneyrocket/moneyrocket#20624 net processing: Remove nStartingHeight check from block relay (jnewbery)
- moneyrocket/moneyrocket#20651 Make p2p recv buffer timeout 20 minutes for all peers (jnewbery)
- moneyrocket/moneyrocket#20661 Only select from addrv2-capable peers for torv3 address relay (sipa)
- moneyrocket/moneyrocket#20685 Add I2P support using I2P SAM (vasild)
- moneyrocket/moneyrocket#20690 Clean up logging of outbound connection type (sdaftuar)
- moneyrocket/moneyrocket#20721 Move ping data to
net_processing
(jnewbery) - moneyrocket/moneyrocket#20724 Cleanup of -debug=net log messages (ajtowns)
- moneyrocket/moneyrocket#20747 net processing: Remove dropmessagestest (jnewbery)
- moneyrocket/moneyrocket#20764 cli -netinfo peer connections dashboard updates 🎄 ✨ (jonatack)
- moneyrocket/moneyrocket#20788 add RAII socket and use it instead of bare SOCKET (vasild)
- moneyrocket/moneyrocket#20791 remove unused legacyWhitelisted in AcceptConnection() (jonatack)
- moneyrocket/moneyrocket#20816 Move RecordBytesSent() call out of
cs_vSend
lock (jnewbery) - moneyrocket/moneyrocket#20845 Log to net debug in MaybeDiscourageAndDisconnect except for noban and manual peers (MarcoFalke)
- moneyrocket/moneyrocket#20864 Move SocketSendData lock annotation to header (MarcoFalke)
- moneyrocket/moneyrocket#20965 net, rpc: return
NET_UNROUTABLE
asnot_publicly_routable
, automate helps (jonatack) - moneyrocket/moneyrocket#20966 banman: save the banlist in a JSON format on disk (vasild)
- moneyrocket/moneyrocket#21015 Make all of
net_processing
(and some of net) use std::chrono types (dhruv) - moneyrocket/moneyrocket#21029 moneyrocket-cli: Correct docs (no "generatenewaddress" exists) (luke-jr)
- moneyrocket/moneyrocket#21148 Split orphan handling from
net_processing
into txorphanage (ajtowns) - moneyrocket/moneyrocket#21162 Net Processing: Move RelayTransaction() into PeerManager (jnewbery)
- moneyrocket/moneyrocket#21167 make
CNode::m_inbound_onion
public, initialize explicitly (jonatack) - moneyrocket/moneyrocket#21186 net/net processing: Move addr data into
net_processing
(jnewbery) - moneyrocket/moneyrocket#21187 Net processing: Only call PushAddress() from
net_processing
(jnewbery) - moneyrocket/moneyrocket#21198 Address outstanding review comments from PR20721 (jnewbery)
- moneyrocket/moneyrocket#21222 log: Clarify log message when file does not exist (MarcoFalke)
- moneyrocket/moneyrocket#21235 Clarify disconnect log message in ProcessGetBlockData, remove send bool (MarcoFalke)
- moneyrocket/moneyrocket#21236 Net processing: Extract
addr
send functionality into MaybeSendAddr() (jnewbery) - moneyrocket/moneyrocket#21261 update inbound eviction protection for multiple networks, add I2P peers (jonatack)
- moneyrocket/moneyrocket#21328 net, refactor: pass uint16 CService::port as uint16 (jonatack)
- moneyrocket/moneyrocket#21387 Refactor sock to add I2P fuzz and unit tests (vasild)
- moneyrocket/moneyrocket#21395 Net processing: Remove unused CNodeState.address member (jnewbery)
- moneyrocket/moneyrocket#21407 i2p: limit the size of incoming messages (vasild)
- moneyrocket/moneyrocket#21506 p2p, refactor: make NetPermissionFlags an enum class (jonatack)
- moneyrocket/moneyrocket#21509 Don't send FEEFILTER in blocksonly mode (mzumsande)
- moneyrocket/moneyrocket#21560 Add Tor v3 hardcoded seeds (laanwj)
- moneyrocket/moneyrocket#21563 Restrict period when
cs_vNodes
mutex is locked (hebasto) - moneyrocket/moneyrocket#21564 Avoid calling getnameinfo when formatting IPv4 addresses in CNetAddr::ToStringIP (practicalswift)
- moneyrocket/moneyrocket#21631 i2p: always check the return value of Sock::Wait() (vasild)
- moneyrocket/moneyrocket#21644 p2p, bugfix: use NetPermissions::HasFlag() in CConnman::Bind() (jonatack)
- moneyrocket/moneyrocket#21659 flag relevant Sock methods with nodiscard (vasild)
- moneyrocket/moneyrocket#21750 remove unnecessary check of
CNode::cs_vSend
(vasild) - moneyrocket/moneyrocket#21756 Avoid calling
getnameinfo
when formatting IPv6 addresses inCNetAddr::ToStringIP
(practicalswift) - moneyrocket/moneyrocket#21775 Limit
m_block_inv_mutex
(MarcoFalke) - moneyrocket/moneyrocket#21825 Add I2P hardcoded seeds (jonatack)
- moneyrocket/moneyrocket#21843 p2p, rpc: enable GetAddr, GetAddresses, and getnodeaddresses by network (jonatack)
- moneyrocket/moneyrocket#21845 net processing: Don't require locking
cs_main
before calling RelayTransactions() (jnewbery) - moneyrocket/moneyrocket#21872 Sanitize message type for logging (laanwj)
- moneyrocket/moneyrocket#21914 Use stronger AddLocal() for our I2P address (vasild)
- moneyrocket/moneyrocket#21985 Return IPv6 scope id in
CNetAddr::ToStringIP()
(laanwj) - moneyrocket/moneyrocket#21992 Remove -feefilter option (amadeuszpawlik)
- moneyrocket/moneyrocket#21996 Pass strings to NetPermissions::TryParse functions by const ref (jonatack)
- moneyrocket/moneyrocket#22013 ignore block-relay-only peers when skipping DNS seed (ajtowns)
- moneyrocket/moneyrocket#22050 Remove tor v2 support (jonatack)
- moneyrocket/moneyrocket#22096 AddrFetch - don't disconnect on self-announcements (mzumsande)
- moneyrocket/moneyrocket#22141 net processing: Remove hash and fValidatedHeaders from QueuedBlock (jnewbery)
- moneyrocket/moneyrocket#22144 Randomize message processing peer order (sipa)
- moneyrocket/moneyrocket#22147 Protect last outbound HB compact block peer (sdaftuar)
- moneyrocket/moneyrocket#22179 Torv2 removal followups (vasild)
- moneyrocket/moneyrocket#22211 Relay I2P addresses even if not reachable (by us) (vasild)
- moneyrocket/moneyrocket#22284 Performance improvements to ProtectEvictionCandidatesByRatio() (jonatack)
- moneyrocket/moneyrocket#22387 Rate limit the processing of rumoured addresses (sipa)
- moneyrocket/moneyrocket#22455 addrman: detect on-disk corrupted nNew and nTried during unserialization (vasild)
Wallet
- moneyrocket/moneyrocket#15710 Catch
ios_base::failure
specifically (Bushstar) - moneyrocket/moneyrocket#16546 External signer support - Wallet Box edition (Sjors)
- moneyrocket/moneyrocket#17331 Use effective values throughout coin selection (achow101)
- moneyrocket/moneyrocket#18418 Increase
OUTPUT_GROUP_MAX_ENTRIES
to 100 (fjahr) - moneyrocket/moneyrocket#18842 Mark replaced tx to not be in the mempool anymore (MarcoFalke)
- moneyrocket/moneyrocket#19136 Add
parent_desc
togetaddressinfo
(achow101) - moneyrocket/moneyrocket#19137 wallettool: Add dump and createfromdump commands (achow101)
- moneyrocket/moneyrocket#19651
importdescriptor
s update existing (S3RK) - moneyrocket/moneyrocket#20040 Refactor OutputGroups to handle fees and spending eligibility on grouping (achow101)
- moneyrocket/moneyrocket#20202 Make BDB support optional (achow101)
- moneyrocket/moneyrocket#20226, moneyrocket/moneyrocket#21277, - moneyrocket/moneyrocket#21063 Add
listdescriptors
command (S3RK) - moneyrocket/moneyrocket#20267 Disable and fix tests for when BDB is not compiled (achow101)
- moneyrocket/moneyrocket#20275 List all wallets in non-SQLite and non-BDB builds (ryanofsky)
- moneyrocket/moneyrocket#20365 wallettool: Add parameter to create descriptors wallet (S3RK)
- moneyrocket/moneyrocket#20403
upgradewallet
fixes, improvements, test coverage (jonatack) - moneyrocket/moneyrocket#20448
unloadwallet
: Allow specifyingwallet_name
param matching RPC endpoint wallet (luke-jr) - moneyrocket/moneyrocket#20536 Error with "Transaction too large" if the funded tx will end up being too large after signing (achow101)
- moneyrocket/moneyrocket#20687 Add missing check for -descriptors wallet tool option (MarcoFalke)
- moneyrocket/moneyrocket#20952 Add BerkeleyDB version sanity check at init time (laanwj)
- moneyrocket/moneyrocket#21127 Load flags before everything else (Sjors)
- moneyrocket/moneyrocket#21141 Add new format string placeholders for walletnotify (maayank)
- moneyrocket/moneyrocket#21238 A few descriptor improvements to prepare for Taproot support (sipa)
- moneyrocket/moneyrocket#21302
createwallet
examples for descriptor wallets (S3RK) - moneyrocket/moneyrocket#21329 descriptor wallet: Cache last hardened xpub and use in normalized descriptors (achow101)
- moneyrocket/moneyrocket#21365 Basic Taproot signing support for descriptor wallets (sipa)
- moneyrocket/moneyrocket#21417 Misc external signer improvement and HWI 2 support (Sjors)
- moneyrocket/moneyrocket#21467 Move external signer out of wallet module (Sjors)
- moneyrocket/moneyrocket#21572 Fix wrong wallet RPC context set after #21366 (ryanofsky)
- moneyrocket/moneyrocket#21574 Drop JSONRPCRequest constructors after #21366 (ryanofsky)
- moneyrocket/moneyrocket#21666 Miscellaneous external signer changes (fanquake)
- moneyrocket/moneyrocket#21759 Document coin selection code (glozow)
- moneyrocket/moneyrocket#21786 Ensure sat/vB feerates are in range (mantissa of 3) (jonatack)
- moneyrocket/moneyrocket#21944 Fix issues when
walletdir
is root directory (prayank23) - moneyrocket/moneyrocket#22042 Replace size/weight estimate tuple with struct for named fields (instagibbs)
- moneyrocket/moneyrocket#22051 Basic Taproot derivation support for descriptors (sipa)
- moneyrocket/moneyrocket#22154 Add OutputType::BECH32M and related wallet support for fetching bech32m addresses (achow101)
- moneyrocket/moneyrocket#22156 Allow tr() import only when Taproot is active (achow101)
- moneyrocket/moneyrocket#22166 Add support for inferring tr() descriptors (sipa)
- moneyrocket/moneyrocket#22173 Do not load external signers wallets when unsupported (achow101)
- moneyrocket/moneyrocket#22308 Add missing BlockUntilSyncedToCurrentChain (MarcoFalke)
- moneyrocket/moneyrocket#22334 Do not spam about non-existent spk managers (S3RK)
- moneyrocket/moneyrocket#22379 Erase spkmans rather than setting to nullptr (achow101)
- moneyrocket/moneyrocket#22421 Make IsSegWitOutput return true for taproot outputs (sipa)
- moneyrocket/moneyrocket#22461 Change ScriptPubKeyMan::Upgrade default to True (achow101)
- moneyrocket/moneyrocket#22492 Reorder locks in dumpwallet to avoid lock order assertion (achow101)
- moneyrocket/moneyrocket#22686 Use GetSelectionAmount in ApproximateBestSubset (achow101)
RPC and other APIs
- moneyrocket/moneyrocket#18335, moneyrocket/moneyrocket#21484 cli: Print useful error if moneyrocketd rpc work queue exceeded (LarryRuane)
- moneyrocket/moneyrocket#18466 Fix invalid parameter error codes for
{sign,verify}message
RPCs (theStack) - moneyrocket/moneyrocket#18772 Calculate fees in
getblock
using BlockUndo data (robot-visions) - moneyrocket/moneyrocket#19033 http: Release work queue after event base finish (promag)
- moneyrocket/moneyrocket#19055 Add MuHash3072 implementation (fjahr)
- moneyrocket/moneyrocket#19145 Add
hash_type
MUHASH for gettxoutsetinfo (fjahr) - moneyrocket/moneyrocket#19847 Avoid duplicate set lookup in
gettxoutproof
(promag) - moneyrocket/moneyrocket#20286 Deprecate
addresses
andreqSigs
from RPC outputs (mjdietzx) - moneyrocket/moneyrocket#20459 Fail to return undocumented return values (MarcoFalke)
- moneyrocket/moneyrocket#20461 Validate
-rpcauth
arguments (promag) - moneyrocket/moneyrocket#20556 Properly document return values (
submitblock
,gettxout
,getblocktemplate
,scantxoutset
) (MarcoFalke) - moneyrocket/moneyrocket#20755 Remove deprecated fields from
getpeerinfo
(amitiuttarwar) - moneyrocket/moneyrocket#20832 Better error messages for invalid addresses (eilx2)
- moneyrocket/moneyrocket#20867 Support up to 20 keys for multisig under Segwit context (darosior)
- moneyrocket/moneyrocket#20877 cli:
-netinfo
user help and argument parsing improvements (jonatack) - moneyrocket/moneyrocket#20891 Remove deprecated bumpfee behavior (achow101)
- moneyrocket/moneyrocket#20916 Return wtxid from
testmempoolaccept
(MarcoFalke) - moneyrocket/moneyrocket#20917 Add missing signet mentions in network name lists (theStack)
- moneyrocket/moneyrocket#20941 Document
RPC_TRANSACTION_ALREADY_IN_CHAIN
exception (jarolrod) - moneyrocket/moneyrocket#20944 Return total fee in
getmempoolinfo
(MarcoFalke) - moneyrocket/moneyrocket#20964 Add specific error code for "wallet already loaded" (laanwj)
- moneyrocket/moneyrocket#21053 Document {previous,next}blockhash as optional (theStack)
- moneyrocket/moneyrocket#21056 Add a
-rpcwaittimeout
parameter to limit time spent waiting (cdecker) - moneyrocket/moneyrocket#21192 cli: Treat high detail levels as maximum in
-netinfo
(laanwj) - moneyrocket/moneyrocket#21311 Document optional fields for
getchaintxstats
result (theStack) - moneyrocket/moneyrocket#21359
include_unsafe
option for fundrawtransaction (t-bast) - moneyrocket/moneyrocket#21426 Remove
scantxoutset
EXPERIMENTAL warning (jonatack) - moneyrocket/moneyrocket#21544 Missing doc updates for bumpfee psbt update (MarcoFalke)
- moneyrocket/moneyrocket#21594 Add
network
field togetnodeaddresses
(jonatack) - moneyrocket/moneyrocket#21595, moneyrocket/moneyrocket#21753 cli: Create
-addrinfo
(jonatack) - moneyrocket/moneyrocket#21602 Add additional ban time fields to
listbanned
(jarolrod) - moneyrocket/moneyrocket#21679 Keep default argument value in correct type (promag)
- moneyrocket/moneyrocket#21718 Improve error message for
getblock
invalid datatype (klementtan) - moneyrocket/moneyrocket#21913 RPCHelpMan fixes (kallewoof)
- moneyrocket/moneyrocket#22021
bumpfee
/psbtbumpfee
fixes and updates (jonatack) - moneyrocket/moneyrocket#22043
addpeeraddress
test coverage, code simplify/constness (jonatack) - moneyrocket/moneyrocket#22327 cli: Avoid truncating
-rpcwaittimeout
(MarcoFalke)
GUI
- moneyrocket/moneyrocket#18948 Call setParent() in the parent's context (hebasto)
- moneyrocket/moneyrocket#20482 Add depends qt fix for ARM macs (jonasschnelli)
- moneyrocket/moneyrocket#21836 scripted-diff: Replace three dots with ellipsis in the ui strings (hebasto)
- moneyrocket/moneyrocket#21935 Enable external signer support for GUI builds (Sjors)
- moneyrocket/moneyrocket#22133 Make QWindowsVistaStylePlugin available again (regression) (hebasto)
- moneyrocket-core/gui#4 UI external signer support (e.g. hardware wallet) (Sjors)
- moneyrocket-core/gui#13 Hide peer detail view if multiple are selected (promag)
- moneyrocket-core/gui#18 Add peertablesortproxy module (hebasto)
- moneyrocket-core/gui#21 Improve pruning tooltip (fluffypony, MoneyrocketErrorLog)
- moneyrocket-core/gui#72 Log static plugins meta data and used style (hebasto)
- moneyrocket-core/gui#79 Embed monospaced font (hebasto)
- moneyrocket-core/gui#85 Remove unused "What's This" button in dialogs on Windows OS (hebasto)
- moneyrocket-core/gui#115 Replace "Hide tray icon" option with positive "Show tray icon" one (hebasto)
- moneyrocket-core/gui#118 Remove BDB version from the Information tab (hebasto)
- moneyrocket-core/gui#121 Early subscribe core signals in transaction table model (promag)
- moneyrocket-core/gui#123 Do not accept command while executing another one (hebasto)
- moneyrocket-core/gui#125 Enable changing the autoprune block space size in intro dialog (luke-jr)
- moneyrocket-core/gui#138 Unlock encrypted wallet "OK" button bugfix (mjdietzx)
- moneyrocket-core/gui#139 doc: Improve gui/src/qt README.md (jarolrod)
- moneyrocket-core/gui#154 Support macOS Dark mode (goums, Uplab)
- moneyrocket-core/gui#162 Add network to peers window and peer details (jonatack)
- moneyrocket-core/gui#163, moneyrocket-core/gui#180 Peer details: replace Direction with Connection Type (jonatack)
- moneyrocket-core/gui#164 Handle peer addition/removal in a right way (hebasto)
- moneyrocket-core/gui#165 Save QSplitter state in QSettings (hebasto)
- moneyrocket-core/gui#173 Follow Qt docs when implementing rowCount and columnCount (hebasto)
- moneyrocket-core/gui#179 Add Type column to peers window, update peer details name/tooltip (jonatack)
- moneyrocket-core/gui#186 Add information to "Confirm fee bump" window (prayank23)
- moneyrocket-core/gui#189 Drop workaround for QTBUG-42503 which was fixed in Qt 5.5.0 (prusnak)
- moneyrocket-core/gui#194 Save/restore RPCConsole geometry only for window (hebasto)
- moneyrocket-core/gui#202 Fix right panel toggle in peers tab (RandyMcMillan)
- moneyrocket-core/gui#203 Display plain "Inbound" in peer details (jonatack)
- moneyrocket-core/gui#204 Drop buggy TableViewLastColumnResizingFixer class (hebasto)
- moneyrocket-core/gui#205, moneyrocket-core/gui#229 Save/restore TransactionView and recentRequestsView tables column sizes (hebasto)
- moneyrocket-core/gui#206 Display fRelayTxes and
bip152_highbandwidth_{to, from}
in peer details (jonatack) - moneyrocket-core/gui#213 Add Copy Address Action to Payment Requests (jarolrod)
- moneyrocket-core/gui#214 Disable requests context menu actions when appropriate (jarolrod)
- moneyrocket-core/gui#217 Make warning label look clickable (jarolrod)
- moneyrocket-core/gui#219 Prevent the main window popup menu (hebasto)
- moneyrocket-core/gui#220 Do not translate file extensions (hebasto)
- moneyrocket-core/gui#221 RPCConsole translatable string fixes and improvements (jonatack)
- moneyrocket-core/gui#226 Add "Last Block" and "Last Tx" rows to peer details area (jonatack)
- moneyrocket-core/gui#233 qt test: Don't bind to regtest port (achow101)
- moneyrocket-core/gui#243 Fix issue when disabling the auto-enabled blank wallet checkbox (jarolrod)
- moneyrocket-core/gui#246 Revert "qt: Use "fusion" style on macOS Big Sur with old Qt" (hebasto)
- moneyrocket-core/gui#248 For values of "Bytes transferred" and "Bytes/s" with 1000-based prefix names use 1000-based divisor instead of 1024-based (wodry)
- moneyrocket-core/gui#251 Improve URI/file handling message (hebasto)
- moneyrocket-core/gui#256 Save/restore column sizes of the tables in the Peers tab (hebasto)
- moneyrocket-core/gui#260 Handle exceptions isntead of crash (hebasto)
- moneyrocket-core/gui#263 Revamp context menus (hebasto)
- moneyrocket-core/gui#271 Don't clear console prompt when font resizing (jarolrod)
- moneyrocket-core/gui#275 Support runtime appearance adjustment on macOS (hebasto)
- moneyrocket-core/gui#276 Elide long strings in their middle in the Peers tab (hebasto)
- moneyrocket-core/gui#281 Set shortcuts for console's resize buttons (jarolrod)
- moneyrocket-core/gui#293 Enable wordWrap for Services (RandyMcMillan)
- moneyrocket-core/gui#296 Do not use QObject::tr plural syntax for numbers with a unit symbol (hebasto)
- moneyrocket-core/gui#297 Avoid unnecessary translations (hebasto)
- moneyrocket-core/gui#298 Peertableview alternating row colors (RandyMcMillan)
- moneyrocket-core/gui#300 Remove progress bar on modal overlay (brunoerg)
- moneyrocket-core/gui#309 Add access to the Peers tab from the network icon (hebasto)
- moneyrocket-core/gui#311 Peers Window rename 'Peer id' to 'Peer' (jarolrod)
- moneyrocket-core/gui#313 Optimize string concatenation by default (hebasto)
- moneyrocket-core/gui#325 Align numbers in the "Peer Id" column to the right (hebasto)
- moneyrocket-core/gui#329 Make console buttons look clickable (jarolrod)
- moneyrocket-core/gui#330 Allow prompt icon to be colorized (jarolrod)
- moneyrocket-core/gui#331 Make RPC console welcome message translation-friendly (hebasto)
- moneyrocket-core/gui#332 Replace disambiguation strings with translator comments (hebasto)
- moneyrocket-core/gui#335 test: Use QSignalSpy instead of QEventLoop (jarolrod)
- moneyrocket-core/gui#343 Improve the GUI responsiveness when progress dialogs are used (hebasto)
- moneyrocket-core/gui#361 Fix GUI segfault caused by moneyrocket/moneyrocket#22216 (ryanofsky)
- moneyrocket-core/gui#362 Add keyboard shortcuts to context menus (luke-jr)
- moneyrocket-core/gui#366 Dark Mode fixes/portability (luke-jr)
- moneyrocket-core/gui#375 Emit dataChanged signal to dynamically re-sort Peers table (hebasto)
- moneyrocket-core/gui#393 Fix regression in "Encrypt Wallet" menu item (hebasto)
- moneyrocket-core/gui#396 Ensure external signer option remains disabled without signers (achow101)
- moneyrocket-core/gui#406 Handle new added plurals in
moneyrocket_en.ts
(hebasto)
Build system
- moneyrocket/moneyrocket#17227 Add Android packaging support (icota)
- moneyrocket/moneyrocket#17920 guix: Build support for macOS (dongcarl)
- moneyrocket/moneyrocket#18298 Fix Qt processing of configure script for depends with DEBUG=1 (hebasto)
- moneyrocket/moneyrocket#19160 multiprocess: Add basic spawn and IPC support (ryanofsky)
- moneyrocket/moneyrocket#19504 Bump minimum python version to 3.6 (ajtowns)
- moneyrocket/moneyrocket#19522 fix building libconsensus with reduced exports for Darwin targets (fanquake)
- moneyrocket/moneyrocket#19683 Pin clang search paths for darwin host (dongcarl)
- moneyrocket/moneyrocket#19764 Split boost into build/host packages + bump + cleanup (dongcarl)
- moneyrocket/moneyrocket#19817 libtapi 1100.0.11 (fanquake)
- moneyrocket/moneyrocket#19846 enable unused member function diagnostic (Zero-1729)
- moneyrocket/moneyrocket#19867 Document and cleanup Qt hacks (fanquake)
- moneyrocket/moneyrocket#20046 Set
CMAKE_INSTALL_RPATH
for native packages (ryanofsky) - moneyrocket/moneyrocket#20223 Drop the leading 0 from the version number (achow101)
- moneyrocket/moneyrocket#20333 Remove
native_biplist
dependency (fanquake) - moneyrocket/moneyrocket#20353 configure: Support -fdebug-prefix-map and -fmacro-prefix-map (ajtowns)
- moneyrocket/moneyrocket#20359 Various config.site.in improvements and linting (dongcarl)
- moneyrocket/moneyrocket#20413 Require C++17 compiler (MarcoFalke)
- moneyrocket/moneyrocket#20419 Set minimum supported macOS to 10.14 (fanquake)
- moneyrocket/moneyrocket#20421 miniupnpc 2.2.2 (fanquake)
- moneyrocket/moneyrocket#20422 Mac deployment unification (fanquake)
- moneyrocket/moneyrocket#20424 Update univalue subtree (MarcoFalke)
- moneyrocket/moneyrocket#20449 Fix Windows installer build (achow101)
- moneyrocket/moneyrocket#20468 Warn when generating man pages for binaries built from a dirty branch (tylerchambers)
- moneyrocket/moneyrocket#20469 Avoid secp256k1.h include from system (dergoegge)
- moneyrocket/moneyrocket#20470 Replace genisoimage with xorriso (dongcarl)
- moneyrocket/moneyrocket#20471 Use C++17 in depends (fanquake)
- moneyrocket/moneyrocket#20496 Drop unneeded macOS framework dependencies (hebasto)
- moneyrocket/moneyrocket#20520 Do not force Precompiled Headers (PCH) for building Qt on Linux (hebasto)
- moneyrocket/moneyrocket#20549 Support make src/moneyrocket-node and src/moneyrocket-gui (promag)
- moneyrocket/moneyrocket#20565 Ensure PIC build for bdb on Android (BlockMechanic)
- moneyrocket/moneyrocket#20594 Fix getauxval calls in randomenv.cpp (jonasschnelli)
- moneyrocket/moneyrocket#20603 Update crc32c subtree (MarcoFalke)
- moneyrocket/moneyrocket#20609 configure: output notice that test binary is disabled by fuzzing (apoelstra)
- moneyrocket/moneyrocket#20619 guix: Quality of life improvements (dongcarl)
- moneyrocket/moneyrocket#20629 Improve id string robustness (dongcarl)
- moneyrocket/moneyrocket#20641 Use Qt top-level build facilities (hebasto)
- moneyrocket/moneyrocket#20650 Drop workaround for a fixed bug in Qt build system (hebasto)
- moneyrocket/moneyrocket#20673 Use more legible qmake commands in qt package (hebasto)
- moneyrocket/moneyrocket#20684 Define .INTERMEDIATE target once only (hebasto)
- moneyrocket/moneyrocket#20720 more robustly check for fcf-protection support (fanquake)
- moneyrocket/moneyrocket#20734 Make platform-specific targets available for proper platform builds only (hebasto)
- moneyrocket/moneyrocket#20936 build fuzz tests by default (danben)
- moneyrocket/moneyrocket#20937 guix: Make nsis reproducible by respecting SOURCE-DATE-EPOCH (dongcarl)
- moneyrocket/moneyrocket#20938 fix linking against -latomic when building for riscv (fanquake)
- moneyrocket/moneyrocket#20939 fix
RELOC_SECTION
security check for moneyrocket-util (fanquake) - moneyrocket/moneyrocket#20963 gitian-linux: Build binaries for 64-bit POWER (continued) (laanwj)
- moneyrocket/moneyrocket#21036 gitian: Bump descriptors to focal for 22.0 (fanquake)
- moneyrocket/moneyrocket#21045 Adds switch to enable/disable randomized base address in MSVC builds (EthanHeilman)
- moneyrocket/moneyrocket#21065 make macOS HOST in download-osx generic (fanquake)
- moneyrocket/moneyrocket#21078 guix: only download sources for hosts being built (fanquake)
- moneyrocket/moneyrocket#21116 Disable --disable-fuzz-binary for gitian/guix builds (hebasto)
- moneyrocket/moneyrocket#21182 remove mostly pointless
BOOST_PROCESS
macro (fanquake) - moneyrocket/moneyrocket#21205 actually fail when Boost is missing (fanquake)
- moneyrocket/moneyrocket#21209 use newer source for libnatpmp (fanquake)
- moneyrocket/moneyrocket#21226 Fix fuzz binary compilation under windows (danben)
- moneyrocket/moneyrocket#21231 Add /opt/homebrew to path to look for boost libraries (fyquah)
- moneyrocket/moneyrocket#21239 guix: Add codesignature attachment support for osx+win (dongcarl)
- moneyrocket/moneyrocket#21250 Make
HAVE_O_CLOEXEC
available outside LevelDB (bugfix) (theStack) - moneyrocket/moneyrocket#21272 guix: Passthrough
SDK_PATH
into container (dongcarl) - moneyrocket/moneyrocket#21274 assumptions: Assume C++17 (fanquake)
- moneyrocket/moneyrocket#21286 Bump minimum Qt version to 5.9.5 (hebasto)
- moneyrocket/moneyrocket#21298 guix: Bump time-machine, glibc, and linux-headers (dongcarl)
- moneyrocket/moneyrocket#21304 guix: Add guix-clean script + establish gc-root for container profiles (dongcarl)
- moneyrocket/moneyrocket#21320 fix libnatpmp macos cross compile (fanquake)
- moneyrocket/moneyrocket#21321 guix: Add curl to required tool list (hebasto)
- moneyrocket/moneyrocket#21333 set Unicode true for NSIS installer (fanquake)
- moneyrocket/moneyrocket#21339 Make
AM_CONDITIONAL([ENABLE_EXTERNAL_SIGNER])
unconditional (hebasto) - moneyrocket/moneyrocket#21349 Fix fuzz-cuckoocache cross-compiling with DEBUG=1 (hebasto)
- moneyrocket/moneyrocket#21354 build, doc: Drop no longer required packages from macOS cross-compiling dependencies (hebasto)
- moneyrocket/moneyrocket#21363 build, qt: Improve Qt static plugins/libs check code (hebasto)
- moneyrocket/moneyrocket#21375 guix: Misc feedback-based fixes + hier restructuring (dongcarl)
- moneyrocket/moneyrocket#21376 Qt 5.12.10 (fanquake)
- moneyrocket/moneyrocket#21382 Clean remnants of QTBUG-34748 fix (hebasto)
- moneyrocket/moneyrocket#21400 Fix regression introduced in #21363 (hebasto)
- moneyrocket/moneyrocket#21403 set --build when configuring packages in depends (fanquake)
- moneyrocket/moneyrocket#21421 don't try and use -fstack-clash-protection on Windows (fanquake)
- moneyrocket/moneyrocket#21423 Cleanups and follow ups after bumping Qt to 5.12.10 (hebasto)
- moneyrocket/moneyrocket#21427 Fix
id_string
invocations (dongcarl) - moneyrocket/moneyrocket#21430 Add -Werror=implicit-fallthrough compile flag (hebasto)
- moneyrocket/moneyrocket#21457 Split libtapi and clang out of
native_cctools
(fanquake) - moneyrocket/moneyrocket#21462 guix: Add guix-{attest,verify} scripts (dongcarl)
- moneyrocket/moneyrocket#21495 build, qt: Fix static builds on macOS Big Sur (hebasto)
- moneyrocket/moneyrocket#21497 Do not opt-in unused CoreWLAN stuff in depends for macOS (hebasto)
- moneyrocket/moneyrocket#21543 Enable safe warnings for msvc builds (hebasto)
- moneyrocket/moneyrocket#21565 Make
moneyrocket_qt.m4
more generic (fanquake) - moneyrocket/moneyrocket#21610 remove -Wdeprecated-register from NOWARN flags (fanquake)
- moneyrocket/moneyrocket#21613 enable -Wdocumentation (fanquake)
- moneyrocket/moneyrocket#21629 Fix configuring when building depends with
NO_BDB=1
(fanquake) - moneyrocket/moneyrocket#21654 build, qt: Make Qt rcc output always deterministic (hebasto)
- moneyrocket/moneyrocket#21655 build, qt: No longer need to set
QT_RCC_TEST=1
for determinism (hebasto) - moneyrocket/moneyrocket#21658 fix make deploy for arm64-darwin (sgulls)
- moneyrocket/moneyrocket#21694 Use XLIFF file to provide more context to Transifex translators (hebasto)
- moneyrocket/moneyrocket#21708, moneyrocket/moneyrocket#21593 Drop pointless sed commands (hebasto)
- moneyrocket/moneyrocket#21731 Update msvc build to use Qt5.12.10 binaries (sipsorcery)
- moneyrocket/moneyrocket#21733 Re-add command to install vcpkg (dplusplus1024)
- moneyrocket/moneyrocket#21793 Use
-isysroot
over--sysroot
on macOS (fanquake) - moneyrocket/moneyrocket#21869 Add missing
-D_LIBCPP_DEBUG=1
to debug flags (MarcoFalke) - moneyrocket/moneyrocket#21889 macho: check for control flow instrumentation (fanquake)
- moneyrocket/moneyrocket#21920 Improve macro for testing -latomic requirement (MarcoFalke)
- moneyrocket/moneyrocket#21991 libevent 2.1.12-stable (fanquake)
- moneyrocket/moneyrocket#22054 Bump Qt version to 5.12.11 (hebasto)
- moneyrocket/moneyrocket#22063 Use Qt archive of the same version as the compiled binaries (hebasto)
- moneyrocket/moneyrocket#22070 Don't use cf-protection when targeting arm-apple-darwin (fanquake)
- moneyrocket/moneyrocket#22071 Latest config.guess and config.sub (fanquake)
- moneyrocket/moneyrocket#22075 guix: Misc leftover usability improvements (dongcarl)
- moneyrocket/moneyrocket#22123 Fix qt.mk for mac arm64 (promag)
- moneyrocket/moneyrocket#22174 build, qt: Fix libraries linking order for Linux hosts (hebasto)
- moneyrocket/moneyrocket#22182 guix: Overhaul how guix-{attest,verify} works and hierarchy (dongcarl)
- moneyrocket/moneyrocket#22186 build, qt: Fix compiling qt package in depends with GCC 11 (hebasto)
- moneyrocket/moneyrocket#22199 macdeploy: minor fixups and simplifications (fanquake)
- moneyrocket/moneyrocket#22230 Fix MSVC linker /SubSystem option for moneyrocket-qt.exe (hebasto)
- moneyrocket/moneyrocket#22234 Mark print-% target as phony (dgoncharov)
- moneyrocket/moneyrocket#22238 improve detection of eBPF support (fanquake)
- moneyrocket/moneyrocket#22258 Disable deprecated-copy warning only when external warnings are enabled (MarcoFalke)
- moneyrocket/moneyrocket#22320 set minimum required Boost to 1.64.0 (fanquake)
- moneyrocket/moneyrocket#22348 Fix cross build for Windows with Boost Process (hebasto)
- moneyrocket/moneyrocket#22365 guix: Avoid relying on newer symbols by rebasing our cross toolchains on older glibcs (dongcarl)
- moneyrocket/moneyrocket#22381 guix: Test security-check sanity before performing them (with macOS) (fanquake)
- moneyrocket/moneyrocket#22405 Remove --enable-glibc-back-compat from Guix build (fanquake)
- moneyrocket/moneyrocket#22406 Remove --enable-determinism configure option (fanquake)
- moneyrocket/moneyrocket#22410 Avoid GCC 7.1 ABI change warning in guix build (sipa)
- moneyrocket/moneyrocket#22436 use aarch64 Clang if cross-compiling for darwin on aarch64 (fanquake)
- moneyrocket/moneyrocket#22465 guix: Pin kernel-header version, time-machine to upstream 1.3.0 commit (dongcarl)
- moneyrocket/moneyrocket#22511 guix: Silence
getent(1)
invocation, doc fixups (dongcarl) - moneyrocket/moneyrocket#22531 guix: Fixes to guix-{attest,verify} (achow101)
- moneyrocket/moneyrocket#22642 release: Release with separate sha256sums and sig files (dongcarl)
- moneyrocket/moneyrocket#22685 clientversion: No suffix
#if CLIENT_VERSION_IS_RELEASE
(dongcarl) - moneyrocket/moneyrocket#22713 Fix build with Boost 1.77.0 (sizeofvoid)
Tests and QA
- moneyrocket/moneyrocket#14604 Add test and refactor
feature_block.py
(sanket1729) - moneyrocket/moneyrocket#17556 Change
feature_config_args.py
not to rely on strange regtest=0 behavior (ryanofsky) - moneyrocket/moneyrocket#18795 wallet issue with orphaned rewards (domob1812)
- moneyrocket/moneyrocket#18847 compressor: Use a prevector in CompressScript serialization (jb55)
- moneyrocket/moneyrocket#19259 fuzz: Add fuzzing harness for LoadMempool(…) and DumpMempool(…) (practicalswift)
- moneyrocket/moneyrocket#19315 Allow outbound & block-relay-only connections in functional tests. (amitiuttarwar)
- moneyrocket/moneyrocket#19698 Apply strict verification flags for transaction tests and assert backwards compatibility (glozow)
- moneyrocket/moneyrocket#19801 Check for all possible
OP_CLTV
fail reasons infeature_cltv.py
(BIP 65) (theStack) - moneyrocket/moneyrocket#19893 Remove or explain syncwithvalidationinterfacequeue (MarcoFalke)
- moneyrocket/moneyrocket#19972 fuzz: Add fuzzing harness for node eviction logic (practicalswift)
- moneyrocket/moneyrocket#19982 Fix inconsistent lock order in
wallet_tests/CreateWallet
(hebasto) - moneyrocket/moneyrocket#20000 Fix creation of "std::string"s with \0s (vasild)
- moneyrocket/moneyrocket#20047 Use
wait_for_{block,header}
helpers inp2p_fingerprint.py
(theStack) - moneyrocket/moneyrocket#20171 Add functional test
test_txid_inv_delay
(ariard) - moneyrocket/moneyrocket#20189 Switch to BIP341's suggested scheme for outputs without script (sipa)
- moneyrocket/moneyrocket#20248 Fix length of R check in
key_signature_tests
(dgpv) - moneyrocket/moneyrocket#20276, moneyrocket/moneyrocket#20385, moneyrocket/moneyrocket#20688, moneyrocket/moneyrocket#20692 Run various mempool tests even with wallet disabled (mjdietzx)
- moneyrocket/moneyrocket#20323 Create or use existing properly initialized NodeContexts (dongcarl)
- moneyrocket/moneyrocket#20354 Add
feature_taproot.py --previous_release
(MarcoFalke) - moneyrocket/moneyrocket#20370 fuzz: Version handshake (MarcoFalke)
- moneyrocket/moneyrocket#20377 fuzz: Fill various small fuzzing gaps (practicalswift)
- moneyrocket/moneyrocket#20425 fuzz: Make CAddrMan fuzzing harness deterministic (practicalswift)
- moneyrocket/moneyrocket#20430 Sanitizers: Add suppression for unsigned-integer-overflow in libstdc++ (jonasschnelli)
- moneyrocket/moneyrocket#20437 fuzz: Avoid time-based "non-determinism" in fuzzing harnesses by using mocked GetTime() (practicalswift)
- moneyrocket/moneyrocket#20458 Add
is_bdb_compiled
helper (Sjors) - moneyrocket/moneyrocket#20466 Fix intermittent
p2p_fingerprint
issue (MarcoFalke) - moneyrocket/moneyrocket#20472 Add testing of ParseInt/ParseUInt edge cases with leading +/-/0:s (practicalswift)
- moneyrocket/moneyrocket#20507 sync: print proper lock order location when double lock is detected (vasild)
- moneyrocket/moneyrocket#20522 Fix sync issue in
disconnect_p2ps
(amitiuttarwar) - moneyrocket/moneyrocket#20524 Move
MIN_VERSION_SUPPORTED
to p2p.py (jnewbery) - moneyrocket/moneyrocket#20540 Fix
wallet_multiwallet
issue on windows (MarcoFalke) - moneyrocket/moneyrocket#20560 fuzz: Link all targets once (MarcoFalke)
- moneyrocket/moneyrocket#20567 Add option to git-subtree-check to do full check, add help (laanwj)
- moneyrocket/moneyrocket#20569 Fix intermittent
wallet_multiwallet
issue withgot_loading_error
(MarcoFalke) - moneyrocket/moneyrocket#20613 Use Popen.wait instead of RPC in
assert_start_raises_init_error
(MarcoFalke) - moneyrocket/moneyrocket#20663 fuzz: Hide
script_assets_test_minimizer
(MarcoFalke) - moneyrocket/moneyrocket#20674 fuzz: Call SendMessages after ProcessMessage to increase coverage (MarcoFalke)
- moneyrocket/moneyrocket#20683 Fix restart node race (MarcoFalke)
- moneyrocket/moneyrocket#20686 fuzz: replace CNode code with fuzz/util.h::ConsumeNode() (jonatack)
- moneyrocket/moneyrocket#20733 Inline non-member functions with body in fuzzing headers (pstratem)
- moneyrocket/moneyrocket#20737 Add missing assignment in
mempool_resurrect.py
(MarcoFalke) - moneyrocket/moneyrocket#20745 Correct
epoll_ctl
data race suppression (hebasto) - moneyrocket/moneyrocket#20748 Add race:SendZmqMessage tsan suppression (MarcoFalke)
- moneyrocket/moneyrocket#20760 Set correct nValue for multi-op-return policy check (MarcoFalke)
- moneyrocket/moneyrocket#20761 fuzz: Check that
NULL_DATA
is unspendable (MarcoFalke) - moneyrocket/moneyrocket#20765 fuzz: Check that certain script TxoutType are nonstandard (mjdietzx)
- moneyrocket/moneyrocket#20772 fuzz: Bolster ExtractDestination(s) checks (mjdietzx)
- moneyrocket/moneyrocket#20789 fuzz: Rework strong and weak net enum fuzzing (MarcoFalke)
- moneyrocket/moneyrocket#20828 fuzz: Introduce CallOneOf helper to replace switch-case (MarcoFalke)
- moneyrocket/moneyrocket#20839 fuzz: Avoid extraneous copy of input data, using Span<> (MarcoFalke)
- moneyrocket/moneyrocket#20844 Add sanitizer suppressions for AMD EPYC CPUs (MarcoFalke)
- moneyrocket/moneyrocket#20857 Update documentation in
feature_csv_activation.py
(PiRK) - moneyrocket/moneyrocket#20876 Replace getmempoolentry with testmempoolaccept in MiniWallet (MarcoFalke)
- moneyrocket/moneyrocket#20881 fuzz: net permission flags in net processing (MarcoFalke)
- moneyrocket/moneyrocket#20882 fuzz: Add missing muhash registration (MarcoFalke)
- moneyrocket/moneyrocket#20908 fuzz: Use mocktime in
process_message*
fuzz targets (MarcoFalke) - moneyrocket/moneyrocket#20915 fuzz: Fail if message type is not fuzzed (MarcoFalke)
- moneyrocket/moneyrocket#20946 fuzz: Consolidate fuzzing TestingSetup initialization (dongcarl)
- moneyrocket/moneyrocket#20954 Declare
nodes
typein test_framework.py
(kiminuo) - moneyrocket/moneyrocket#20955 Fix
get_previous_releases.py
for aarch64 (MarcoFalke) - moneyrocket/moneyrocket#20969 check that getblockfilter RPC fails without block filter index (theStack)
- moneyrocket/moneyrocket#20971 Work around libFuzzer deadlock (MarcoFalke)
- moneyrocket/moneyrocket#20993 Store subversion (user agent) as string in
msg_version
(theStack) - moneyrocket/moneyrocket#20995 fuzz: Avoid initializing version to less than
MIN_PEER_PROTO_VERSION
(MarcoFalke) - moneyrocket/moneyrocket#20998 Fix BlockToJsonVerbose benchmark (martinus)
- moneyrocket/moneyrocket#21003 Move MakeNoLogFileContext to
libtest_util
, and use it in bench (MarcoFalke) - moneyrocket/moneyrocket#21008 Fix zmq test flakiness, improve speed (theStack)
- moneyrocket/moneyrocket#21023 fuzz: Disable shuffle when merge=1 (MarcoFalke)
- moneyrocket/moneyrocket#21037 fuzz: Avoid designated initialization (C++20) in fuzz tests (practicalswift)
- moneyrocket/moneyrocket#21042 doc, test: Improve
setup_clean_chain
documentation (fjahr) - moneyrocket/moneyrocket#21080 fuzz: Configure check for main function (take 2) (MarcoFalke)
- moneyrocket/moneyrocket#21084 Fix timeout decrease in
feature_assumevalid
(brunoerg) - moneyrocket/moneyrocket#21096 Re-add dead code detection (flack)
- moneyrocket/moneyrocket#21100 Remove unused function
xor_bytes
(theStack) - moneyrocket/moneyrocket#21115 Fix Windows cross build (hebasto)
- moneyrocket/moneyrocket#21117 Remove
assert_blockchain_height
(MarcoFalke) - moneyrocket/moneyrocket#21121 Small unit test improvements, including helper to make mempool transaction (amitiuttarwar)
- moneyrocket/moneyrocket#21124 Remove unnecessary assignment in bdb (brunoerg)
- moneyrocket/moneyrocket#21125 Change
BOOST_CHECK
toBOOST_CHECK_EQUAL
for paths (kiminuo) - moneyrocket/moneyrocket#21142, moneyrocket/moneyrocket#21512 fuzz: Add
tx_pool
fuzz target (MarcoFalke) - moneyrocket/moneyrocket#21165 Use mocktime in
test_seed_peers
(dhruv) - moneyrocket/moneyrocket#21169 fuzz: Add RPC interface fuzzing. Increase fuzzing coverage from 65% to 70% (practicalswift)
- moneyrocket/moneyrocket#21170 bench: Add benchmark to write json into a string (martinus)
- moneyrocket/moneyrocket#21178 Run
mempool_reorg.py
even with wallet disabled (DariusParvin) - moneyrocket/moneyrocket#21185 fuzz: Remove expensive and redundant muhash from crypto fuzz target (MarcoFalke)
- moneyrocket/moneyrocket#21200 Speed up
rpc_blockchain.py
by removing miniwallet.generate() (MarcoFalke) - moneyrocket/moneyrocket#21211 Move
P2WSH_OP_TRUE
to shared test library (MarcoFalke) - moneyrocket/moneyrocket#21228 Avoid comparision of integers with different signs (jonasschnelli)
- moneyrocket/moneyrocket#21230 Fix
NODE_NETWORK_LIMITED_MIN_BLOCKS
disconnection (MarcoFalke) - moneyrocket/moneyrocket#21252 Add missing wait for sync to
feature_blockfilterindex_prune
(MarcoFalke) - moneyrocket/moneyrocket#21254 Avoid connecting to real network when running tests (MarcoFalke)
- moneyrocket/moneyrocket#21264 fuzz: Two scripted diff renames (MarcoFalke)
- moneyrocket/moneyrocket#21280 Bug fix in
transaction_tests
(glozow) - moneyrocket/moneyrocket#21293 Replace accidentally placed bit-OR with logical-OR (hebasto)
- moneyrocket/moneyrocket#21297
feature_blockfilterindex_prune.py
improvements (jonatack) - moneyrocket/moneyrocket#21310 zmq test: fix sync-up by matching notification to generated block (theStack)
- moneyrocket/moneyrocket#21334 Additional BIP9 tests (Sjors)
- moneyrocket/moneyrocket#21338 Add functional test for anchors.dat (brunoerg)
- moneyrocket/moneyrocket#21345 Bring
p2p_leak.py
up to date (mzumsande) - moneyrocket/moneyrocket#21357 Unconditionally check for fRelay field in test framework (jarolrod)
- moneyrocket/moneyrocket#21358 fuzz: Add missing include (
test/util/setup_common.h
) (MarcoFalke) - moneyrocket/moneyrocket#21371 fuzz: fix gcc Woverloaded-virtual build warnings (jonatack)
- moneyrocket/moneyrocket#21373 Generate fewer blocks in
feature_nulldummy
to fix timeouts, speed up (jonatack) - moneyrocket/moneyrocket#21390 Test improvements for UTXO set hash tests (fjahr)
- moneyrocket/moneyrocket#21410 increase
rpc_timeout
for fundrawtxtest_transaction_too_large
(jonatack) - moneyrocket/moneyrocket#21411 add logging, reduce blocks, move
sync_all
inwallet_
groups (jonatack) - moneyrocket/moneyrocket#21438 Add ParseUInt8() test coverage (jonatack)
- moneyrocket/moneyrocket#21443 fuzz: Implement
fuzzed_dns_lookup_function
as a lambda (practicalswift) - moneyrocket/moneyrocket#21445 cirrus: Use SSD cluster for speedup (MarcoFalke)
- moneyrocket/moneyrocket#21477 Add test for CNetAddr::ToString IPv6 address formatting (RFC 5952) (practicalswift)
- moneyrocket/moneyrocket#21487 fuzz: Use ConsumeWeakEnum in addrman for service flags (MarcoFalke)
- moneyrocket/moneyrocket#21488 Add ParseUInt16() unit test and fuzz coverage (jonatack)
- moneyrocket/moneyrocket#21491 test: remove duplicate assertions in util_tests (jonatack)
- moneyrocket/moneyrocket#21522 fuzz: Use PickValue where possible (MarcoFalke)
- moneyrocket/moneyrocket#21531 remove qt byteswap compattests (fanquake)
- moneyrocket/moneyrocket#21557 small cleanup in RPCNestedTests tests (fanquake)
- moneyrocket/moneyrocket#21586 Add missing suppression for signed-integer-overflow:txmempool.cpp (MarcoFalke)
- moneyrocket/moneyrocket#21592 Remove option to make TestChain100Setup non-deterministic (MarcoFalke)
- moneyrocket/moneyrocket#21597 Document
race:validation_chainstatemanager_tests
suppression (MarcoFalke) - moneyrocket/moneyrocket#21599 Replace file level integer overflow suppression with function level suppression (practicalswift)
- moneyrocket/moneyrocket#21604 Document why no symbol names can be used for suppressions (MarcoFalke)
- moneyrocket/moneyrocket#21606 fuzz: Extend psbt fuzz target a bit (MarcoFalke)
- moneyrocket/moneyrocket#21617 fuzz: Fix uninitialized read in i2p test (MarcoFalke)
- moneyrocket/moneyrocket#21630 fuzz: split FuzzedSock interface and implementation (vasild)
- moneyrocket/moneyrocket#21634 Skip SQLite fsyncs while testing (achow101)
- moneyrocket/moneyrocket#21669 Remove spurious double lock tsan suppressions by bumping to clang-12 (MarcoFalke)
- moneyrocket/moneyrocket#21676 Use mocktime to avoid intermittent failure in
rpc_tests
(MarcoFalke) - moneyrocket/moneyrocket#21677 fuzz: Avoid use of low file descriptor ids (which may be in use) in FuzzedSock (practicalswift)
- moneyrocket/moneyrocket#21678 Fix TestPotentialDeadLockDetected suppression (hebasto)
- moneyrocket/moneyrocket#21689 Remove intermittently failing and not very meaningful
BOOST_CHECK
incnetaddr_basic
(practicalswift) - moneyrocket/moneyrocket#21691 Check that no versionbits are re-used (MarcoFalke)
- moneyrocket/moneyrocket#21707 Extend functional tests for addr relay (mzumsande)
- moneyrocket/moneyrocket#21712 Test default
include_mempool
value of gettxout (promag) - moneyrocket/moneyrocket#21738 Use clang-12 for ASAN, Add missing suppression (MarcoFalke)
- moneyrocket/moneyrocket#21740 add new python linter to check file names and permissions (windsok)
- moneyrocket/moneyrocket#21749 Bump shellcheck version (hebasto)
- moneyrocket/moneyrocket#21754 Run
feature_cltv
with MiniWallet (MarcoFalke) - moneyrocket/moneyrocket#21762 Speed up
mempool_spend_coinbase.py
(MarcoFalke) - moneyrocket/moneyrocket#21773 fuzz: Ensure prevout is consensus-valid (MarcoFalke)
- moneyrocket/moneyrocket#21777 Fix
feature_notifications.py
intermittent issue (MarcoFalke) - moneyrocket/moneyrocket#21785 Fix intermittent issue in
p2p_addr_relay.py
(MarcoFalke) - moneyrocket/moneyrocket#21787 Fix off-by-ones in
rpc_fundrawtransaction
assertions (jonatack) - moneyrocket/moneyrocket#21792 Fix intermittent issue in
p2p_segwit.py
(MarcoFalke) - moneyrocket/moneyrocket#21795 fuzz: Terminate immediately if a fuzzing harness tries to perform a DNS lookup (belt and suspenders) (practicalswift)
- moneyrocket/moneyrocket#21798 fuzz: Create a block template in
tx_pool
targets (MarcoFalke) - moneyrocket/moneyrocket#21804 Speed up
p2p_segwit.py
(jnewbery) - moneyrocket/moneyrocket#21810 fuzz: Various RPC fuzzer follow-ups (practicalswift)
- moneyrocket/moneyrocket#21814 Fix
feature_config_args.py
intermittent issue (MarcoFalke) - moneyrocket/moneyrocket#21821 Add missing test for empty P2WSH redeem (MarcoFalke)
- moneyrocket/moneyrocket#21822 Resolve bug in
interface_moneyrocket_cli.py
(klementtan) - moneyrocket/moneyrocket#21846 fuzz: Add
-fsanitize=integer
suppression needed for RPC fuzzer (generateblock
) (practicalswift) - moneyrocket/moneyrocket#21849 fuzz: Limit toxic test globals to their respective scope (MarcoFalke)
- moneyrocket/moneyrocket#21867 use MiniWallet for
p2p_blocksonly.py
(theStack) - moneyrocket/moneyrocket#21873 minor fixes & improvements for files linter test (windsok)
- moneyrocket/moneyrocket#21874 fuzz: Add
WRITE_ALL_FUZZ_TARGETS_AND_ABORT
(MarcoFalke) - moneyrocket/moneyrocket#21884 fuzz: Remove unused --enable-danger-fuzz-link-all option (MarcoFalke)
- moneyrocket/moneyrocket#21890 fuzz: Limit ParseISO8601DateTime fuzzing to 32-bit (MarcoFalke)
- moneyrocket/moneyrocket#21891 fuzz: Remove strprintf test cases that are known to fail (MarcoFalke)
- moneyrocket/moneyrocket#21892 fuzz: Avoid excessively large min fee rate in
tx_pool
(MarcoFalke) - moneyrocket/moneyrocket#21895 Add TSA annotations to the WorkQueue class members (hebasto)
- moneyrocket/moneyrocket#21900 use MiniWallet for
feature_csv_activation.py
(theStack) - moneyrocket/moneyrocket#21909 fuzz: Limit max insertions in timedata fuzz test (MarcoFalke)
- moneyrocket/moneyrocket#21922 fuzz: Avoid timeout in EncodeBase58 (MarcoFalke)
- moneyrocket/moneyrocket#21927 fuzz: Run const CScript member functions only once (MarcoFalke)
- moneyrocket/moneyrocket#21929 fuzz: Remove incorrect float round-trip serialization test (MarcoFalke)
- moneyrocket/moneyrocket#21936 fuzz: Terminate immediately if a fuzzing harness tries to create a TCP socket (belt and suspenders) (practicalswift)
- moneyrocket/moneyrocket#21941 fuzz: Call const member functions in addrman fuzz test only once (MarcoFalke)
- moneyrocket/moneyrocket#21945 add P2PK support to MiniWallet (theStack)
- moneyrocket/moneyrocket#21948 Fix off-by-one in mockscheduler test RPC (MarcoFalke)
- moneyrocket/moneyrocket#21953 fuzz: Add
utxo_snapshot
target (MarcoFalke) - moneyrocket/moneyrocket#21970 fuzz: Add missing CheckTransaction before CheckTxInputs (MarcoFalke)
- moneyrocket/moneyrocket#21989 Use
COINBASE_MATURITY
in functional tests (kiminuo) - moneyrocket/moneyrocket#22003 Add thread safety annotations (ajtowns)
- moneyrocket/moneyrocket#22004 fuzz: Speed up transaction fuzz target (MarcoFalke)
- moneyrocket/moneyrocket#22005 fuzz: Speed up banman fuzz target (MarcoFalke)
- moneyrocket/moneyrocket#22029 [fuzz] Improve transport deserialization fuzz test coverage (dhruv)
- moneyrocket/moneyrocket#22048 MiniWallet: introduce enum type for output mode (theStack)
- moneyrocket/moneyrocket#22057 use MiniWallet (P2PK mode) for
feature_dersig.py
(theStack) - moneyrocket/moneyrocket#22065 Mark
CheckTxInputs
[[nodiscard]]
. Avoid UUM in fuzzing harnesscoins_view
(practicalswift) - moneyrocket/moneyrocket#22069 fuzz: don't try and use fopencookie() when building for Android (fanquake)
- moneyrocket/moneyrocket#22082 update nanobench from release 4.0.0 to 4.3.4 (martinus)
- moneyrocket/moneyrocket#22086 remove BasicTestingSetup from unit tests that don't need it (fanquake)
- moneyrocket/moneyrocket#22089 MiniWallet: fix fee calculation for P2PK and check tx vsize (theStack)
- moneyrocket/moneyrocket#21107, moneyrocket/moneyrocket#22092 Convert documentation into type annotations (fanquake)
- moneyrocket/moneyrocket#22095 Additional BIP32 test vector for hardened derivation with leading zeros (kristapsk)
- moneyrocket/moneyrocket#22103 Fix IPv6 check on BSD systems (n-thumann)
- moneyrocket/moneyrocket#22118 check anchors.dat when node starts for the first time (brunoerg)
- moneyrocket/moneyrocket#22120
p2p_invalid_block
: Check that a block rejected due to too-new tim… (willcl-ark) - moneyrocket/moneyrocket#22153 Fix
p2p_leak.py
intermittent failure (mzumsande) - moneyrocket/moneyrocket#22169 p2p, rpc, fuzz: various tiny follow-ups (jonatack)
- moneyrocket/moneyrocket#22176 Correct outstanding -Werror=sign-compare errors (Empact)
- moneyrocket/moneyrocket#22180 fuzz: Increase branch coverage of the float fuzz target (MarcoFalke)
- moneyrocket/moneyrocket#22187 Add
sync_blocks
inwallet_orphanedreward.py
(domob1812) - moneyrocket/moneyrocket#22201 Fix TestShell to allow running in Jupyter Notebook (josibake)
- moneyrocket/moneyrocket#22202 Add temporary coinstats suppressions (MarcoFalke)
- moneyrocket/moneyrocket#22203 Use ConnmanTestMsg from test lib in
denialofservice_tests
(MarcoFalke) - moneyrocket/moneyrocket#22210 Use MiniWallet in
test_no_inherited_signaling
RBF test (MarcoFalke) - moneyrocket/moneyrocket#22224 Update msvc and appveyor builds to use Qt5.12.11 binaries (sipsorcery)
- moneyrocket/moneyrocket#22249 Kill process group to avoid dangling processes when using
--failfast
(S3RK) - moneyrocket/moneyrocket#22267 fuzz: Speed up crypto fuzz target (MarcoFalke)
- moneyrocket/moneyrocket#22270 Add moneyrocket-util tests (+refactors) (MarcoFalke)
- moneyrocket/moneyrocket#22271 fuzz: Assert roundtrip equality for
CPubKey
(theStack) - moneyrocket/moneyrocket#22279 fuzz: add missing ECCVerifyHandle to
base_encode_decode
(apoelstra) - moneyrocket/moneyrocket#22292 bench, doc: benchmarking updates and fixups (jonatack)
- moneyrocket/moneyrocket#22306 Improvements to
p2p_addr_relay.py
(amitiuttarwar) - moneyrocket/moneyrocket#22310 Add functional test for replacement relay fee check (ariard)
- moneyrocket/moneyrocket#22311 Add missing syncwithvalidationinterfacequeue in
p2p_blockfilters
(MarcoFalke) - moneyrocket/moneyrocket#22313 Add missing
sync_all
tofeature_coinstatsindex
(MarcoFalke) - moneyrocket/moneyrocket#22322 fuzz: Check banman roundtrip (MarcoFalke)
- moneyrocket/moneyrocket#22363 Use
script_util
helpers for creating P2{PKH,SH,WPKH,WSH} scripts (theStack) - moneyrocket/moneyrocket#22399 fuzz: Rework CTxDestination fuzzing (MarcoFalke)
- moneyrocket/moneyrocket#22408 add tests for
bad-txns-prevout-null
reject reason (theStack) - moneyrocket/moneyrocket#22445 fuzz: Move implementations of non-template fuzz helpers from util.h to util.cpp (sriramdvt)
- moneyrocket/moneyrocket#22446 Fix
wallet_listdescriptors.py
if bdb is not compiled (hebasto) - moneyrocket/moneyrocket#22447 Whitelist
rpc_rawtransaction
peers to speed up tests (jonatack) - moneyrocket/moneyrocket#22742 Use proper target in
do_fund_send
(S3RK)
Miscellaneous
- moneyrocket/moneyrocket#19337 sync: Detect double lock from the same thread (vasild)
- moneyrocket/moneyrocket#19809 log: Prefix log messages with function name and source code location if -logsourcelocations is set (practicalswift)
- moneyrocket/moneyrocket#19866 eBPF Linux tracepoints (jb55)
- moneyrocket/moneyrocket#20024 init: Fix incorrect warning "Reducing -maxconnections from N to N-1, because of system limitations" (practicalswift)
- moneyrocket/moneyrocket#20145 contrib: Add getcoins.py script to get coins from (signet) faucet (kallewoof)
- moneyrocket/moneyrocket#20255 util: Add assume() identity function (MarcoFalke)
- moneyrocket/moneyrocket#20288 script, doc: Contrib/seeds updates (jonatack)
- moneyrocket/moneyrocket#20358 src/randomenv.cpp: Fix build on uclibc (ffontaine)
- moneyrocket/moneyrocket#20406 util: Avoid invalid integer negation in formatmoney and valuefromamount (practicalswift)
- moneyrocket/moneyrocket#20434 contrib: Parse elf directly for symbol and security checks (laanwj)
- moneyrocket/moneyrocket#20451 lint: Run mypy over contrib/devtools (fanquake)
- moneyrocket/moneyrocket#20476 contrib: Add test for elf symbol-check (laanwj)
- moneyrocket/moneyrocket#20530 lint: Update cppcheck linter to c++17 and improve explicit usage (fjahr)
- moneyrocket/moneyrocket#20589 log: Clarify that failure to read/write
fee_estimates.dat
is non-fatal (MarcoFalke) - moneyrocket/moneyrocket#20602 util: Allow use of c++14 chrono literals (MarcoFalke)
- moneyrocket/moneyrocket#20605 init: Signal-safe instant shutdown (laanwj)
- moneyrocket/moneyrocket#20608 contrib: Add symbol check test for PE binaries (fanquake)
- moneyrocket/moneyrocket#20689 contrib: Replace binary verification script verify.sh with python rewrite (theStack)
- moneyrocket/moneyrocket#20715 util: Add argsmanager::getcommand() and use it in moneyrocket-wallet (MarcoFalke)
- moneyrocket/moneyrocket#20735 script: Remove outdated extract-osx-sdk.sh (hebasto)
- moneyrocket/moneyrocket#20817 lint: Update list of spelling linter false positives, bump to codespell 2.0.0 (theStack)
- moneyrocket/moneyrocket#20884 script: Improve robustness of moneyrocketd.service on startup (hebasto)
- moneyrocket/moneyrocket#20906 contrib: Embed c++11 patch in
install_db4.sh
(gruve-p) - moneyrocket/moneyrocket#21004 contrib: Fix docker args conditional in gitian-build (setpill)
- moneyrocket/moneyrocket#21007 moneyrocketd: Add -daemonwait option to wait for initialization (laanwj)
- moneyrocket/moneyrocket#21041 log: Move "Pre-allocating up to position 0x[…] in […].dat" log message to debug category (practicalswift)
- moneyrocket/moneyrocket#21059 Drop boost/preprocessor dependencies (hebasto)
- moneyrocket/moneyrocket#21087 guix: Passthrough
BASE_CACHE
into container (dongcarl) - moneyrocket/moneyrocket#21088 guix: Jump forwards in time-machine and adapt (dongcarl)
- moneyrocket/moneyrocket#21089 guix: Add support for powerpc64{,le} (dongcarl)
- moneyrocket/moneyrocket#21110 util: Remove boost
posix_time
usage fromgettime*
(fanquake) - moneyrocket/moneyrocket#21111 Improve OpenRC initscript (parazyd)
- moneyrocket/moneyrocket#21123 code style: Add EditorConfig file (kiminuo)
- moneyrocket/moneyrocket#21173 util: Faster hexstr => 13% faster blocktojson (martinus)
- moneyrocket/moneyrocket#21221 tools: Allow argument/parameter bin packing in clang-format (jnewbery)
- moneyrocket/moneyrocket#21244 Move GetDataDir to ArgsManager (kiminuo)
- moneyrocket/moneyrocket#21255 contrib: Run test-symbol-check for risc-v (fanquake)
- moneyrocket/moneyrocket#21271 guix: Explicitly set umask in build container (dongcarl)
- moneyrocket/moneyrocket#21300 script: Add explanatory comment to tc.sh (dscotese)
- moneyrocket/moneyrocket#21317 util: Make assume() usable as unary expression (MarcoFalke)
- moneyrocket/moneyrocket#21336 Make .gitignore ignore src/test/fuzz/fuzz.exe (hebasto)
- moneyrocket/moneyrocket#21337 guix: Update darwin native packages dependencies (hebasto)
- moneyrocket/moneyrocket#21405 compat: remove memcpy -> memmove backwards compatibility alias (fanquake)
- moneyrocket/moneyrocket#21418 contrib: Make systemd invoke dependencies only when ready (laanwj)
- moneyrocket/moneyrocket#21447 Always add -daemonwait to known command line arguments (hebasto)
- moneyrocket/moneyrocket#21471 bugfix: Fix
bech32_encode
calls ingen_key_io_test_vectors.py
(sipa) - moneyrocket/moneyrocket#21615 script: Add trusted key for hebasto (hebasto)
- moneyrocket/moneyrocket#21664 contrib: Use lief for macos and windows symbol & security checks (fanquake)
- moneyrocket/moneyrocket#21695 contrib: Remove no longer used contrib/moneyrocket-qt.pro (hebasto)
- moneyrocket/moneyrocket#21711 guix: Add full installation and usage documentation (dongcarl)
- moneyrocket/moneyrocket#21799 guix: Use
gcc-8
across the board (dongcarl) - moneyrocket/moneyrocket#21802 Avoid UB in util/asmap (advance a dereferenceable iterator outside its valid range) (MarcoFalke)
- moneyrocket/moneyrocket#21823 script: Update reviewers (jonatack)
- moneyrocket/moneyrocket#21850 Remove
GetDataDir(net_specific)
function (kiminuo) - moneyrocket/moneyrocket#21871 scripts: Add checks for minimum required os versions (fanquake)
- moneyrocket/moneyrocket#21966 Remove double serialization; use software encoder for fee estimation (sipa)
- moneyrocket/moneyrocket#22060 contrib: Add torv3 seed nodes for testnet, drop v2 ones (laanwj)
- moneyrocket/moneyrocket#22244 devtools: Correctly extract symbol versions in symbol-check (laanwj)
- moneyrocket/moneyrocket#22533 guix/build: Remove vestigial SKIPATTEST.TAG (dongcarl)
- moneyrocket/moneyrocket#22643 guix-verify: Non-zero exit code when anything fails (dongcarl)
- moneyrocket/moneyrocket#22654 guix: Don't include directory name in SHA256SUMS (achow101)
Documentation
- moneyrocket/moneyrocket#15451 clarify getdata limit after #14897 (HashUnlimited)
- moneyrocket/moneyrocket#15545 Explain why CheckBlock() is called before AcceptBlock (Sjors)
- moneyrocket/moneyrocket#17350 Add developer documentation to isminetype (HAOYUatHZ)
- moneyrocket/moneyrocket#17934 Use
CONFIG_SITE
variable instead of --prefix option (hebasto) - moneyrocket/moneyrocket#18030 Coin::IsSpent() can also mean never existed (Sjors)
- moneyrocket/moneyrocket#18096 IsFinalTx comment about nSequence &
OP_CLTV
(nothingmuch) - moneyrocket/moneyrocket#18568 Clarify developer notes about constant naming (ryanofsky)
- moneyrocket/moneyrocket#19961 doc: tor.md updates (jonatack)
- moneyrocket/moneyrocket#19968 Clarify CRollingBloomFilter size estimate (robot-dreams)
- moneyrocket/moneyrocket#20200 Rename CODEOWNERS to REVIEWERS (adamjonas)
- moneyrocket/moneyrocket#20329 docs/descriptors.md: Remove hardened marker in the path after xpub (dgpv)
- moneyrocket/moneyrocket#20380 Add instructions on how to fuzz the P2P layer using Honggfuzz NetDriver (practicalswift)
- moneyrocket/moneyrocket#20414 Remove generated manual pages from master branch (laanwj)
- moneyrocket/moneyrocket#20473 Document current boost dependency as 1.71.0 (laanwj)
- moneyrocket/moneyrocket#20512 Add bash as an OpenBSD dependency (emilengler)
- moneyrocket/moneyrocket#20568 Use FeeModes doc helper in estimatesmartfee (MarcoFalke)
- moneyrocket/moneyrocket#20577 libconsensus: add missing error code description, fix NMoneyrocket link (theStack)
- moneyrocket/moneyrocket#20587 Tidy up Tor doc (more stringent) (wodry)
- moneyrocket/moneyrocket#20592 Update wtxidrelay documentation per BIP339 (jonatack)
- moneyrocket/moneyrocket#20601 Update for FreeBSD 12.2, add GUI Build Instructions (jarolrod)
- moneyrocket/moneyrocket#20635 fix misleading comment about call to non-existing function (pox)
- moneyrocket/moneyrocket#20646 Refer to BIPs 339/155 in feature negotiation (jonatack)
- moneyrocket/moneyrocket#20653 Move addr relay comment in net to correct place (MarcoFalke)
- moneyrocket/moneyrocket#20677 Remove shouty enums in
net_processing
comments (sdaftuar) - moneyrocket/moneyrocket#20741 Update 'Secure string handling' (prayank23)
- moneyrocket/moneyrocket#20757 tor.md and -onlynet help updates (jonatack)
- moneyrocket/moneyrocket#20829 Add -netinfo help (jonatack)
- moneyrocket/moneyrocket#20830 Update developer notes with signet (jonatack)
- moneyrocket/moneyrocket#20890 Add explicit macdeployqtplus dependencies install step (hebasto)
- moneyrocket/moneyrocket#20913 Add manual page generation for moneyrocket-util (laanwj)
- moneyrocket/moneyrocket#20985 Add xorriso to macOS depends packages (fanquake)
- moneyrocket/moneyrocket#20986 Update developer notes to discourage very long lines (jnewbery)
- moneyrocket/moneyrocket#20987 Add instructions for generating RPC docs (ben-kaufman)
- moneyrocket/moneyrocket#21026 Document use of make-tag script to make tags (laanwj)
- moneyrocket/moneyrocket#21028 doc/bips: Add BIPs 43, 44, 49, and 84 (luke-jr)
- moneyrocket/moneyrocket#21049 Add release notes for listdescriptors RPC (S3RK)
- moneyrocket/moneyrocket#21060 More precise -debug and -debugexclude doc (wodry)
- moneyrocket/moneyrocket#21077 Clarify -timeout and -peertimeout config options (glozow)
- moneyrocket/moneyrocket#21105 Correctly identify script type (niftynei)
- moneyrocket/moneyrocket#21163 Guix is shipped in Debian and Ubuntu (MarcoFalke)
- moneyrocket/moneyrocket#21210 Rework internal and external links (MarcoFalke)
- moneyrocket/moneyrocket#21246 Correction for VerifyTaprootCommitment comments (roconnor-blockstream)
- moneyrocket/moneyrocket#21263 Clarify that squashing should happen before review (MarcoFalke)
- moneyrocket/moneyrocket#21323 guix, doc: Update default HOSTS value (hebasto)
- moneyrocket/moneyrocket#21324 Update build instructions for Fedora (hebasto)
- moneyrocket/moneyrocket#21343 Revamp macOS build doc (jarolrod)
- moneyrocket/moneyrocket#21346 install qt5 when building on macOS (fanquake)
- moneyrocket/moneyrocket#21384 doc: add signet to moneyrocket.conf documentation (jonatack)
- moneyrocket/moneyrocket#21394 Improve comment about protected peers (amitiuttarwar)
- moneyrocket/moneyrocket#21398 Update fuzzing docs for afl-clang-lto (MarcoFalke)
- moneyrocket/moneyrocket#21444 net, doc: Doxygen updates and fixes in netbase.{h,cpp} (jonatack)
- moneyrocket/moneyrocket#21481 Tell howto install clang-format on Debian/Ubuntu (wodry)
- moneyrocket/moneyrocket#21567 Fix various misleading comments (glozow)
- moneyrocket/moneyrocket#21661 Fix name of script guix-build (Emzy)
- moneyrocket/moneyrocket#21672 Remove boostrap info from
GUIX_COMMON_FLAGS
doc (fanquake) - moneyrocket/moneyrocket#21688 Note on SDK for macOS depends cross-compile (jarolrod)
- moneyrocket/moneyrocket#21709 Update reduce-memory.md and moneyrocket.conf -maxconnections info (jonatack)
- moneyrocket/moneyrocket#21710 update helps for addnode rpc and -addnode/-maxconnections config options (jonatack)
- moneyrocket/moneyrocket#21752 Clarify that feerates are per virtual size (MarcoFalke)
- moneyrocket/moneyrocket#21811 Remove Visual Studio 2017 reference from readme (sipsorcery)
- moneyrocket/moneyrocket#21818 Fixup -coinstatsindex help, update moneyrocket.conf and files.md (jonatack)
- moneyrocket/moneyrocket#21856 add OSS-Fuzz section to fuzzing.md doc (adamjonas)
- moneyrocket/moneyrocket#21912 Remove mention of priority estimation (MarcoFalke)
- moneyrocket/moneyrocket#21925 Update bips.md for 0.21.1 (MarcoFalke)
- moneyrocket/moneyrocket#21942 improve make with parallel jobs description (klementtan)
- moneyrocket/moneyrocket#21947 Fix OSS-Fuzz links (MarcoFalke)
- moneyrocket/moneyrocket#21988 note that brew installed qt is not supported (jarolrod)
- moneyrocket/moneyrocket#22056 describe in fuzzing.md how to reproduce a CI crash (jonatack)
- moneyrocket/moneyrocket#22080 add maxuploadtarget to moneyrocket.conf example (jarolrod)
- moneyrocket/moneyrocket#22088 Improve note on choosing posix mingw32 (jarolrod)
- moneyrocket/moneyrocket#22109 Fix external links (IRC, …) (MarcoFalke)
- moneyrocket/moneyrocket#22121 Various validation doc fixups (MarcoFalke)
- moneyrocket/moneyrocket#22172 Update tor.md, release notes with removal of tor v2 support (jonatack)
- moneyrocket/moneyrocket#22204 Remove obsolete
okSafeMode
RPC guideline from developer notes (theStack) - moneyrocket/moneyrocket#22208 Update
REVIEWERS
(practicalswift) - moneyrocket/moneyrocket#22250 add basic I2P documentation (vasild)
- moneyrocket/moneyrocket#22296 Final merge of release notes snippets, mv to wiki (MarcoFalke)
- moneyrocket/moneyrocket#22335 recommend
--disable-external-signer
in OpenBSD build guide (theStack) - moneyrocket/moneyrocket#22339 Document minimum required libc++ version (hebasto)
- moneyrocket/moneyrocket#22349 Repository IRC updates (jonatack)
- moneyrocket/moneyrocket#22360 Remove unused section from release process (MarcoFalke)
- moneyrocket/moneyrocket#22369 Add steps for Transifex to release process (jonatack)
- moneyrocket/moneyrocket#22393 Added info to moneyrocket.conf doc (bliotti)
- moneyrocket/moneyrocket#22402 Install Rosetta on M1-macOS for qt in depends (hebasto)
- moneyrocket/moneyrocket#22432 Fix incorrect
testmempoolaccept
doc (glozow) - moneyrocket/moneyrocket#22648 doc, test: improve i2p/tor docs and i2p reachable unit tests (jonatack)
Credits
Thanks to everyone who directly contributed to this release:
- Aaron Clauson
- Adam Jonas
- amadeuszpawlik
- Amiti Uttarwar
- Andrew Chow
- Andrew Poelstra
- Anthony Towns
- Antoine Poinsot
- Antoine Riard
- apawlik
- apitko
- Ben Carman
- Ben Woosley
- benk10
- Bezdrighin
- Block Mechanic
- Brian Liotti
- Bruno Garcia
- Carl Dong
- Christian Decker
- coinforensics
- Cory Fields
- Dan Benjamin
- Daniel Kraft
- Darius Parvin
- Dhruv Mehta
- Dmitry Goncharov
- Dmitry Petukhov
- dplusplus1024
- dscotese
- Duncan Dean
- Elle Mouton
- Elliott Jin
- Emil Engler
- Ethan Heilman
- eugene
- Evan Klitzke
- Fabian Jahr
- Fabrice Fontaine
- fanquake
- fdov
- flack
- Fotis Koutoupas
- Fu Yong Quah
- fyquah
- glozow
- Gregory Sanders
- Guido Vranken
- Gunar C. Gessner
- h
- HAOYUatHZ
- Hennadii Stepanov
- Igor Cota
- Ikko Ashimine
- Ivan Metlushko
- jackielove4u
- James O'Beirne
- Jarol Rodriguez
- Joel Klabo
- John Newbery
- Jon Atack
- Jonas Schnelli
- João Barbosa
- Josiah Baker
- Karl-Johan Alm
- Kiminuo
- Klement Tan
- Kristaps Kaupe
- Larry Ruane
- lisa neigut
- Lucas Ontivero
- Luke Dashjr
- Maayan Keshet
- MarcoFalke
- Martin Ankerl
- Martin Zumsande
- Michael Dietz
- Michael Polzer
- Michael Tidwell
- Niklas Gögge
- nthumann
- Oliver Gugger
- parazyd
- Patrick Strateman
- Pavol Rusnak
- Peter Bushnell
- Pierre K
- Pieter Wuille
- PiRK
- pox
- practicalswift
- Prayank
- R E Broadley
- Rafael Sadowski
- randymcmillan
- Raul Siles
- Riccardo Spagni
- Russell O'Connor
- Russell Yanofsky
- S3RK
- saibato
- Samuel Dobson
- sanket1729
- Sawyer Billings
- Sebastian Falbesoner
- setpill
- sgulls
- sinetek
- Sjors Provoost
- Sriram
- Stephan Oeste
- Suhas Daftuar
- Sylvain Goumy
- t-bast
- Troy Giorshev
- Tushar Singla
- Tyler Chambers
- Uplab
- Vasil Dimov
- W. J. van der Laan
- willcl-ark
- William Bright
- William Casarin
- windsok
- wodry
- Yerzhan Mazhkenov
- Yuval Kogman
- Zero
As well as to everyone that helped with translations on Transifex.