sneedmca/suyu
1
0
Fork 0
mirror of https://git.suyu.dev/suyu/suyu synced 2024-11-01 12:57:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1
15824 commits 22 branches 3 tags 305 MiB
Commit graph

13938 commits

Author SHA1 Message Date
Rodrigo Locatti
d51afc4efb
Merge pull request #4432 from bylaws/patch-1 
video_core/gpu: Correct the size of the puller registers
 2020-07-27 05:25:49 -03:00
CrazyMax
1ffff4dab2 remove unused variable; 2020-07-27 10:36:26 +03:00
bunnei
99d191d80d
Merge pull request #4431 from kelnos/fix-exit-crash 
GCAdapter: only join worker thread if running & joinable
 2020-07-26 18:03:37 -07:00
Brian J. Tarricone
d840ed90e1 GCAdapter: only join worker thread if running & joinable 2020-07-26 14:54:02 -07:00
Billy Laws
f490b4545d
video_core/gpu: Correct the size of the puller registers 
The puller register array is made up of u32s however the `NUM_REGS` value is the size in bytes, so switch it to avoid making the struct unnecessary large. Also fix a small typo in a comment.
 2020-07-26 22:26:29 +01:00
lat9nq
156bf5b297 config: Make the save-as identifier more consistent 
Solves an issue with restoring the value upon reloading program.
 2020-07-26 13:31:00 -04:00
bunnei
08f02836d8
Merge pull request #4426 from lioncash/lock 
nvflinger: Use return value of Lock()
 2020-07-26 09:19:24 -07:00
bunnei
4524e1bd54
Merge pull request #4418 from lioncash/udp-warn 
udp/client: Remove unused boost include
 2020-07-25 21:50:37 -07:00
bunnei
05def61398 hle: nvdrv: Rewrite of GPU memory management. 2020-07-26 00:49:43 -04:00
bunnei
45cf48bd0a
Merge pull request #4415 from lioncash/maybe 
virtual_buffer: Mark size parameter of FreeMemoryPages() as [[maybe_unused]]
 2020-07-25 21:35:09 -07:00
bunnei
b69f902b18
Merge pull request #4417 from lioncash/poll 
gc_adapter/gc_poller: Resolve compiler warnings
 2020-07-25 19:42:09 -07:00
FearlessTobi
35b96a28d7 yuzu/configure_debug: Remove duplicated checkboxes 
Those are already found in the Filesystem tab.
They were added back to the Debug tab by mistake in the Vulkan PR.
 2020-07-26 02:45:19 +02:00
Lioncash
7b070bbf62 nvflinger: Mark interface functions with return values as [[nodiscard]] 
Not using the return value of these functions are undeniably the source
of a bug. This way we allow compilers to loudly make any future misuses
evident.
 2020-07-25 19:42:45 -04:00
Lioncash
5dab23e017 nvflinger: Use return value of Lock() 
comex reported in #4424 that we were incorrectly discarding the return
value of Lock() which is correct.
 2020-07-25 19:04:53 -04:00
bunnei
a2e1810287
Merge pull request #4350 from ogniK5377/hid-update-connected 
hid: Only update keyboard & debug pad inputs if enabled
 2020-07-25 11:57:24 -07:00
LC
e3503de588
common/string_util: Remove unimplemented function prototype (#4414) 
This function was relocated to log.h as a constexpr function, so this
can be removed.
 2020-07-25 15:37:51 +02:00
Lioncash
80eedff9e1 vulkan: Resolve -Wmissing-field-initializer warnings 2020-07-25 03:50:18 -04:00
Lioncash
1a7cf26884 udp/client: Remove unused boost include 
Also silences a deprecation warning from boost on Clang/GCC.
 2020-07-25 03:42:03 -04:00
Lioncash
ac7e4e2cab gc_adapter: Resolve C++20 deprecation warning 2020-07-25 03:38:22 -04:00
Lioncash
04699c366b gc_poller: Resolve -Wsign-compare warning 2020-07-25 03:37:22 -04:00
Lioncash
e19972dfc4 gc_poller: Resolve -Wredundant-move warning 2020-07-25 03:35:40 -04:00
Lioncash
2e511246fa lz4_compression: Make use of std::span in interfaces 
Allows compressing the data and size parameters into one.
 2020-07-25 03:17:04 -04:00
Lioncash
c5bdccfecb zstd_compression: Make use of std::span in interfaces 
Allows condensing the data and size parameters into a single argument.
 2020-07-25 03:11:56 -04:00
Lioncash
ca6ff01333 virtual_buffer: Mark size parameter of FreeMemoryPages() as [[maybe_unused]] 
This isn't used on Windows, but is used on non-Windows operating
systems.
 2020-07-25 03:04:27 -04:00
bunnei
d046e9b458
Merge pull request #4380 from ogniK5377/swkbd-inline-1 
swkbd: Return result for Calc request for inlined swkbd
 2020-07-24 22:31:24 -07:00
bunnei
dc2d31b1b2
Merge pull request #4393 from lioncash/unused5 
vk_rasterizer: Remove unused variable in Clear()
 2020-07-24 20:33:58 -07:00
bunnei
c73701edea
Merge pull request #4377 from Morph1984/dark-themes 
qt-themes: Add Midnight Blue qdarkstyle theme (2.8.1)
 2020-07-24 19:23:45 -07:00
bunnei
2ed8f3f549
Merge pull request #4334 from lat9nq/clear-per-game-settings 
configure_per_game: Clearer per-game settings
 2020-07-24 19:19:27 -07:00
bunnei
d488cb843e
Merge pull request #4388 from lioncash/written 
buffer_cache: Eliminate redundant map lookup in MarkRegionAsWritten()
 2020-07-24 11:29:37 -07:00
bunnei
f650cf8a9a
Merge pull request #4391 from lioncash/nrvo 
video_core: Allow copy elision to take place where applicable
 2020-07-24 06:33:09 -07:00
bunnei
1d7de0a8ee
Merge pull request #4394 from lioncash/unused6 
video_core: Remove unused variables
 2020-07-23 19:54:59 -07:00
bunnei
5ac91a6c7a
Merge pull request #4353 from ameerj/gc-refactor 
gc_adapter: Refactor code
 2020-07-23 18:44:39 -07:00
Jan Beich
f99be1c923 network: add missing include for BSDs 
src/core/network/network.cpp:112:28: error: use of undeclared identifier 'SHUT_RD'
constexpr int SD_RECEIVE = SHUT_RD;
                           ^
src/core/network/network.cpp:113:25: error: use of undeclared identifier 'SHUT_WR'
constexpr int SD_SEND = SHUT_WR;
                        ^
src/core/network/network.cpp:114:25: error: use of undeclared identifier 'SHUT_RDWR'
constexpr int SD_BOTH = SHUT_RDWR;
                        ^
src/core/network/network.cpp:120:37: error: unknown type name 'in_addr'; did you mean 'in_addr_t'?
constexpr IPv4Address TranslateIPv4(in_addr addr) {
                                    ^~~~~~~
                                    in_addr_t
/usr/include/netdb.h:66:20: note: 'in_addr_t' declared here
typedef __uint32_t      in_addr_t;
                        ^
src/core/network/network.cpp:121:27: error: member reference base type 'in_addr_t' (aka 'unsigned int') is not a structure or union
    const u32 bytes = addr.s_addr;
                      ~~~~^~~~~~~
src/core/network/network.cpp:121:15: error: variables defined in a constexpr function must be initialized
    const u32 bytes = addr.s_addr;
              ^
src/core/network/network.cpp:126:10: error: incomplete result type 'sockaddr' in function definition
sockaddr TranslateFromSockAddrIn(SockAddrIn input) {
         ^
/usr/include/netdb.h:142:9: note: forward declaration of 'sockaddr'
        struct  sockaddr *ai_addr;      /* binary address */
                ^
src/core/network/network.cpp:127:5: error: unknown type name 'sockaddr_in'; did you mean 'sockaddr'?
    sockaddr_in result;
    ^~~~~~~~~~~
    sockaddr
/usr/include/netdb.h:142:9: note: 'sockaddr' declared here
        struct  sockaddr *ai_addr;      /* binary address */
                ^
src/core/network/network.cpp:127:17: error: variable has incomplete type 'sockaddr'
    sockaddr_in result;
                ^
/usr/include/netdb.h:142:9: note: forward declaration of 'sockaddr'
        struct  sockaddr *ai_addr;      /* binary address */
                ^
src/core/network/network.cpp:131:29: error: use of undeclared identifier 'AF_INET'
        result.sin_family = AF_INET;
                            ^
src/core/network/network.cpp:135:29: error: use of undeclared identifier 'AF_INET'
        result.sin_family = AF_INET;
                            ^
src/core/network/network.cpp:139:23: error: use of undeclared identifier 'htons'
    result.sin_port = htons(input.portno);
                      ^
src/core/network/network.cpp:143:14: error: variable has incomplete type 'sockaddr'
    sockaddr addr;
             ^
/usr/include/netdb.h:142:9: note: forward declaration of 'sockaddr'
        struct  sockaddr *ai_addr;      /* binary address */
                ^
src/core/network/network.cpp:156:1: error: unknown type name 'linger'
linger MakeLinger(bool enable, u32 linger_value) {
^
src/core/network/network.cpp:157:5: error: unknown type name 'linger'
    linger value;
    ^
src/core/network/network.cpp:185:16: error: use of undeclared identifier 'AF_INET'
        return AF_INET;
               ^
src/core/network/network.cpp:195:16: error: use of undeclared identifier 'SOCK_STREAM'
        return SOCK_STREAM;
               ^
src/core/network/network.cpp:197:16: error: use of undeclared identifier 'SOCK_DGRAM'
        return SOCK_DGRAM;
               ^
src/core/network/network.cpp:207:16: error: use of undeclared identifier 'IPPROTO_TCP'
        return IPPROTO_TCP;
               ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
 2020-07-22 22:10:15 +00:00
David Marcec
8abb31a19d vi: IApplicationDisplayService:GetIndirectLayerImageRequiredMemoryInfo 
Needed for dark souls and monster hunter
 2020-07-21 23:06:18 +10:00
Rodrigo Locatti
7278c59d70
Merge pull request #4359 from ReinUsesLisp/clamp-shared 
renderer_{opengl,vulkan}: Clamp shared memory to host's limit
 2020-07-21 04:51:05 -03:00
Rodrigo Locatti
721e6015a8
Merge pull request #4360 from ReinUsesLisp/glasm-bar 
gl_arb_decompiler: Execute BAR even when inside control flow
 2020-07-21 04:50:55 -03:00
Rodrigo Locatti
9ea9a60e17
Merge pull request #4361 from ReinUsesLisp/lane-id 
decode/other: Implement S2R.LaneId
 2020-07-21 04:50:45 -03:00
Lioncash
82b7e5c8ee surface_params: Make use of designated initializers where applicable 
Provides a convenient way to avoid unnecessary zero initializing.
 2020-07-21 02:27:22 -04:00
Lioncash
bd9545a3a8 surface_params: Remove redundant assignment 
This is a redundant assignment that can be removed.
 2020-07-21 02:26:49 -04:00
Lioncash
c705a1db96 surface_params: Replace questionable usages of the comma operator with semicolons 
These are bugs waiting to happen.
 2020-07-21 02:26:48 -04:00
David
e9bfe05e04
Merge pull request #4306 from ReinUsesLisp/bsd-network 
core/network: Add network abstraction
 2020-07-21 16:05:47 +10:00
Lioncash
e17fb5ee97 video_core: Remove unused variables 
Silences several compiler warnings about unused variables.
 2020-07-21 00:57:25 -04:00
Lioncash
4b369126c4 vk_rasterizer: Remove unused variable in Clear() 
The relevant values are already assigned further down in the lambda, so
this can be removed entirely.
 2020-07-21 00:49:10 -04:00
Lioncash
059305a6bf compatible_formats: Add missing header guard 
Prevents potential inclusion issues from occurring.
 2020-07-21 00:42:19 -04:00
Lioncash
6adc824d9d video_core: Allow copy elision to take place where applicable 
Removes const from some variables that are returned from functions, as
this allows the move assignment/constructors to execute for them.
 2020-07-21 00:36:13 -04:00
bunnei
3d13d7f48f
Merge pull request #4324 from ReinUsesLisp/formats 
video_core: Fix, add and rename pixel formats
 2020-07-21 00:13:04 -04:00
lat9nq
e35239b861 configure_ui: Ensure a separator follows the returned path 2020-07-20 23:19:07 -04:00
lat9nq
19250aadee configure_ui: don't use an empty string 
If the user had cancelled, it would clear the text box. That behavior was sanitized underneath, but may anyways cause inconveniences.
 2020-07-20 23:11:46 -04:00
lat9nq
599b7c26a9 main: Don't use as many string copies 
Co-Authored-By: LC <lioncash@users.noreply.github.com>
 2020-07-20 23:03:55 -04:00
lat9nq
a723ed31fd main: rewrite (save as) screenshot saving 
This picks a default directory and file name. If on Windows and save-as screenshot saving is enabled, it asks the user, first defaulting to the default screenshot path, and with a default filename in the format `[title_id]_[year-mt-dy_hr-mn-sc-msc].png`. Otherwise, or on Linux for now, it simply saves a file in that directory with that file name.
 2020-07-20 23:03:55 -04:00
lat9nq
71b902cf62 configuration: Setup UI to config screenshot path and saving 
This adds two options to the General -> UI tab. The first disables picking a place to save the file. The second chooses a default directory for saving screenshots.
 2020-07-20 23:03:49 -04:00
lat9nq
3848155c42 common: Add a screenshots directory 
Adds a screenshots directory as a path managed by FileUtil.
 2020-07-20 22:51:02 -04:00
David Marcec
dd4a02d15c video_core: Remove redundant pixel format type 
We already get the format type before converting shadow formats and during shadow formats.
 2020-07-21 12:44:32 +10:00
bunnei
61e4c0f83d
Merge pull request #4168 from ReinUsesLisp/global-memory 
gl_arb_decompiler: Use NV_shader_buffer_{load,store} on assembly shaders
 2020-07-20 21:54:17 -04:00
Lioncash
26c6c71837 buffer_cache: Eliminate redundant map lookup in MarkRegionAsWritten() 
We can make use of emplace()'s return value to determine whether or not
we need to perform an increment.

emplace() performs no insertion if an element already exist, so this can
eliminate a find() call.
 2020-07-20 17:48:00 -04:00
Morph
d942472cce wait_tree: Include Midnight Blue dark themes 2020-07-20 01:25:25 -04:00
James Rowe
7e01311061 qt-themes: Add Midnight Blue qdarkstyle theme (2.8.1) 
Co-authored-by: Morph <39850852+Morph1984@users.noreply.github.com>
 2020-07-20 01:25:25 -04:00
David Marcec
8248d76964 Address issues 2020-07-20 11:52:07 +10:00
lat9nq
2120740ee6 configure_graphics_advnaced: clang-format mk ii 2020-07-19 13:26:55 -04:00
lat9nq
23347b8869 configure_graphics_advanced: Fix oversight from rebase 2020-07-19 13:26:55 -04:00
lat9nq
520b4c7829 configuration_shared: Remove unused functions 
These were only kept for compatibility with old code during testing.
 2020-07-19 13:26:55 -04:00
lat9nq
3ef4769f31 configuration: Use forward declares and remove extraneous structs 2020-07-19 13:26:55 -04:00
lat9nq
335aef78c4 configuration_shared: Make CheckState strongly typed 
Also gets rid of unnecessary explicit namespace usage.
 2020-07-19 13:26:55 -04:00
lat9nq
55ac28769a clang-format 2020-07-19 13:26:55 -04:00
lat9nq
0d462f5608 configuration_shared: Break up tracker structs to respective classes 
One less global variable.
 2020-07-19 13:26:55 -04:00
lat9nq
e483ed21eb configure_system: break instead of semicolon 
Makes the code more readable

Co-Authored-By: LC <lioncash@users.noreply.github.com>
 2020-07-19 13:26:55 -04:00
lat9nq
d5fdbd88c8 clang-format 2020-07-19 13:26:55 -04:00
lat9nq
33a9218f35 configure_system: Highlight labels on startup 
whoops
 2020-07-19 13:26:55 -04:00
lat9nq
90a0fb1e0e configure_graphics: Fix layout in global config 
Fixes a regression where the global config takes up a lot of extra space.
 2020-07-19 13:26:55 -04:00
lat9nq
c94a8a3a43 configure_per_game: Improve style consistency 
The way the configurations are set up, it is not trivial to do this. I'll leave it as is, but the API selection, and the background color and volume slider selectors are kind of not following the style.
 2020-07-19 13:26:55 -04:00
lat9nq
a350ae6be6 configure_system: Implement highlighted overrides 2020-07-19 13:26:55 -04:00
lat9nq
6316a3d8d9 configuration_shared: Add default combobox setup function 
Not a catch-all, but helps clean up the code for when I do this a lot. Also fixes some bugs caught in configure_graphics.
 2020-07-19 13:26:55 -04:00
lat9nq
2627241541 configuration_shared: Use an int instead of a QString 
I noticed some of the code could be reduced to just passing the function an int, since I was doing the same thing over and over. Also clang-formats configure_graphics
 2020-07-19 13:26:55 -04:00
lat9nq
38152ab0b9 configure_graphics_advanced: Implement highlighted overrides 2020-07-19 13:26:55 -04:00
lat9nq
b79a6ebf9c configuration_shared: Switch back to background colors 
Let's see if I make up my mind.
 2020-07-19 13:26:55 -04:00
lat9nq
44b3183ec8 configuration_shared: Better use global text 
Also adds trackers for graphics and advanced graphics
 2020-07-19 13:26:55 -04:00
lat9nq
c9f93c05f7 configure_audio: fix UI margins 2020-07-19 13:26:55 -04:00
lat9nq
c4246b80f8 configure_graphics: Implement highlighted overrides 2020-07-19 13:26:55 -04:00
lat9nq
bf25d583c6 configure_audio: Implement highlighted overrides 2020-07-19 13:26:55 -04:00
lat9nq
da65b92f9e configuration_shared: Require name of the widget for highlighting 
Prevents mass-coloring of elements later on
 2020-07-19 13:26:55 -04:00
lat9nq
5a9dc8f002 configuration_shared: Use a highlight instead of background color 
Fixes visibility in the built-in dark theme
 2020-07-19 13:26:55 -04:00
lat9nq
58672cc7b6 configure_general: Implement manual tristate buttons 2020-07-19 13:26:55 -04:00
lat9nq
e26e82d8d5 configuration_shared: Initial functions and data for manual tristate 
Sets up initial support for implementing colored tristate functions. These functions color a QWidget blue when it's overriding a global setting, and discolor it when not. The lack of color indicates it uses the global state, replacing the Qt::CheckState::PartiallyChecked state with the global state.
 2020-07-19 13:26:55 -04:00
ameerj
68d6d3e173 Fix axis thresholding while polling 
axes were very sensitive when mapping controls.
 2020-07-19 11:49:26 -04:00
David Marcec
d7d2c27b48 swkbd: Return result for Calc request for inlined swkbd 
Fixes random swkbd popups in monster hunter
 2020-07-19 18:56:16 +10:00
ReinUsesLisp
51817f6e59 core/network: Add network abstraction 
This commit adds a network abstraction designed to implement bsd:s but
at the same time work as a generic abstraction to implement any
networking code we have to use from core.

This is implemented on top of BSD sockets on Unix systems and winsock on
Windows. The code is designed around winsocks having compatibility
definitions to support both BSD and Windows sockets.
 2020-07-19 04:12:40 -03:00
Rodrigo Locatti
ad0b295125
Merge pull request #4376 from ogniK5377/dark-wait-tree 
frontend: Improve wait tree readability for dark themes
 2020-07-19 03:55:36 -03:00
Jan Beich
db43b37e15 alignment: explicitly include <new> after 723edb4c06 
In file included from src/core/hle/kernel/memory/page_table.cpp:5:
src/./common/alignment.h:67:68: error: no member named 'align_val_t' in namespace 'std'
        return static_cast<T*>(::operator new (n * sizeof(T), std::align_val_t{Align}));
                                                              ~~~~~^
src/./common/alignment.h:71:51: error: no member named 'align_val_t' in namespace 'std'
        ::operator delete (p, n * sizeof(T), std::align_val_t{Align});
                                             ~~~~~^
 2020-07-18 23:06:16 +00:00
David Marcec
617eeb09e0 Address issues 2020-07-19 01:02:41 +10:00
FearlessTobi
4450a2688a Address trivial review comments. 2020-07-18 14:09:13 +02:00
FearlessTobi
0072003a14 configure_ui: Address some review comments from the previous PR 2020-07-18 14:09:13 +02:00
FearlessTobi
347b50ad43 yuzu: Port translation support from Citra 
Co-Authored-By: Weiyi Wang <wwylele@gmail.com>
 2020-07-18 14:09:11 +02:00
David Marcec
db4502b7b7 frontend: Improve wait tree readability for dark themes 2020-07-18 20:22:03 +10:00
bunnei
4a8cb9a706
Merge pull request #4348 from lioncash/nano 
core_timing: Make usage of nanoseconds more consistent in the interface
 2020-07-18 01:45:10 -04:00
bunnei
bbeea7502c
Merge pull request #4373 from lioncash/allocator 
alignment: Simplify AlignmentAllocator implementation
 2020-07-18 01:04:17 -04:00
ReinUsesLisp
a8a2526128 gl_arb_decompiler: Use NV_shader_buffer_{load,store} on assembly shaders 
NV_shader_buffer_{load,store} is a 2010 extension that allows GL applications
to use what in Vulkan is known as physical pointers, this is basically C
pointers. On GLASM these is exposed through the LOAD/STORE/ATOM
instructions.

Up until now, assembly shaders were using NV_shader_storage_buffer_object.
These work fine, but have a (probably unintended) limitation that forces
us to have the limit of a single stage for all shader stages. In contrast,
with NV_shader_buffer_{load,store} we can pass GPU addresses to the
shader through local parameters (GLASM equivalent uniform constants, or
push constants on Vulkan). Local parameters have the advantage of being
per stage, allowing us to generate code without worrying about binding
overlaps.
 2020-07-18 01:59:57 -03:00
bunnei
c700079e08
Merge pull request #4345 from Morph1984/fix-createfile 
filesystem: Create subdirectories prior to creating a file
 2020-07-18 00:59:26 -04:00
bunnei
90cbcaa44a
Merge pull request #4273 from ogniK5377/async-shaders-prod 
video_core: Add asynchronous shader decompilation and compilation
 2020-07-18 00:48:27 -04:00
David Marcec
967307d3be Fix style issues 2020-07-18 14:24:32 +10:00
bunnei
821d295f24
Merge pull request #4364 from lioncash/desig5 
vulkan: Make use of designated initializers where applicable
 2020-07-18 00:12:43 -04:00
bunnei
af1151b1b0
Merge pull request #4365 from lioncash/mii 
mii/manager: Make use of designated initializers
 2020-07-17 22:20:15 -04:00
bunnei
0b733903f0
Merge pull request #4374 from ReinUsesLisp/fix-err 
vk_device: Fix build error on old MSVC versions
 2020-07-17 20:30:24 -04:00
bunnei
47b305387a
Merge pull request #4366 from lioncash/mii-sign 
mii/manager: Resolve sign mismatch warnings
 2020-07-17 20:13:06 -04:00
ReinUsesLisp
81c8f92f2e vk_device: Fix build error on old MSVC versions 
Designated initializers on old MSVC versions fail to build when they
take the address of a constant.
 2020-07-17 20:27:53 -03:00
bunnei
5d95e62443
Merge pull request #4344 from VolcaEM/c3 
dmnt_cheat_vm: Implement opcode 0xC3 (ReadWriteStaticRegister)
 2020-07-17 17:11:52 -04:00
bunnei
0f0b756775
Merge pull request #4309 from Morph1984/fix-romfs-bug 
fs: Fix RomFS building when zero byte files are present
 2020-07-17 17:01:20 -04:00
ameerj
1e7bed0a45 std::size_t where appropriate, make error message more clear if can't read 2020-07-17 12:10:32 -04:00
bunnei
19c6bf72db
Merge pull request #4322 from ReinUsesLisp/fix-dynstate 
vk_state_tracker: Fix dirty flags for stencil_enable on VK_EXT_extended_dynamic_state
 2020-07-17 09:50:45 -04:00
Lioncash
723edb4c06 alignment: Simplify AlignmentAllocator implementation 
With C++20, much of the allocator interface has been simplified, so we
can make the same adjustments.
 2020-07-17 08:30:12 -04:00
LC
47956a3bbc
Merge pull request #4369 from lioncash/hle-macro 
macro_hle: Remove unnecessary std::make_pair calls
 2020-07-17 05:20:41 -04:00
LC
9d3cbf6a90
Merge pull request #4340 from lioncash/remove 
shader_cache: Make use of std::erase_if
 2020-07-17 05:19:20 -04:00
David Marcec
4f473cda64 Drop settings namespace 2020-07-17 17:23:24 +10:00
David Marcec
85b591f6f0 Remove duplicate config 2020-07-17 14:26:18 +10:00
David Marcec
f48187449e Use conditional var 2020-07-17 14:26:17 +10:00
David Marcec
2ba195aa0d Drop max workers from 8->2 for testing 2020-07-17 14:26:15 +10:00
David Marcec
85d7a8f466 Rebase for per game settings 2020-07-17 14:26:14 +10:00
David Marcec
468bd9c1b0 async shaders 2020-07-17 14:24:57 +10:00
David
c783cf443e
Merge pull request #4347 from lioncash/logging 
settings: Make use of std::string_view over std::string for logging
 2020-07-17 13:25:06 +10:00
David
92f37a229e
Merge pull request #4371 from lioncash/cmake2 
core/CMakeLists: Add missing physical_memory.h header file
 2020-07-17 13:22:19 +10:00
David
adbf5ca50b
Merge pull request #4357 from lioncash/unused4 
kernel: Remove unused variables
 2020-07-17 13:18:31 +10:00
David
69f8b6a53e
Merge pull request #4358 from lioncash/unused5 
kernel/thread: Remove unimplemented function prototype
 2020-07-17 13:17:52 +10:00
Lioncash
c0650cd82c macro_hle: Remove unnecessary static keywords 
These functions are already in an anonymous namespace which makes the
functions internally linked.
 2020-07-16 23:17:17 -04:00
David
0d10c863a5
Merge pull request #4367 from lioncash/inc2 
constants: Add missing <array> include
 2020-07-17 13:14:01 +10:00
David
9cca0c2f83
Merge pull request #4368 from lioncash/macro 
macro: Resolve missing parameter in doxygen comment
 2020-07-17 13:13:22 +10:00
David
3ce4edba64
Merge pull request #4370 from lioncash/simplify 
macro_hle: Simplify shift expression in HLE_771BB18C62444DA0()
 2020-07-17 13:13:05 +10:00
Lioncash
311f500753 core/CMakeLists: Add missing physical_memory.h header file 
Allows this header file to show up in IDE CMake generators.
 2020-07-16 22:56:31 -04:00
Lioncash
be6b7591d9 macro_hle: Simplify shift expression in HLE_771BB18C62444DA0() 
Given the expression involves a 32-bit value, this simplifies down to
just: 0x3ffffff. This is likely a remnant from testing that was never
cleaned up.

Resolves a -Wshift-overflow warning.
 2020-07-16 22:16:11 -04:00
Lioncash
cc935d997b macro_hle: Remove unnecessary std::make_pair calls 
The purpose of make_pair is generally to deduce the types within the
pair without explicitly specifying the types, so these usages were
generally unnecessary, particularly when the type is enforced by the
array declaration.
 2020-07-16 21:59:25 -04:00
Lioncash
502dbfb9eb macro: Resolve missing parameter in doxygen comment 
Resolves a -Wdocumentation warning.
 2020-07-16 21:54:42 -04:00
Lioncash
e07eb5b223 constants: Add missing <array> include 
Eliminates reliance on an indirect include.
 2020-07-16 21:43:20 -04:00
Lioncash
e54c940abf mii/manager: Resolve sign mismatch warnings 
Previously the loop termination condition was testing variables of
different signedness.
 2020-07-16 21:07:04 -04:00
Rodrigo Locatti
39ae2deb28
Merge pull request #4363 from lioncash/mismatch 
vk_texture_cache: Amend mismatched access masks and indices in UploadBuffer
 2020-07-16 21:54:40 -03:00
Lioncash
7f989378c0 mii/manager: Make use of designated initializers 
Allows returning the structure in a more concise manner.
 2020-07-16 20:45:33 -04:00
bunnei
3bbf4462db
Merge pull request #4292 from bunnei/mii-rewrite 
hle: service: mii: Rewrite service to properly support creation of random and default miis.
 2020-07-16 20:05:40 -04:00
Lioncash
7785123b1c wrapper: Make use of designated initializers where applicable 2020-07-16 20:01:01 -04:00
Lioncash
01da386617 vk_texture_cache: Make use of designated initializers where applicable 2020-07-16 19:52:38 -04:00
Lioncash
169759e069 vk_texture_cache: Amend mismatched access masks and indices in UploadBuffer 
Discovered while converting relevant parts of the codebase over to
designated initializers.
 2020-07-16 19:45:46 -04:00
Lioncash
08d36afd40 vk_swapchain: Make use of designated initializers where applicable 2020-07-16 19:27:02 -04:00
Lioncash
3c060503bc vk_stream_buffer: Make use of designated initializers where applicable 2020-07-16 19:22:11 -04:00
Lioncash
70147e913f vk_staging_buffer_pool: Make use of designated initializers where applicable 2020-07-16 19:22:03 -04:00
Lioncash
2025f847bb vk_shader_util: Make use of designated initializers where applicable 2020-07-16 19:17:41 -04:00
Lioncash
97e7663004 vk_scheduler: Make use of designated initializers where applicable 2020-07-16 19:11:43 -04:00
Lioncash
fd7af52ec3 vk_sampler_cache: Make use of designated initializers where applicable 2020-07-16 19:06:40 -04:00
Lioncash
772b6e4d28 vk_resource_manager: Make use of designated initializers where applicable 2020-07-16 19:02:35 -04:00
Lioncash
8ebd6a21c5 vk_renderpass_cache: Make use of designated initializers where applicable 2020-07-16 18:57:23 -04:00
Lioncash
01f297f2e0 vk_rasterizer: Make use of designated initializers where applicable 2020-07-16 18:49:42 -04:00
Lioncash
c07b0ffe47 vk_query_cache: Make use of designated initializers where applicable 2020-07-16 18:34:04 -04:00
Lioncash
d43e923990 vk_pipeline_cache: Make use of designated initializers where applicable 2020-07-16 18:32:29 -04:00
Lioncash
7d5f93832c vk_memory_manager: Make use of designated initializers where applicable 2020-07-16 18:26:30 -04:00
Lioncash
75c00c3cb0 vk_image: Make use of designated initializers where applicable 2020-07-16 18:24:26 -04:00
Lioncash
6d165481ad vk_descriptor_pool: Make use of designated initializers where applicable 2020-07-16 18:19:45 -04:00
Lioncash
fb563e75e9 vk_graphics_pipeline: Resolve narrowing warnings 
For whatever reason, VK_TRUE and VK_FALSE aren't defined as having a
VkBool32 type, so we need to cast to it explicitly.
 2020-07-16 18:13:49 -04:00
Lioncash
5330ca396d vk_compute_pipeline: Make use of designated initializers where applicable 2020-07-16 17:32:12 -04:00
Lioncash
757ddd8158 vk_compute_pass: Make use of designated initializers where applicable 
Note: Some barriers can't be converted over yet, as they ICE MSVC.
 2020-07-16 17:23:56 -04:00
Lioncash
a66a0a6a53 vk_buffer_cache: Make use of designated initializers where applicable 
Note: An array within CopyFrom() cannot be converted over yet, as it
ICEs MSVC when converted over.
 2020-07-16 16:59:39 -04:00
Rodrigo Locatti
104c523d3d
Merge pull request #4327 from lioncash/desig2 
address_space_info: Make use of designated initializers
 2020-07-16 17:41:55 -03:00
Rodrigo Locatti
be68ee88c2
Merge pull request #4333 from lioncash/desig3 
vk_graphics_pipeline: Make use of designated initializers where applicable
 2020-07-16 17:41:45 -03:00
Rodrigo Locatti
b6d73ec9c2
Merge pull request #4332 from lioncash/vkdev 
vk_device: Make use of designated initializers where applicable
 2020-07-16 17:41:20 -03:00
ReinUsesLisp
210cc0204d decode/other: Implement S2R.LaneId 
This maps to host's thread id.

- Fixes graphical issues on Paper Mario.
 2020-07-16 16:09:39 -03:00
ReinUsesLisp
88e57b13e0 gl_arb_decompiler: Execute BAR even when inside control flow 
Unlike GLSL, GLASM allows us to call BAR inside control flow.

- Fixes graphical artifacts in Paper Mario.
 2020-07-16 16:05:52 -03:00
ReinUsesLisp
a5a72cbd20 renderer_{opengl,vulkan}: Clamp shared memory to host's limit 
This stops shaders from failing to build when the exceed host's shared
memory size limit. An error is logged.
 2020-07-16 16:02:46 -03:00
bunnei
98b36625fa
Merge pull request #4321 from lioncash/desig 
vk_blit_screen: Make use of designated initializers where applicable
 2020-07-16 14:55:36 -04:00
Lioncash
8bef49cde5 kernel/thread: Remove unimplemented function prototype 
This isn't used, so it can be removed.
 2020-07-16 14:32:46 -04:00
Lioncash
2bab07c367 kernel: Remove unused variables 
Resolves some compiler warnings in the Linux build.
 2020-07-16 14:17:50 -04:00
Lioncash
07d080ecc8 kernel: Add missing include 2020-07-16 13:51:51 -04:00
Lioncash
f0125b2be8 cpu_manager: Mark function getters as static 
All these do are return std::function instances of static functions, so
these can be used without an instance of the CPU manager.
 2020-07-16 13:30:56 -04:00
Lioncash
51546ce57e cpu_manager: Remove unused preemption_count variable 
Shrinks the data structure by 8 bytes.
 2020-07-16 13:24:25 -04:00
Lioncash
201514cb50 cpu_manager: Add missing includes 
Previously this header was relying on indirect inclusions that are no
longer satisfied.
 2020-07-16 13:22:58 -04:00
Ameer
94f5f29573 Refactor adapter code 2020-07-16 13:00:04 -04:00
bunnei
a89dfc9183
Merge pull request #4261 from ameerj/gc-calibration 
input_common: GC Controller save and compare against analog origin state
 2020-07-16 11:40:09 -04:00
bunnei
2781201bfb
Merge pull request #4337 from lat9nq/fix-per-game-async 
main: Set async gpu properly after loading per-game setting
 2020-07-16 11:33:51 -04:00
bunnei
9121d35e70
Merge pull request #4297 from FearlessTobi/skip-profile-select 
main/profile_select: Don't prompt for profile selection when only one is available
 2020-07-16 09:45:09 -04:00
David
0648e023ea
Merge pull request #4346 from lioncash/thread 
kernel/handle_table: Remove usages of the global system instance
 2020-07-16 23:02:04 +10:00
David Marcec
0319cc1c37 hid: Only update keyboard & debug pad inputs if enabled 
Previously we would ignore this setting and would update the states regardless of the user setting
 2020-07-16 22:28:49 +10:00
David
815f30dc10
Merge pull request #4249 from Morph1984/delete-update-aoc-on-overwrite 
registered_cache: Remove previous update/dlc if it exists on install
 2020-07-16 20:36:22 +10:00
Morph
f66e3181dc Check for empty section0 and CNMT prior to install 2020-07-16 05:22:51 -04:00
Morph
5892fc1555 Add comment to clarify the nullptr check 2020-07-16 00:15:27 -04:00
Morph
2079bb4090 filesystem: Create subdirectories prior to creating a file 
If subdirectories exist in the given path parameter and don't exist in the real filesystem create them prior to creating the files within.
This fixes the softlocks upon save creation in The Legend of Zelda: Breath of the Wild
 2020-07-16 00:15:27 -04:00
bunnei
f26f53f35b
Merge pull request #4328 from lioncash/unused-var3 
memory_layout: Remove unused data member
 2020-07-15 22:08:05 -04:00
Lioncash
0435b7d361 core_timing: Remove unused data member 
Shrinks the size of the CoreTiming class by 8 bytes.
 2020-07-15 19:41:37 -04:00
Lioncash
bef1844a51 core_timing: Make TimedCallback take std::chrono::nanoseconds 
Enforces our desired time units directly with a concrete type.
 2020-07-15 19:41:22 -04:00
Lioncash
8b50c660df core_timing: Make use of std::chrono with ScheduleEvent 2020-07-15 18:54:15 -04:00
Lioncash
af5a56ddc4 settings: Resolve a sign conversion warning within GetTimeZoneString() 
A sign conversion warning was occurring due to an int < size_t
comparison.
 2020-07-15 13:45:22 -04:00
Lioncash
73bb87c06b kernel/process: Move name and system context to the bottom of the member list 
These aren't directly important or commonly used within the process, so
we can move these to the bottom to allow everything else to be more
likely to be within a cache line.
 2020-07-15 13:40:18 -04:00
Lioncash
52e83f0d5c kernel/handle_table: Remove usages of the global system instance 
Removes even more usages of the global system instance, trimming away
more dependencies on global variables and making them explicit in the
interface.
 2020-07-15 13:40:15 -04:00
Lioncash
5dbf91d739 settings: Make use of std::string_view over std::string for logging 
In all usages of LogSetting(), string literals are provided.
std::string_view is better suited here, as we won't churn a bunch of
string allocations every time the settings are logged out.

While we're at it, we can fold LogSetting() into LogSettings(), given
it's only ever used there.
 2020-07-15 13:37:33 -04:00
Lioncash
4ad69ca96e kernel/thread: Remove global GetCurrentThread() 
This is only used in one place, so we can fold it into the calling code,
eliminating a place for the global system instance to be used.
 2020-07-15 13:28:05 -04:00
Morph
0ca7b8269a clang format 2020-07-15 13:27:04 -04:00
Morph
1bbc61f5f1 Use proper install result when overwriting files 2020-07-15 13:27:04 -04:00
Morph
8794e623d9 Remove global system instance and address feedback 2020-07-15 13:27:04 -04:00
Morph
a82fdea1ac registered_cache: Remove previous update/dlc if it exists on install 
- This checks for and removes old updates or dlc based on title id. If a content meta nca exists within the registered cache, it will attempt to remove all the ncas associated with the content meta before installing a new update/dlc
 2020-07-15 13:27:04 -04:00
VolcaEM
e90802e762
clang-format 2020-07-15 01:22:52 +02:00
VolcaEM
b608acd688
dmnt_cheat_vm: Implement opcode 0xC3 (ReadWriteStaticRegister) 
This was based on Atmosphére's DMNT Cheat VM:

- https://github.com/Atmosphere-NX/Atmosphere/blob/master/stratosphere/dmnt/source/cheat/impl/dmnt_cheat_vm.hpp
- https://github.com/Atmosphere-NX/Atmosphere/blob/master/stratosphere/dmnt/source/cheat/impl/dmnt_cheat_vm.cpp

From Atmosphére's documentation: "Code type 0xC3 reads or writes a static register with a given register"

There are now only two remaining opcodes to implement (PauseProcess and BreakProcess)

This is untested because I don't have any experience in testing cheats on yuzu
 2020-07-15 01:19:22 +02:00
Rodrigo Locatti
263200f982
Merge pull request #4342 from lioncash/endian 
common/swap: Make use of std::endian
 2020-07-14 18:49:07 -03:00
Lioncash
9f027b1af2 common/swap: Make use of std::endian 
Allows removing a bunch of defines in favor of a two liner.
 2020-07-14 16:26:54 -04:00
Lioncash
969100d41a shader_cache: Make use of std::erase_if 
Now that we use C++20, we can also make use of std::erase_if instead of
needing to do the erase-remove idiom.
 2020-07-14 15:49:15 -04:00
bunnei
666b37ad56
Merge pull request #4242 from ReinUsesLisp/maxwell-dma 
maxwell_dma: Match official doc and support pitch->voxel copies
 2020-07-14 14:04:16 -04:00
lat9nq
a683e42516 clang-format 2020-07-14 13:46:42 -04:00
lat9nq
6d1477f214 settings: Move settings sanitization to its own function 
Creates a new function that can be expanded later to fix other settings that are known to cause emulation errors across executables.
 2020-07-14 13:36:09 -04:00
Ameer
93fe982a0c Rebase to master 2020-07-14 13:04:02 -04:00
bunnei
e2730372b8
Merge pull request #4294 from MerryMage/cpu-opt-settings 
configuration: Add settings to enable/disable specific CPU optimizations
 2020-07-14 12:38:03 -04:00
bunnei
450cbcfee6
Merge pull request #4282 from Morph1984/fs-size 
filesystem: Set various NAND partition sizes to their defaults
 2020-07-14 12:16:42 -04:00
Ameer
ab65de2f96 Fix crash if gc configured but adapter not connected 2020-07-14 11:23:10 -04:00
bunnei
393cdb15f5
Merge pull request #4314 from lioncash/input-warn 
gcadapter: Tidy up compiler warnings
 2020-07-14 10:20:12 -04:00
bunnei
edb291b3be
Merge pull request #4315 from lioncash/udp-warn 
udp: Silence a C++20 deprecation warning
 2020-07-14 09:33:16 -04:00
lat9nq
8160e142e1 main: Set async gpu properly after loading per-game setting 
Another error that got pass me and only noticed when I was doing the per-game settings UI rework. This prevents asynchronous GPU emulation from being disabled while multi core is enabled as a result of a poorly put together per-game config.
 2020-07-14 01:02:10 -04:00
lat9nq
e02687ff47 configure_general: Explicitly guard use_multi_core when applying settings 
This is likely an oversight during a rebase. Guards use_multi_core to be only set when the global value is in use. It should not make a difference given the current code base, but makes the code sensible.
 2020-07-14 00:49:17 -04:00
Lioncash
0f8b977663 vk_device: Make use of designated initializers where applicable 
Avoids redundant repetitions of variable names, and allows assignment
all in one statement.
 2020-07-13 22:24:01 -04:00
LC
edb2caaae5
Merge pull request #4280 from jbeich/system-libusb 
cmake: pass libusb include directory
 2020-07-13 22:21:07 -04:00
Ameer
b284c43385 input_common: drop unused libusb.h include 
Remnant of an early implementation.
 2020-07-14 01:50:34 +00:00
Lioncash
0475a167f8 vk_graphics_pipeline: Make use of designated initializers where applicable 
Avoids redundant variable name repetitions.
 2020-07-13 21:07:56 -04:00
Jan Beich
883fab2fff input_common: make libusb private to gc_adapter 2020-07-13 18:48:19 +00:00
Lioncash
f2f876e3ff memory_layout: Remove unused data member 
This isn't used, so it can be removed entirely, shrinking the structure
size by 8 bytes.
 2020-07-13 10:51:23 -04:00
Lioncash
ed0fe04b4f address_space_info: Use type alias to simplify code 
We can define an alias for the index arrays and then just reuse it to
make the code nicer to read.
 2020-07-13 10:42:52 -04:00
Lioncash
c3eb42de65 address_space_info: Make use of designated initializers 
We can alter the structure so that we can use designated initializers in
the array, eliminating the comments that indicate their field names.
 2020-07-13 10:42:49 -04:00
ReinUsesLisp
fbc232426d video_core: Rearrange pixel format names 
Normalizes pixel format names to match Vulkan names. Previous to this
commit pixel formats had no convention, leading to confusion and
potential bugs.
 2020-07-13 01:44:23 -03:00
ReinUsesLisp
eda37ff26b video_core: Fix DXT4 and RGB565 2020-07-13 01:01:09 -03:00
ReinUsesLisp
a8dab2ffb3 video_core/format_lookup_table: Add formats with existing PixelFormat 2020-07-13 01:01:09 -03:00
ReinUsesLisp
480850ffe7 video_core: Fix B5G6R5_UNORM render target format 2020-07-13 01:01:09 -03:00
ReinUsesLisp
990b14f181 video_core: Fix B5G6R5U 2020-07-13 01:01:09 -03:00
ReinUsesLisp
1d20aac795 video_core: Implement RGBA32_SINT render target 2020-07-13 01:01:09 -03:00
ReinUsesLisp
9338599d72 video_core: Implement RGBA32_SINT render target 2020-07-13 01:01:09 -03:00
ReinUsesLisp
95c0f5afe5 video_core: Implement RGBA16_SINT render target 2020-07-13 01:01:09 -03:00
ReinUsesLisp
977d6c46f3 video_core: Implement RGBA8_SINT render target 2020-07-13 01:01:09 -03:00
ReinUsesLisp
50c6030a8d video_core: Implement RG32_SINT render target 2020-07-13 01:01:09 -03:00
ReinUsesLisp
e849d68048 video_core: Implement RG8_SINT render target and fix RG8_UINT 2020-07-13 01:01:09 -03:00
ReinUsesLisp
f29fede49c video_core: Implement R8_SINT render target 2020-07-13 01:01:08 -03:00
ReinUsesLisp
fd33e996e0 video_core: Implement R8_SNORM render target 2020-07-13 01:01:08 -03:00
ReinUsesLisp
505c206eb8 video_core/surface: Remove explicit values on PixelFormat's definition 2020-07-13 01:01:08 -03:00
ReinUsesLisp
143662118c video_core/surface: Reorder render target to pixel format switch 2020-07-13 01:01:08 -03:00
Lioncash
db6fbd5894 vk_blit_screen: Make use of designated initializers where applicable 
Now that we make use of C++20, we can use designated initializers to
make things a little nicer to read.
 2020-07-12 19:45:30 -04:00
ReinUsesLisp
0fe09df386 vk_state_tracker: Fix dirty flags for stencil_enable on VK_EXT_extended_dynamic_state 
Fixes a regression on any game using stencil on devices with
VK_EXT_extended_dynamic_state.
 2020-07-12 20:43:42 -03:00
Lioncash
8df93132cd udp: Silence a C++20 deprecation warning 
C++20 deprecates using the = lambda capture to implicitly capture the
this pointer. Instead, we must specify it explicitly.
 2020-07-12 15:49:42 -04:00
Lioncash
a1dddca4ab gc_poller: Mark GCButtonFactory::GetNextInput() as const 
This doesn't modify class instance state.
 2020-07-12 15:43:07 -04:00
Lioncash
839c91cd14 gc_poller: Get rid of undefined behavior in Create() 
Ensures that the function always has returns in all control paths.
 2020-07-12 15:41:35 -04:00
Lioncash
a8ba6dc3c9 gc_poller: Silence sign conversion warnings 2020-07-12 15:40:22 -04:00
Lioncash
32b6fc4062 gc_adapter: Remove deprecated usage of = in lambda captures 
It's deprecated in C++20 to use = to capture the this pointer.

Instead, we can simply pass this as an argument to the thread
constructor.
 2020-07-12 15:38:19 -04:00
Lioncash
9ce6ea648f gc_adapter: Silence sign conversion warnings 2020-07-12 15:36:27 -04:00
MerryMage
a67d00ef31 configure_cpu: Split optimization settings off into Debug tab 2020-07-12 19:32:32 +01:00
Fernando Sahmkow
739d90ee66
Merge pull request #4265 from Morph1984/file-rename 
vfs_real: Fix MoveFile
 2020-07-12 13:00:09 -04:00
LC
ed89bcc767
Merge pull request #4290 from lioncash/latest 
CMakeLists: Make use of /std:c++latest on MSVC
 2020-07-12 12:25:10 -04:00
bunnei
f1aabc21ee
Merge pull request #3385 from Morph1984/batch-install 
frontend: Add support to batch install files to NAND
 2020-07-12 12:20:56 -04:00
Tobias
80a0f2a118
common/alignment: Fix compilation errors (#4303) 2020-07-12 16:45:49 +02:00
Morph
fd1c3aa14e fs: Fix RomFS building when zero byte files are present 
When zero byte files are present, the key (offset) for that file is identical to the file right after. A std::map isn't able to fit key-value pairs with identical keys (offsets), therefore, the solution is to use std::multimap which permits multiple entries with the same key.

This most prominently fixes Pokemon Sword and Shield weather with any RomFS mod applied.
 2020-07-12 04:33:35 -04:00
bunnei
e60733aad3
Merge pull request #4275 from CrazyMax/desired_language 
AM: fix GetDesiredLanguage:
 2020-07-12 01:45:08 -04:00
bunnei
5fb27f83cf
Merge pull request #4289 from ReinUsesLisp/dynfix 
vk_rasterizer: Pass <pSizes> to CmdBindVertexBuffers2EXT
 2020-07-11 23:44:03 -04:00
bunnei
e706501c8d hle: service: mii: Rewrite service to properly support creation of random and default miis. 2020-07-11 21:34:59 -04:00
bunnei
1074c87f18
Revert "Port citra-emu/citra#5441: "Common: remove a mod from AlignUp"" 2020-07-11 19:28:09 -04:00
Marshall Mohror
a4306b9e56 Common: remove a mod from AlignUp (#5441) 
In cases where the size is not a known constant when inlining, AlignUp<std::size_t> currently generates two 64-bit div instructions.
This generates one div and a cmov which is significantly cheaper.
 2020-07-11 18:39:00 +02:00
MerryMage
da11a27f42 configure_cpu: Add tooltips 2020-07-11 16:38:38 +01:00