12030 commits

Author	SHA1	Message	Date
bunnei	5c7253f8d3	Merge pull request #3177 from bunnei/new-ipc-req ... kernel: Implement a more accurate IPC dispatch.	2019-11-30 18:56:35 -05:00
bunnei	930b7c18a6	Merge pull request #3184 from ReinUsesLisp/framebuffer-cache ... gl_framebuffer_cache: Optimize framebuffer cache management	2019-11-30 18:46:40 -05:00
ReinUsesLisp	ff64c3951a	texture_cache/surface_base: Fix out of bounds texture views ... Some texture views were being created out of bounds (with more layers or mipmaps than what the original texture has). This is because of a miscalculation in mipmap bounding. end_layer and end_mipmap are out of bounds (e.g. layer 6 in a cubemap), there's no need to add one more there. Fixes OpenGL errors and Vulkan crashes on Splatoon 2.	2019-11-29 16:51:14 -03:00
ReinUsesLisp	fb6cf12a17	gl_framebuffer_cache: Optimize framebuffer key ... Pack color attachment enumerations into a single u32. To determine the number of buffers, the highest color attachment with a shared pointer that doesn't point to null is used.	2019-11-28 23:02:20 -03:00
ReinUsesLisp	c34da106ed	gl_rasterizer: Re-enable framebuffer cache for clear buffers	2019-11-28 23:02:20 -03:00
ReinUsesLisp	e6a0a30334	renderer_opengl: Make ScreenRectVertex's constructor constexpr	2019-11-28 20:36:02 -03:00
ReinUsesLisp	dee7844443	renderer_opengl: Remove C casts	2019-11-28 20:28:27 -03:00
ReinUsesLisp	3a44faff11	renderer_opengl: Use explicit binding for presentation shaders	2019-11-28 20:25:56 -03:00
ReinUsesLisp	75cc501d52	renderer_opengl: Drop macros for message decorations	2019-11-28 20:15:25 -03:00
ReinUsesLisp	056f049b26	renderer_opengl: Move static definitions to anonymous namespace	2019-11-28 20:14:40 -03:00
ReinUsesLisp	4589582eaf	renderer_opengl: Move commentaries to header file	2019-11-28 20:11:03 -03:00
bunnei	c3d3b173d3	kernel: Implement a more accurate IPC dispatch.	2019-11-28 12:01:53 -05:00
bunnei	e3ee017e91	Merge pull request #3169 from lioncash/memory ... core/memory: Deglobalize memory management code	2019-11-28 11:43:17 -05:00
bunnei	fe65045dcb	Merge pull request #3171 from lioncash/internal-link ... filesys/romfs: Make ProcessFile and ProcessDirectory internally linked	2019-11-28 01:18:10 -05:00
Morph	e0242a4654	patch_manager: Adds check for disabled cheats to prevent them from being enabled (#3178) ... * Adds check for disabled cheats to prevent them from being added to the CheatList * Address feedback	2019-11-28 01:17:17 -05:00
bunnei	c47fc3301d	Merge pull request #3170 from lioncash/enum ... file_sys/directory: Make EntryType an enum class	2019-11-27 23:23:01 -05:00
Rodrigo Locatti	913d0bb269	Merge pull request #3174 from lioncash/optional ... video_core/gpu_thread: Tidy up SwapBuffers()	2019-11-27 20:35:31 -03:00
Lioncash	aed6d8bef5	video_core/gpu_thread: Tidy up SwapBuffers() ... We can just use std::nullopt and std::make_optional to make this a little bit less noisy.	2019-11-27 17:46:11 -05:00
Lioncash	9403979c22	video_core/const_buffer_locker: Make use of std::tie in HasEqualKeys() ... Tidies it up a little bit visually.	2019-11-27 05:53:43 -05:00
Lioncash	930e311526	video_core/const_buffer_locker: Remove unused includes	2019-11-27 05:51:13 -05:00
Lioncash	9341ca7979	video_core/const_buffer_locker: Remove #pragma once from cpp file ... Silences a compiler warning.	2019-11-27 05:50:51 -05:00
Lioncash	d66ab2b8aa	filesys/romfs: Remove unused includes ... These inclusions aren't used at all within the public interface, so they can be removed.	2019-11-27 05:29:52 -05:00
Lioncash	ba3c55ab7b	filesys/romfs: Make ProcessFile and ProcessDirectory internally linked ... These functions aren't used outside of this file, so we can place them within an anonymous namespace.	2019-11-27 05:26:35 -05:00
Lioncash	a3149536e2	file_sys/directory: Make EntryType an enum class ... This can trivially be an enum class rather than a regular enum, making it more strongly typed.	2019-11-27 05:11:02 -05:00
Lioncash	e7e939104b	core/memory; Migrate over SetCurrentPageTable() to the Memory class ... Now that literally every other API function is converted over to the Memory class, we can just move the file-local page table into the Memory implementation class, finally getting rid of global state within the memory code.	2019-11-26 21:55:39 -05:00
Lioncash	50a518be69	core/memory: Migrate over GetPointerFromVMA() to the Memory class ... Now that everything else is migrated over, this is essentially just code relocation and conversion of a global accessor to the class member variable. All that remains is to migrate over the page table.	2019-11-26 21:55:39 -05:00
Lioncash	e4c381b885	core/memory: Migrate over Write{8, 16, 32, 64, Block} to the Memory class ... The Write functions are used slightly less than the Read functions, which make these a bit nicer to move over. The only adjustments we really need to make here are to Dynarmic's exclusive monitor instance. We need to keep a reference to the currently active memory instance to perform exclusive read/write operations.	2019-11-26 21:55:39 -05:00
Lioncash	b05bfc6036	core/memory: Migrate over Read{8, 16, 32, 64, Block} to the Memory class ... With all of the trivial parts of the memory interface moved over, we can get right into moving over the bits that are used. Note that this does require the use of GetInstance from the global system instance to be used within hle_ipc.cpp and the gdbstub. This is fine for the time being, as they both already rely on the global system instance in other functions. These will be removed in a change directed at both of these respectively. For now, it's sufficient, as it still accomplishes the goal of de-globalizing the memory code.	2019-11-26 21:55:39 -05:00
Lioncash	89ef3ef575	core/memory: Migrate over ZeroBlock() and CopyBlock() to the Memory class ... These currently aren't used anywhere in the codebase, so these are very trivial to move over to the Memory class.	2019-11-26 21:55:38 -05:00
Lioncash	849581075a	core/memory: Migrate over RasterizerMarkRegionCached() to the Memory class ... This is only used within the accelerated rasterizer in two places, so this is also a very trivial migration.	2019-11-26 21:55:38 -05:00
Lioncash	b2165c6b35	core/memory: Migrate over ReadCString() to the Memory class ... This only had one usage spot, so this is fairly straightforward to convert over.	2019-11-26 21:55:38 -05:00
Lioncash	3f08e8d8d4	core/memory: Migrate over GetPointer() ... With all of the interfaces ready for migration, it's trivial to migrate over GetPointer().	2019-11-26 21:55:38 -05:00
Lioncash	536fc7f0ea	core: Prepare various classes for memory read/write migration ... Amends a few interfaces to be able to handle the migration over to the new Memory class by passing the class by reference as a function parameter where necessary. Notably, within the filesystem services, this eliminates two ReadBlock() calls by using the helper functions of HLERequestContext to do that for us.	2019-11-26 21:55:37 -05:00
Lioncash	fc7d0a17b6	core/memory: Move memory read/write implementation functions into an anonymous namespace ... These will eventually be migrated into the main Memory class, but for now, we put them in an anonymous namespace, so that the other functions that use them, can be migrated over separately.	2019-11-26 21:53:35 -05:00
Lioncash	e58748fd80	core/memory: Migrate over address checking functions to the new Memory class ... A fairly straightforward migration. These member functions can just be mostly moved verbatim with minor changes. We already have the necessary plumbing in places that they're used. IsKernelVirtualAddress() can remain a non-member function, since it doesn't rely on class state in any form.	2019-11-26 21:53:34 -05:00
Lioncash	323680e5ad	core/memory: Migrate over memory mapping functions to the new Memory class ... Migrates all of the direct mapping facilities over to the new memory class. In the process, this also obsoletes the need for memory_setup.h, so we can remove it entirely from the project.	2019-11-26 21:53:34 -05:00
Lioncash	4c2ed2706e	core/memory: Introduce skeleton of Memory class ... Currently, the main memory management code is one of the remaining places where we have global state. The next series of changes will aim to rectify this. This change simply introduces the main skeleton of the class that will contain all the necessary state.	2019-11-26 21:53:34 -05:00
bunnei	6df6caaf5f	Merge pull request #3143 from ReinUsesLisp/indexing-bug ... gl_device: Deduce indexing bug from device instead of heuristic	2019-11-26 21:53:12 -05:00
bunnei	ec0ce96c56	core_timing: Use better reference tracking for EventType. (#3159) ... * core_timing: Use better reference tracking for EventType. - Moves ownership of the event to the caller, ensuring we don't fire events for destroyed objects. - Removes need for unique names - we won't be using this for save states anyways.	2019-11-26 21:48:56 -05:00
bunnei	31daaa7911	Merge pull request #3164 from ReinUsesLisp/half-cast-float ... gl_shader_decompiler: Fix casts from fp32 to fp16	2019-11-26 09:11:23 -05:00
ReinUsesLisp	ef4446cb11	gl_shader_decompiler: Fix casts from fp32 to f16 ... Casts from f32 to f16 zeroes the higher half of the target register.	2019-11-25 22:22:33 -03:00
bunnei	f6b9b7910e	kernel: Fix reference management for client/server session. ... - Fixes shutdown crash and crash in Pokemon SwSh.	2019-11-25 18:17:49 -05:00
ReinUsesLisp	410d44ce05	gl_device: Deduce indexing bug from device instead of heuristic ... The heuristic to detect AMD's driver was not working properly since it also included Intel. Instead of using heuristics to detect it, compare the GL_VENDOR string.	2019-11-25 16:15:22 -03:00
bunnei	2899c93818	Merge pull request #3158 from ReinUsesLisp/srgb-blit ... gl_texture_cache: Apply sRGB on blits	2019-11-24 20:47:13 -05:00
bunnei	50c7539108	Merge pull request #3094 from lioncash/tables ... service: Update function tables	2019-11-24 20:30:58 -05:00
bunnei	33a6b45a6c	Merge pull request #3155 from bunnei/fix-asynch-gpu-wait ... gpu_thread: Don't spin wait if there are no GPU commands.	2019-11-24 20:19:25 -05:00
bunnei	9046d4a548	kernel: Replace usage of boost::intrusive_ptr with std::shared_ptr for kernel objects. (#3154) ... * kernel: Replace usage of boost::intrusive_ptr with std::shared_ptr for kernel objects. - See https://github.com/citra-emu/citra/pull/4710 for details.	2019-11-24 20:15:51 -05:00
bunnei	b03242067d	Merge pull request #3098 from ReinUsesLisp/shader-invalidations ... gl_shader_cache: Miscellaneous changes to shaders	2019-11-24 19:36:30 -05:00
ReinUsesLisp	74fff717aa	gl_texture_cache: Apply sRGB on blits ... glBlitFramebuffer keeps in mind GL_FRAMEBUFFER_SRGB's state. Enable this depending on the target surface pixel format.	2019-11-24 18:13:33 -03:00
bunnei	b7031b2b9d	Merge pull request #3105 from ReinUsesLisp/fix-stencil-reg ... maxwell_3d: Fix stencil_back_func_mask offset	2019-11-24 13:53:23 -05:00
bunnei	7298dcc016	Merge pull request #3156 from bunnei/sys-ticks ... svc: GetSystemTick should return cntpct_el0, not core ticks.	2019-11-24 13:52:28 -05:00
bunnei	ec8bfe94a7	Merge pull request #3153 from FearlessTobi/port-4964 ... Port citra-emu/citra#4964: "Unfold UNREACHABLE implementation for dumb compilers"	2019-11-24 02:56:12 -05:00
bunnei	e81e0036b4	Merge pull request #3145 from ReinUsesLisp/buffer-cache-init ... buffer_cache: Remove brace initialized for objects with default constructor	2019-11-24 02:55:02 -05:00
bunnei	63248f4edd	Update svc.cpp	2019-11-23 16:01:06 -05:00
bunnei	6eaf7ab55f	svc: GetSystemTick should return cntpct_el0, not core ticks.	2019-11-23 15:29:15 -05:00
bunnei	9ec84fc592	gpu_thread: Don't spin wait if there are no GPU commands.	2019-11-23 15:17:28 -05:00
bunnei	6a3fc5d2ff	Merge pull request #3114 from FernandoS27/cond-var ... Kernel: Correct behavior of Condition Variables to be more similar to real hardware.	2019-11-23 13:24:39 -05:00
bunnei	4ed183ee42	Merge pull request #3141 from ReinUsesLisp/gl-position ... gl_shader_gen: Apply default value to gl_Position	2019-11-23 13:23:46 -05:00
bunnei	6e4d46908a	Merge pull request #3130 from FernandoS27/cancel-sync ... Kernel: Correct Cancel Synchronization.	2019-11-23 13:23:23 -05:00
Weiyi Wang	49e0a30dbd	fix clang-format and lambda capture	2019-11-23 01:30:06 +01:00
Weiyi Wang	9a60d8a430	unfold UNREACHABLE implementation for dumb compilers ... We relies on UNREACHABLE's noreturn attribute to eliminate parent's "no return value" warning. However, this was wrapped in a `if(!false)` block, which compilers may not unfold to recognize the noreturn nature.	2019-11-23 01:30:06 +01:00
ReinUsesLisp	dc2e83fa31	gl_device: Reserve base bindings on limited devices ... SSBOs and other resources are limited per pipeline on Intel and AMD. Heuristically reserve resources per stage having in mind the reported OpenGL limits.	2019-11-22 21:28:50 -03:00
ReinUsesLisp	e3d7334be9	gl_state: Skip null texture binds ... glBindTextureUnit doesn't support null textures. Skip binding these.	2019-11-22 21:28:50 -03:00
ReinUsesLisp	919ac2c4d3	gl_rasterizer: Disable compute shaders on Intel ... Intel's proprietary driver enters in a corrupt state when compute shaders are executed. For now, disable these.	2019-11-22 21:28:50 -03:00
ReinUsesLisp	894ad74b87	gl_shader_cache: Hack shared memory size ... The current shared memory size seems to be smaller than what the game actually uses. This makes Nvidia's driver consistently blow up; in the case of FE3H it made it explode on Qt's SwapBuffers while SDL2 worked just fine. For now keep this hack since it's still progress over the previous hardcoded shared memory size.	2019-11-22 21:28:49 -03:00
ReinUsesLisp	e35b9597ef	gl_shader_decompiler: Normalize image bindings	2019-11-22 21:28:49 -03:00
ReinUsesLisp	36d9b409fc	gl_shader_decompiler: Normalize cbuf bindings ... Stage and compute shaders were using a different binding counter. Normalize these.	2019-11-22 21:28:49 -03:00
ReinUsesLisp	f936b86c7c	gl_rasterizer: Add missing cbuf counter reset on compute	2019-11-22 21:28:49 -03:00
ReinUsesLisp	180417c514	gl_shader_cache: Remove dynamic BaseBinding specialization	2019-11-22 21:28:49 -03:00
ReinUsesLisp	c8a48aacc0	video_core: Unify ProgramType and ShaderStage into ShaderType	2019-11-22 21:28:48 -03:00
ReinUsesLisp	0f23359a44	gl_rasterizer: Bind graphics images to draw commands ... Images were not being bound to draw invocations because these would require a cache invalidation.	2019-11-22 21:28:48 -03:00
ReinUsesLisp	287ae2b9e8	gl_shader_cache: Specialize local memory size for compute shaders ... Local memory size in compute shaders was stubbed with an arbitary size. This commit specializes local memory size from guest GPU parameters.	2019-11-22 21:28:48 -03:00
ReinUsesLisp	dbeb523879	gl_shader_cache: Specialize shared memory size ... Shared memory was being declared with an undefined size. Specialize from guest GPU parameters the compute shader's shared memory size.	2019-11-22 21:28:47 -03:00
ReinUsesLisp	4f5d8e4342	gl_shader_cache: Specialize shader workgroup ... Drop the usage of ARB_compute_variable_group_size and specialize compute shaders instead. This permits compute to run on AMD and Intel proprietary drivers.	2019-11-22 21:28:47 -03:00
ReinUsesLisp	dc9961f341	shader/texture: Handle TLDS texture type mismatches ... Some games like "Fire Emblem: Three Houses" bind 2D textures to offsets used by instructions of 1D textures. To handle the discrepancy this commit uses the the texture type from the binding and modifies the emitted code IR to build a valid backend expression. E.g.: Bound texture is 2D and instruction is 1D, the emitted IR samples a 2D texture in the coordinate ivec2(X, 0).	2019-11-22 21:28:47 -03:00
ReinUsesLisp	32c1bc6a67	shader/texture: Deduce texture buffers from locker ... Instead of specializing shaders to separate texture buffers from 1D textures, use the locker to deduce them while they are being decoded.	2019-11-22 21:28:47 -03:00
bunnei	bedc903c65	Merge pull request #3140 from FearlessTobi/port-4953 ... Port citra-emu/citra#4953: "citra_qt/main.ui: remove unused actions "Load Symbol Map..." and "Select Game Directory...""	2019-11-21 15:32:24 -05:00
bunnei	eedb048585	Merge pull request #3112 from lioncash/skip ... service/am: Remove unnecessary Skip calls	2019-11-21 15:30:01 -05:00
bunnei	d7953b8ee5	Merge pull request #3111 from lioncash/query ... am: Stub QueryApplicationPlayStatistics	2019-11-21 15:29:34 -05:00
Fernando Sahmkow	46bb609981	Kernel: Optimize condition variable threads management.	2019-11-21 11:13:29 -04:00
Fernando Sahmkow	2ab41ceff4	Kernel: Correct SignalProcessWideKey ... When the target is 0, all threads must be processed.	2019-11-21 10:46:55 -04:00
Fernando Sahmkow	2d16507f9f	Kernel: Correct behavior of Condition Variables to be more similar to real hardware. ... This commit ensures cond var threads act exactly as they do in the real console. The original implementation uses an RBTree and the behavior of cond var threads is that at the same priority level they act like a FIFO.	2019-11-21 10:46:55 -04:00
ReinUsesLisp	73aaf365e7	buffer_cache: Remove brace initialized for objects with default constructor	2019-11-20 16:00:40 -03:00
Fernando Sahmkow	cc81c0ce64	Texture_Cache: Redo invalid Surfaces handling. ... This commit aims to redo the full setup of invalid textures and guarantee correct behavior across backends in the case of finding one by using black dummy textures that match the target of the expected texture.	2019-11-20 14:59:35 -04:00
ReinUsesLisp	24f4198cee	shader/other: Reduce DEPBAR log severity ... While DEPBAR is stubbed it doesn't change anything from our end. Shading languages handle what this instruction does implicitly. We are not getting anything out fo this log except noise.	2019-11-19 21:26:40 -03:00
ReinUsesLisp	bc10714dcf	gl_shader_gen: Apply default value to gl_Position ... Nvidia has sane default output values for varyings, but the other vendors don't apply these. To properly emulate this we would have to analyze the shader header. For the time being, apply the same default Nvidia applies so we get the same behaviour on non-Nvidia drivers.	2019-11-19 20:32:01 -03:00
bunnei	b0819e2ffb	Merge pull request #3086 from ReinUsesLisp/format-lookups ... texture_cache: Use a flat table instead of switch for texture format lookups	2019-11-19 18:29:17 -05:00
Tobias	f9d7a6bec6	citra_qt/main.ui: remove unused actions "Load Symbol Map..." and... ... ..."Select Game Directory..." Co-authored-by: vvanelslande <vvanelslandedev@gmail.com>	2019-11-19 16:39:58 +01:00
Fernando Sahmkow	c8473f399e	Shader_IR: Address Feedback	2019-11-18 07:34:34 -04:00
Fernando Sahmkow	7d16b2d2dd	Kernel: Correct Cancel Synchronization. ... This commit corrects the behavior of cancel synchronization when the thread is running/ready and ensures the next wait is cancelled as it's suppose to.	2019-11-16 12:41:51 -04:00
ReinUsesLisp	2ac834c722	common/logging: Silence no return value warnings	2019-11-15 18:43:35 -03:00
bunnei	a8295d2c53	Merge pull request #3047 from ReinUsesLisp/clip-control ... gl_rasterizer: Emulate viewport flipping with ARB_clip_control	2019-11-15 12:09:19 -05:00
bunnei	3e0e4f146b	Merge pull request #3091 from lioncash/core-conversion ... core: Make most implicit type conversion warnings errors on MSVC	2019-11-15 12:08:50 -05:00
ReinUsesLisp	4681381a34	format_lookup_table: Address feedback ... format_lookup_table: Drop bitfields format_lookup_table: Use std::array for definition table format_lookup_table: Include <limits> instead of <numeric>	2019-11-14 20:57:30 -03:00
ReinUsesLisp	80eacdf89b	texture_cache: Use a table instead of switch for texture formats ... Use a large flat array to look up texture formats. This allows us to properly implement formats with different component types. It should also be faster.	2019-11-14 20:57:10 -03:00
Rodrigo Locatti	bb31df62bb	Merge pull request #3113 from lioncash/semi ... common_funcs: Remove semicolons from INSERT_PADDING_* macros	2019-11-14 20:29:51 -03:00
Lioncash	f2e34efcbb	common_funcs: Remove semicolons from INSERT_PADDING_* macros ... Makes code that uses the macros consistent by requiring the lines to be terminated with a semicolon.	2019-11-14 17:05:27 -05:00
Lioncash	2c4c2b5eee	service/am: Remove unnecessary Skip calls ... We can simplify these by wrapping the necessary members in structs and then simply reading out the whole struct.	2019-11-14 16:31:52 -05:00
ReinUsesLisp	48a1687f51	texture_cache: Drop abstracted ComponentType ... Abstracted ComponentType was not being used in a meaningful way. This commit drops its usage. There is one place where it was being used to test compatibility between two cached surfaces, but this one is implied in the pixel format. Removing the component type test doesn't change the behaviour.	2019-11-14 18:21:42 -03:00
Lioncash	1cd8637bf0	am: Stub QueryApplicationPlayStatistics ... Maintains implementation parity between QueryApplicationPlayStatistics and QueryApplicationPlayStatisticsByUid. These function the same behaviorally underneath the hood, with the only difference being that one allows specifying a UID.	2019-11-14 16:02:39 -05:00
greggameplayer	c6bc13d0aa	correct the implementation of RGBA16UI	2019-11-14 21:37:39 +01:00
bunnei	885d88825e	Merge pull request #3089 from SciresM/play_statistics ... Implement stub for IApplicationFunctions::QueryApplicationPlayStatisticsByUid	2019-11-14 13:54:29 -05:00
bunnei	360b0d1b30	Merge pull request #3093 from lioncash/mbedtls ... core: Migrate off deprecated mbedtls functions	2019-11-14 13:47:23 -05:00
bunnei	02880a8195	Merge pull request #3092 from lioncash/util ... key_manager: Make use of IOFile in WriteKeyToFile()	2019-11-14 13:46:55 -05:00
Fernando Sahmkow	cd0f5dfc17	Shader_IR: Implement TXD instruction.	2019-11-14 11:15:27 -04:00
Fernando Sahmkow	f3d1b370aa	Shader_IR: Implement FLO instruction.	2019-11-14 11:15:27 -04:00
Fernando Sahmkow	95137a04e1	Shader_Bytecode: Add encodings for FLO, SHF and TXD	2019-11-14 11:15:26 -04:00
Fernando Sahmkow	b6f6733131	Merge pull request #3081 from ReinUsesLisp/fswzadd-shuffles ... shader: Implement FSWZADD and reimplement SHFL	2019-11-14 10:27:27 -04:00
Rodrigo Locatti	7f424d0f60	Merge pull request #3107 from lioncash/hashable ... common/hash: Remove unused HashableStruct	2019-11-13 17:30:30 -03:00
Rodrigo Locatti	ebb30cbefb	Merge pull request #3104 from lioncash/xts ... xts_archive: Remove redundant std::string constructor	2019-11-13 17:00:02 -03:00
Lioncash	c5c89a4d5c	common/hash: Remove unused HashableStruct ... This is unused, so it can be removed. There's better ways of ensuring zeroed out padding bits, like using zero-initialization, anyhow.	2019-11-13 14:58:43 -05:00
ReinUsesLisp	7990220df7	maxwell_3d: Fix stencil_back_func_mask offset ... stencil_back_func_mask and stencil_back_mask were misplaced. This commit addresses that issue.	2019-11-13 16:35:17 -03:00
Rodrigo Locatti	cc9e682021	Merge pull request #3103 from lioncash/cfunc ... common_funcs: silence sign-conversion warnings in MakeMagic()	2019-11-13 16:26:34 -03:00
Lioncash	03b73aa575	xts_archive: Remove redundant std::string constructor ... We can just call the .data() member of path instead of constructing a completely new string.	2019-11-13 10:02:10 -05:00
Lioncash	61f6eaad45	common_funcs: silence sign-conversion warnings in MakeMagic() ... We can trivially resolve these by casting the characters to unsigned values and then shifting the bits.	2019-11-13 06:53:19 -05:00
Rodrigo Locatti	cf770a68a5	Merge pull request #3084 from ReinUsesLisp/cast-warnings ... video_core: Treat implicit conversions as errors	2019-11-13 02:16:22 -03:00
Lioncash	e21b6ff79d	service: Update function tables ... Keeps the function tables up to date. Updated based off information from Switchbrew.	2019-11-12 10:32:56 -05:00
Lioncash	64cbebc58f	key_manager: Make use of IOFile in WriteKeyToFile() ... This properly handles unicode-based paths on Windows, while opening a raw stream doesn't out-of-the-box. Prevents file creation from potentially failing on Windows PCs that make use of unicode characters in their save paths (e.g. writing to a user's AppData folder, where the user has a name with non-ASCII characters).	2019-11-12 08:52:18 -05:00
Lioncash	e0c46e6879	core: Migrate off deprecated mbedtls functions ... These functions are marked for deprecation and it's recommended that the *_ret variants be used instead.	2019-11-12 08:45:56 -05:00
Lioncash	47a6bb2d5b	externals: Update httplib ... Since the introduction of this library, numerous improvements have been made. Notably, many of the warnings we would get by simply including the library header have now been fixed. This makes it much easier to make conversion warning an error.	2019-11-12 08:31:27 -05:00
Lioncash	f11b87ebf1	service: Resolve sign conversion errors ... These are fairly trivial to resolve and most of the changes entail using RESULT_UNKNOWN over ResultCode(-1).	2019-11-12 07:55:39 -05:00
Lioncash	75dec14f21	perf_stats: Resolve implicit int to double conversion error ... We simply need to turn the literal argument to std::accumulate into a double, rather than an int.	2019-11-12 07:55:39 -05:00
Lioncash	23878bf360	loader; Resolve sign conversion/truncation errors	2019-11-12 07:55:39 -05:00
Lioncash	86a1eb7789	gdbstub: Resolve sign conversion errors	2019-11-12 07:55:39 -05:00
Lioncash	12dc918937	kernel: Resolve sign conversion warnings ... Uncovered a bug within Thread's SetCoreAndAffinityMask() where an unsigned variable (ideal_core) was being compared against "< 0", which would always be a false condition. We can also get rid of an unused function (GetNextProcessorId) which contained a sign mismatch warning.	2019-11-12 07:55:39 -05:00
Lioncash	86c397dd6e	file_sys: Resolve sign conversion warnings ... Resolves a few trivial sign conversion/mismatch errors.	2019-11-12 07:55:39 -05:00
Lioncash	ef060ed40c	result: Add default error code for the ResultCode(-1) case ... Will be used to reduce the overall duplication of the same magic value all over the codebase in following changes.	2019-11-12 07:55:38 -05:00
Lioncash	581d2e36e5	crypto: Resolve sign-conversion warnings	2019-11-12 07:55:22 -05:00
Lioncash	27ab99490e	result: Resolve sign-coversion warnings ... The constructor was implicitly using signed->unsigned conversions to produce 0xFFFFFFFF. We can just specify this explicitly with UINT32_MAX.	2019-11-12 07:06:48 -05:00
Lioncash	19a0abc19b	arm_unicorn: Resolve sign conversion warnings ... While we're at it, this also resolves a type truncation warning as well, given the code was truncating from a 64-bit value to a 32-bit one.	2019-11-12 07:06:48 -05:00
Lioncash	96d677bef0	CMakeLists: Make most implicit type conversion warnings errors on MSVC ... Quite frequently there have been cases where code has been merged into the core that produces warning. In order to prevent this from occurring, we can make the compiler flag these cases and allow our CI to flag down any code that would generate these warnings. This is beneficial given silent conversions from signed/unsigned can result in logic bugs. This forces one writing changes to be explicit about when signedness conversions are desirable, rather than leaving it up to readers' interpretation. Currently the codebase isn't in a state where it will build successfully with this change applied, but this will be addressed in subsequent follow-up changes. This set of changes will focus on making it build properly with these changes for MSVC as a starting point for basic coverage.	2019-11-12 07:06:25 -05:00
Rodrigo Locatti	fb9418798d	video_core: Enable sign conversion warnings ... Enable sign conversion warnings but don't treat them as errors.	2019-11-11 18:00:37 -03:00
Michael Scire	b0b0786493	Implement stub for QueryApplicationPlayStatisticsByUid	2019-11-11 07:32:47 -08:00
bunnei	8714d40a77	Merge pull request #3085 from bunnei/web-token-b64 ... yuzu: configure_web: Use Base64 encoded token	2019-11-09 14:50:31 -05:00
bunnei	8dc9f35baf	web-service: Port citra's updated web_backend code.	2019-11-09 14:00:44 -05:00
bunnei	883eb1a1a1	yuzu: configure_web: Use Base64 encoded token for simplifying user experience.	2019-11-09 14:00:44 -05:00
bunnei	0fc596de6e	Merge pull request #3082 from ReinUsesLisp/fix-lockers ... gl_shader_cache: Fix locker constructors	2019-11-09 13:58:36 -05:00
ReinUsesLisp	18c1cb68fd	video_core: Treat implicit conversions as errors	2019-11-08 22:49:39 +00:00
ReinUsesLisp	096f339a2a	video_core: Silence implicit conversion warnings	2019-11-08 22:48:50 +00:00
bunnei	a056d8de16	Merge pull request #3080 from FernandoS27/glsl-fix ... GLSLDecompiler: Correct Texture Gather Offset.	2019-11-08 15:56:29 -05:00
ReinUsesLisp	bfa973a62b	gl_shader_cache: Fix locker constructors ... Properly pass engine when a shader is being constructed from memory.	2019-11-07 20:43:31 -03:00
ReinUsesLisp	3ab0514698	gl_shader_cache: Enable extensions only when available ... Silence GLSL compilation warnings.	2019-11-07 20:08:42 -03:00
ReinUsesLisp	cd66395944	gl_shader_decompiler: Add safe fallbacks when ARB_shader_ballot is not available	2019-11-07 20:08:42 -03:00
ReinUsesLisp	56e237d1f9	shader_ir/warp: Implement FSWZADD	2019-11-07 20:08:41 -03:00
ReinUsesLisp	08b2b1080a	gl_shader_decompiler: Reimplement shuffles with platform agnostic intrinsics	2019-11-07 20:08:41 -03:00
Fernando Sahmkow	3d7c284e0f	GLSLDecompiler: Correct Texture Gather Offset. ... This commit corrects the argument ordering in textureGatherOffset.	2019-11-07 11:43:56 -04:00
bunnei	b6ae48966d	Merge pull request #3032 from ReinUsesLisp/simplify-control-flow-brx ... shader/control_flow: Abstract repeated code chunks in BRX tracking	2019-11-07 01:30:01 -05:00
Morph	0e8a3bf3e5	buffer_cache: Add missing includes (#3079) ... `boost::make_iterator_range` is available when `boost/range/iterator_range.hpp` is included. Also include `boost/icl/interval_map.hpp` and `boost/icl/interval_set.hpp`.	2019-11-07 06:25:53 +00:00
bunnei	344d15f61e	Merge pull request #3070 from ReinUsesLisp/shader-warnings ... shader_ir: Reduce severity of warnings	2019-11-07 00:47:24 -05:00
ReinUsesLisp	e9d2fad984	gl_rasterizer: Remove front facing hack	2019-11-07 01:52:18 -03:00
ReinUsesLisp	f1facaeaef	gl_shader_decompiler: Fix typo "y_negate"->"y_direction"	2019-11-07 01:52:18 -03:00
ReinUsesLisp	e2ea0c3e11	gl_shader_manager: Remove unused variable in SetFromRegs	2019-11-07 01:52:18 -03:00
ReinUsesLisp	028b1a34a9	yuzu_cmd: Use string_view instead of string for extensions ... Avoids potential allocations due to the usage of std::string on strings that we know at compile time. Most of these might fit in SSO, but it adds complexity that can be easily avoided with string views.	2019-11-07 01:52:18 -03:00
ReinUsesLisp	f019817f8f	gl_rasterizer: Emulate viewport flipping with ARB_clip_control ... Emulates negative y viewports with ARB_clip_control. This allows us to more easily emulated pipelines with tessellation and/or geometry shader stages. It also avoids corrupting games with transform feedbacks and negative viewports (gl_Position.y was being modified).	2019-11-07 01:52:18 -03:00
Rodrigo Locatti	ff5a0f370c	shader/control_flow: Specify constness on caller lambdas ... Update src/video_core/shader/control_flow.cpp Co-Authored-By: Mat M. <mathew1800@gmail.com> Update src/video_core/shader/control_flow.cpp Co-Authored-By: Mat M. <mathew1800@gmail.com> Update src/video_core/shader/control_flow.cpp Co-Authored-By: Mat M. <mathew1800@gmail.com> Update src/video_core/shader/control_flow.cpp Co-Authored-By: Mat M. <mathew1800@gmail.com> Update src/video_core/shader/control_flow.cpp Co-Authored-By: Mat M. <mathew1800@gmail.com> Update src/video_core/shader/control_flow.cpp Co-Authored-By: Mat M. <mathew1800@gmail.com>	2019-11-07 01:44:09 -03:00
ReinUsesLisp	7b069252f8	shader/control_flow: Use callable template instead of std::function	2019-11-07 01:44:08 -03:00
ReinUsesLisp	46c3047283	shader/control_flow: Abstract repeated code chunks in BRX tracking ... Remove copied and pasted for cycles into a common templated function.	2019-11-07 01:44:08 -03:00
ReinUsesLisp	ae7dfa93be	shader/control_flow: Silence Intellisense cast warnings	2019-11-07 01:44:08 -03:00
ReinUsesLisp	deb1b54eed	shader/control_flow: Remove brace initializer in std containers ... These containers have a default constructor.	2019-11-07 01:44:08 -03:00
ReinUsesLisp	39c66abd91	shader/decode: Reduce severity of arithmetic rounding warnings	2019-11-07 01:43:38 -03:00
ReinUsesLisp	c4374d0d41	shader/arithmetic: Reduce RRO stub severity	2019-11-07 01:43:38 -03:00
ReinUsesLisp	35d40b74b3	shader/texture: Remove NODEP warnings ... These warnings don't offer meaningful information while decoding shaders. Remove them.	2019-11-07 01:43:38 -03:00
Fernando Sahmkow	3c95e49c42	nifm: Only return that there's an internet connection when there's a BCATServer ... This helps games that need internet for other purposes boot as the rest of our internet infrastructure is incomplete.	2019-11-06 23:10:32 -05:00
bunnei	468576284d	Merge pull request #3057 from ReinUsesLisp/buffer-sub-data ... gl_rasterizer: Upload constant buffers with glNamedBufferSubData	2019-11-06 10:08:55 -05:00
bunnei	4d66ca97e5	Merge pull request #3076 from DarkLordZach/telem-names ... ci: Populate build repository from Azure environment	2019-11-06 10:08:27 -05:00
bunnei	c1a3d19897	Merge pull request #3062 from bunnei/event-improve ... kernel: Improve events	2019-11-06 10:05:50 -05:00
Rodrigo Locatti	654b77d2ec	Merge pull request #3039 from ReinUsesLisp/cleanup-samplers ... shader/node: Unpack bindless texture encoding	2019-11-06 04:54:11 +00:00
Zach Hilman	0c8b6b0351	ci: Populate build repository from Azure environment	2019-11-05 21:37:27 -05:00
David	0e34f648f4	Merge pull request #2859 from Morph1984/hid ... hid: Stub SetNpadJoyAssignmentModeSingle and GetNpadHandheldActivationMode	2019-11-06 12:48:07 +11:00
bunnei	21e07df7b7	Merge pull request #2914 from FernandoS27/fermi-fix ... Fermi2D: limit blit area to only available area	2019-11-05 20:45:24 -05:00
bunnei	1bdae0fe29	common_func: Use std::array for INSERT_PADDING_* macros. ... - Zero initialization here is useful for determinism.	2019-11-03 22:22:41 -05:00
bunnei	ae6eb61892	Merge pull request #3059 from FearlessTobi/stub-am-commands ... core/am: Stub InitializeApplicationCopyrightFrameBuffer, SetApplicationCopyrightImage and SetApplicationCopyrightVisibility	2019-11-03 05:26:33 -05:00
bunnei	ece5287843	kernel: readable_event: Signal only once.	2019-11-03 04:25:41 -05:00
bunnei	b0ab803ce8	kernel: events: Remove ResetType::Automatic. ... - This does not actually seem to exist in the real kernel - games reset these automatically. # Conflicts: # src/core/hle/service/am/applets/applets.cpp # src/core/hle/service/filesystem/fsp_srv.cpp	2019-11-03 04:22:45 -05:00
bunnei	28bb248db6	kernel: readable_event: Initialize members.	2019-11-03 04:18:39 -05:00
Tobias	a81987a7cb	common/bit_field: Remove FORCE_INLINE calls ... See bunneis comment here https://github.com/citra-emu/citra/pull/4629#discussion_r258533167. They were supposed to be removed by him, but he missed them.	2019-11-03 08:25:37 +01:00
FearlessTobi	832c138eff	core/am: Stub InitializeApplicationCopyrightFrameBuffer, SetApplicationCopyrightImage and SetApplicationCopyrightVisibility ... These commands require Screenshots to be implemented anyway, so they are safe to stub for now.	2019-11-03 07:37:38 +01:00
FearlessTobi	727ba2f2d0	citra_qt: add amiibo drag and drop support ... Co-Authored-By: Valentin Vanelslande <vvanelslandedev@gmail.com>	2019-11-03 05:24:47 +01:00
ReinUsesLisp	442a1cc021	gl_rasterizer: Re-enable stream buffer memory due to global memory ... Global memory is still using the stream buffer when it shouldn't. As a temporary fix re-enable the stream buffer on compute.	2019-11-02 13:19:19 -03:00
ReinUsesLisp	76ca2a5f82	gl_rasterizer: Upload constant buffers with glNamedBufferSubData ... Nvidia's OpenGL driver maps gl(Named)BufferSubData with some requirements to a fast. This path has an extra memcpy but updates the buffer without orphaning or waiting for previous calls. It can be seen as a better model for "push constants" that can upload a whole UBO instead of 256 bytes. This path has some requirements established here: http://on-demand.gputechconf.com/gtc/2014/presentations/S4379-opengl-44-scene-rendering-techniques.pdf#page=24 Instead of using the stream buffer, this commits moves constant buffers uploads to calls of glNamedBufferSubData and from my testing it brings a performance improvement. This is disabled when the vendor is not Nvidia since it brings performance regressions.	2019-11-02 05:05:34 -03:00
Fernando Sahmkow	23cabc98db	Shader_IR: Fix regression on TLD4 ... Originally on the last commit I thought TLD4 acted the same as TLD4S and didn't have a mask. It actually does have a component mask. This commit corrects that.	2019-10-30 21:14:57 -04:00
Rodrigo Locatti	658489ebf7	Merge pull request #3050 from FernandoS27/fix-tld4 ... shader_ir: Fix TLD4 and add bindless variant	2019-10-30 18:37:17 +00:00
Fernando Sahmkow	9293c3a0f2	Shader_IR: Fix TLD4 and add Bindless Variant. ... This commit fixes an issue where not all 4 results of tld4 were being written, the color component was defaulted to red, among other things. It also implements the bindless variant.	2019-10-30 12:02:03 -04:00
Rodrigo Locatti	04b838c857	Merge pull request #3038 from lioncash/docs ... kernel/scheduler: Minor changes	2019-10-30 03:47:28 +00:00
bunnei	2382bbe3ac	Merge pull request #3046 from ReinUsesLisp/clean-gl-state ... gl_state: Miscellaneous clean up	2019-10-29 22:50:04 -04:00
bunnei	b5138f3c35	Merge pull request #3035 from ReinUsesLisp/rasterizer-accelerated ... rasterizer_accelerated: Add intermediary for GPU rasterizers	2019-10-29 22:06:41 -04:00
bunnei	a81bd962ab	Merge pull request #3007 from DarkLordZach/fsc-regress ... savedata_factory: Automatically create certain savedata	2019-10-29 22:05:09 -04:00
Rodrigo Locatti	3d0cde6a75	gl_state: Use std::array::fill instead of std::fill ... Co-Authored-By: Mat M. <mathew1800@gmail.com>	2019-10-30 01:30:31 +00:00
ReinUsesLisp	ce20ed8e4e	gl_state: Move dirty checks to individual apply calls instead of Apply ... This requires removing constness from some methods, but for consistency it's removed in all methods.	2019-10-29 21:27:25 -03:00
ReinUsesLisp	3c6557c235	gl_state: Remove ApplyDefaultState ... OpenGL has defaults values we can trust. Remove these.	2019-10-29 21:27:25 -03:00
ReinUsesLisp	d3651b0b82	gl_state: Change SetDefaultViewports to use default constructor	2019-10-29 21:27:24 -03:00
ReinUsesLisp	c7698d0bc8	gl_state: Minor style changes	2019-10-29 21:27:24 -03:00
ReinUsesLisp	a14d202ac2	gl_state: Remove unused Citra TextureUnits	2019-10-29 21:27:24 -03:00
ReinUsesLisp	28fece8e9b	gl_state: Move initializers from constructor to class declaration	2019-10-29 21:27:23 -03:00
ReinUsesLisp	a993df1ee2	shader/node: Unpack bindless texture encoding ... Bindless textures were using u64 to pack the buffer and offset from where they come from. Drop this in favor of separated entries in the struct. Remove the usage of std::set in favor of std::list (it's not std::vector to avoid reference invalidations) for samplers and images.	2019-10-29 20:53:48 -03:00
Rodrigo Locatti	2ec5b55ee3	Merge pull request #3004 from ReinUsesLisp/maxwell3d-cleanup ... maxwell_3d: Remove unused entries	2019-10-29 23:46:33 +00:00
Rodrigo Locatti	c5d9589942	Merge pull request #3037 from FernandoS27/new-formats ... video_core: Implement texture format E5B9G9R9_SHAREDEXP.	2019-10-28 01:36:58 -03:00
Lioncash	6c8f28813c	scheduler: Mark parameter of AskForReselectionOrMarkRedundant() as const ... This is only compared against, so it can be made const.	2019-10-27 23:35:50 -04:00
ReinUsesLisp	fa31e5b868	maxwell_3d/kepler_compute: Remove unused arguments in GetTexture	2019-10-28 00:23:42 -03:00
ReinUsesLisp	538ddd220e	video_core/textures: Remove unused index entry in FullTextureInfo	2019-10-28 00:14:38 -03:00
ReinUsesLisp	961fe4d19b	maxwell_3d: Remove unused method GetStageTextures	2019-10-28 00:14:29 -03:00
Lioncash	f19c1a7cda	scheduler: Silence sign conversion warnings	2019-10-27 22:44:52 -04:00
Lioncash	2fb0bbff29	scheduler: Initialize class members directly where applicable ... Reduces the overall amount of code.	2019-10-27 22:13:55 -04:00
Lioncash	2dc469ceba	scheduler: Amend documentation comments ... Adjusts the formatting of a few of the comments an ensures they get recognized as proper Doxygen comments.	2019-10-27 22:12:32 -04:00
David	4c5731c34f	Merge pull request #2971 from FernandoS27/new-scheduler-v2 ... Kernel: Implement a New Thread Scheduler V2	2019-10-28 10:53:27 +11:00
Fernando Sahmkow	3f9262195b	Video_Core: Implement texture format E5B9G9R9_SHAREDEXP. ... This commit implements the E5B9G9R9 Texture format into the general system and OpenGL backend.	2019-10-27 16:44:09 -04:00
bunnei	6909b2f0f9	Merge pull request #3034 from ReinUsesLisp/w4244-maxwell3d ... maxwell_3d: Silence implicit conversion warnings	2019-10-27 15:08:59 -04:00
ReinUsesLisp	3e469cecc1	maxwell_3d: Silence implicit conversion warnings ... While we are at it, unify types for dirty reg pointers.	2019-10-27 15:22:17 -03:00
ReinUsesLisp	bd2aff3e26	rasterizer_accelerated: Add intermediary for GPU rasterizers ... Add an intermediary class that implements common functions across GPU accelerated rasterizers. This avoids code repetition on different backends.	2019-10-27 03:40:08 -03:00
ReinUsesLisp	a5aa1bb174	astc: Silence implicit conversion warnings	2019-10-27 03:04:50 -03:00
Rodrigo Locatti	26f3e18c5c	Merge pull request #2976 from FernandoS27/cache-fast-brx-rebased ... Implement Fast BRX, fix TXQ and addapt the Shader Cache for it	2019-10-26 16:56:13 -03:00
Fernando Sahmkow	be856a38d6	Shader_IR: Address Feedback.	2019-10-26 15:38:30 -04:00
Rodrigo Locatti	a0d79085c4	Merge pull request #3027 from lioncash/lookup ... shader_ir: Use std::array with std::pair instead of std::unordered_map	2019-10-26 05:49:15 -03:00
Rodrigo Locatti	d52598173d	Merge pull request #3013 from FernandoS27/tld4s-fix ... Shader_Ir: Fix TLD4S from using a component mask.	2019-10-25 20:06:26 -03:00
Fernando Sahmkow	e3afd6595a	Shader_IR: Clang format	2019-10-25 09:01:32 -04:00
ReinUsesLisp	78f3e8a757	gl_shader_cache: Implement locker variants invalidation	2019-10-25 09:01:32 -04:00
ReinUsesLisp	ec85648af3	gl_shader_disk_cache: Store and load fast BRX	2019-10-25 09:01:31 -04:00
ReinUsesLisp	fa2c297f3e	const_buffer_locker: Minor style changes	2019-10-25 09:01:31 -04:00
ReinUsesLisp	7b81ba4d8a	gl_shader_decompiler: Move entries to a separate function	2019-10-25 09:01:31 -04:00
Fernando Sahmkow	1244f2d368	Shader_IR: Implement Fast BRX and allow multi-branches in the CFG.	2019-10-25 09:01:31 -04:00
Fernando Sahmkow	a05120ec0b	Shader_IR: Correct typo in Consistent method.	2019-10-25 09:01:30 -04:00
Fernando Sahmkow	33fcec3502	Shader_IR: allow lookup of texture samplers within the shader_ir for instructions that don't provide it	2019-10-25 09:01:30 -04:00
Fernando Sahmkow	8909f52166	Shader_IR: Implement Fast BRX and allow multi-branches in the CFG.	2019-10-25 09:01:30 -04:00
Fernando Sahmkow	acd6441134	Shader_Cache: setup connection of ConstBufferLocker	2019-10-25 09:01:29 -04:00
Fernando Sahmkow	1a58f45d76	VideoCore: Unify const buffer accessing along engines and provide ConstBufferLocker class to shaders.	2019-10-25 09:01:29 -04:00
Fernando Sahmkow	2ef696c85a	Shader_IR: Implement BRX tracking.	2019-10-25 09:01:29 -04:00
Rodrigo Locatti	5062728669	Merge pull request #3028 from lioncash/constexpr ... shader_bytecode: Make Matcher constexpr capable	2019-10-24 15:10:40 -03:00
Lioncash	7fdf991097	shader_bytecode: Make Matcher constexpr capable ... Greatly shrinks the amount of generated code for GetDecodeTable(). Collapses an assembly output of 9000+ lines down to ~3621 with Clang, and 6513 down to ~2616 with GCC, given it's now allowed to construct all the entries as a sequence of constant data.	2019-10-24 01:10:10 -04:00
Lioncash	382717172e	shader_ir: Use std::array with pair instead of unordered_map ... Given the overall size of the maps are very small, we can use arrays of pairs here instead of always heap allocating a new map every time the functions are called. Given the small size of the maps, the difference in container lookups are negligible, especially given the entries are already sorted.	2019-10-24 00:25:38 -04:00
Lioncash	1f5401c89c	video_core/shader: Resolve instances of variable shadowing ... Silences a few -Wshadow warnings.	2019-10-23 23:00:31 -04:00
bunnei	6fe89acf0d	Merge pull request #2991 from lioncash/npad ... hid/npad: Minor cleanup	2019-10-22 19:51:24 -04:00
Zach Hilman	bb207fe27a	savedata_factory: Automatically create certain savedata ... After further hardware investigation, it appears that some games, perhaps those more lazily coded, will not call EnsureSaveData, meaning that they expect the normal (current) save to be automatically made. Additionally, some games do not create a cache or temporary save before use. In these 3 specific instances, the save is created automatically for the game if it doesn't exist.	2019-10-22 15:47:38 -04:00
Fernando Sahmkow	c4a0aa9207	Merge pull request #2995 from ReinUsesLisp/ignore-gmem ... shader_ir/memory: Ignore global memory when tracking fails	2019-10-22 13:22:43 -04:00
Fernando Sahmkow	7ecf9f7228	Merge pull request #2983 from lioncash/fallthrough ... gl_shader_decompiler/vk_shader_decompiler: Resolve implicit fallthrough cases	2019-10-22 13:16:46 -04:00
Fernando Sahmkow	1509d2ffbd	Shader_Ir: Fix TLD4S from using a component mask. ... TLD4S always outputs 4 values, the previous code checked a component mask and omitted those values that weren't part of it. This commit corrects that and makes sure all 4 values are set.	2019-10-22 10:59:07 -04:00
ReinUsesLisp	1ea07954fb	shader_ir/memory: Ignore global memory when tracking fails ... Ignore global memory operations instead of invoking undefined behaviour when constant buffer tracking fails and we are blasting through asserts, ignore the operation. In the case of LDG this means filling the destination registers with zeroes; for STG this means ignore the instruction as a whole. The default behaviour is still to abort execution on failure.	2019-10-22 02:49:17 -03:00
ReinUsesLisp	e3107788e6	maxwell_3d: Reduce FlushMMEInlineDraw logging to Trace	2019-10-20 03:43:17 -03:00
bunnei	a86a88109a	core: Fix clang-format errors.	2019-10-19 14:47:18 -04:00
Nicolae-Andrei Cociorba	20521da259	Fix null pointer deref.	2019-10-18 14:12:12 +00:00
Rodrigo Locatti	dc5eedef71	Merge pull request #2994 from lioncash/fmt ... video_core/shader/ast: Minor changes to ASTPrinter	2019-10-18 01:05:25 -03:00
Lioncash	074b38b7a9	video_core/shader/ast: Make ShowCurrentState() and SanityCheck() const member functions ... These can also trivially be made const member functions, with the addition of a few consts.	2019-10-17 20:59:48 -04:00
Lioncash	222f4b45eb	video_core/shader/ast: Make ASTManager::Print a const member function ... Given all visiting functions never modify the nodes, we can trivially make this a const member function.	2019-10-17 20:56:39 -04:00
Rodrigo Locatti	fd922ddb01	Merge pull request #2993 from lioncash/vulkan-expr ... vk_shader_decompiler: Mark operator() function parameters as const references	2019-10-17 21:46:49 -03:00
Lioncash	7831e86c34	video_core/shader/ast: Make ExprPrinter members private ... This member already has an accessor, so there's no need for it to be public.	2019-10-17 20:39:36 -04:00
Lioncash	a2eccbf075	video_core/shader/ast: Make Indent() return a string_view ... The returned string is simply a substring of our constexpr tabs string_view, so we can just use a string_view here as well, since the original string_view is guaranteed to always exist. Now the function is fully non-allocating.	2019-10-17 20:29:00 -04:00
Lioncash	15d177a6ac	video_core/shader/ast: Make Indent() private ... It's never used outside of this class, so we can narrow its scope down.	2019-10-17 20:26:13 -04:00
Lioncash	7f6a8a33d4	video_core/shader/ast: Rename Ident() to Indent() ... This can be confusing, given "ident" is generally used as a shorthand for "identifier".	2019-10-17 20:26:13 -04:00
Lioncash	081530686c	video_core/shader/ast: Make use of fmt where applicable ... Makes a few strings nicer to read and also eliminates a bit of string churn with operator+.	2019-10-17 20:26:10 -04:00
bunnei	d1713ad451	Merge pull request #2992 from lioncash/dmnt ... dmnt_cheat_vm: Correct register Restore and ClearRegs behavior	2019-10-17 19:52:24 -04:00
Lioncash	c6bec9aa10	vk_shader_decompiler: Mark operator() function parameters as const references ... These parameters aren't actually modified in any way, so they can be made const references.	2019-10-17 19:44:00 -04:00
Lioncash	2c34d8aabb	dmnt_cheat_vm: Correct register Restore and ClearRegs behavior ... Previously these were performing the same behavior as the Save and ClearSaved opcode types.	2019-10-17 18:49:39 -04:00
Rodrigo Locatti	219fdcb9d9	Merge pull request #2966 from FernandoS27/astc-formats ... Implement a series of ASTC formats and R4G4B4A4 format	2019-10-17 19:24:11 -03:00
Rodrigo Locatti	a21b88ef8f	Merge pull request #2979 from lioncash/macro ... video_core/macro_interpreter: Make definitions of most private enums/unions hidden	2019-10-17 19:21:09 -03:00
Fernando Sahmkow	c0eb1aecfd	Fermi2D: Use a different formula for delimiting blit areas.	2019-10-17 18:21:01 -04:00
Rodrigo Locatti	7cf091bb20	Merge pull request #2989 from lioncash/apm ... service/apm/controller: Minor interface changes	2019-10-17 19:20:14 -03:00
Lioncash	8d8e495248	hid/npad: Fix incorrect connection boolean value in ConnectAllDisconnectedControllers() ... We should be setting the connection state to true, otherwise we aren't actually making the controllers connected like the function name indicates.	2019-10-17 18:19:47 -04:00
Lioncash	d076466f26	hid/npad: Add missing break in default case ... While not an issue, it does prevent fallthrough from occurring if anything is ever added after this case (unlikely to occur, but this turns a trivial "should not cause issues" into a definite "won't cause issues).	2019-10-17 18:17:42 -04:00
Lioncash	26c84718c8	hid/npad: Replace std::for_each with ranged for loops ... Performs the same behavior, but is built into the core language itself. No functional change.	2019-10-17 18:16:36 -04:00
Lioncash	e433e99191	hid/npad: Remove redundant non-const variant of IsControllerSupported() ... The const qualified variant can also be called in non-const contexts, so we can remove the non-const variant to eliminate a bit of code duplication.	2019-10-17 18:11:41 -04:00
Lioncash	a71e8066a1	hid/npad: Move function declarations ... Clearly separate these from the variable declarations to make them more visible.	2019-10-17 18:09:08 -04:00
Lioncash	125caf5d6e	video_core/macro_interpreter: Make definitions of most private enums/unions hidden ... This allows the implementation of these types to change without requiring a rebuild of everything that includes the macro interpreter header.	2019-10-17 17:55:46 -04:00
Lioncash	98c6a95079	core/core: Resolve -Wreorder warnings ... Amends the initializer lists to be ordered in the same manner that they're declared within the class.	2019-10-17 17:51:06 -04:00
Lioncash	6414d9e2e5	core/memory/cheat_engine: Resolve -Wreorder warnings ... Amends the initializer lists to be ordered in the same manner that they're declared within the class.	2019-10-17 16:21:47 -04:00
Lioncash	b77430df70	apm/controller: Make SetPerformanceConfiguration() use an array of pairs over a map ... While a map is an OK way to do lookups (and usually recommended in most cases), this is a map that lives for the entire duration of the program and only deallocates its contents when the program terminates. Given the total size of the map is quite small, we can simply use a std::array of pairs and utilize std::find_if to perform the same behavior without loss of performance. This eliminates a static constructor and places the data into the read-only segment. While we're at it, we can also handle malformed inputs instead of directly dereferencing the resulting iterator.	2019-10-17 16:13:14 -04:00
Lioncash	141d929929	apm/controller: Make GetCurrentPerformanceMode() a const member function ... This doesn't modify instance state, so it can be made const qualified.	2019-10-17 15:58:25 -04:00
bunnei	9fe8072c67	Merge pull request #2980 from lioncash/warn ... maxwell_3d: Silence truncation warnings	2019-10-17 14:02:16 -04:00
Fernando Sahmkow	57a46c69f1	Fermi2D: limit blit area to only available area ... Normaly OpenGL does not care if the areas exceed the texture regions but other backends such as Vulkan do care about the limits of this areas. This PR crops the areas of the blit in order that they don't surpass the limits of the textures. This should help Vulkan and faulty OpenGL drivers	2019-10-17 10:38:44 -04:00
Rodrigo Locatti	60c602e4e7	Merge pull request #2978 from lioncash/doxygen ... video_core/texture_cache: Amend Doxygen references	2019-10-16 22:09:40 -03:00
Rodrigo Locatti	e00b529a89	Merge pull request #2982 from lioncash/surface ... texture_cache: Avoid unnecessary surface copies within PickStrategy() and TryReconstructSurface()	2019-10-16 19:43:32 -03:00
bunnei	ef9b31783d	Merge pull request #2912 from FernandoS27/async-fixes ... General fixes to Async GPU	2019-10-16 10:34:48 -04:00
Rodrigo Locatti	60315060b1	Merge pull request #2984 from lioncash/fallthrough2 ... video_core/surface: Add missing break in PixelFormatFromTextureFormat()	2019-10-15 23:08:34 -03:00
Lioncash	cf9e13c255	video_core/surface: Add missing break in PixelFormatFromTextureFormat() ... Prevents fallthrough into the following case.	2019-10-15 21:53:15 -04:00
Rodrigo Locatti	14f3cebcd4	Merge pull request #2981 from lioncash/copy ... gl_shader_decompiler: Minor cleanup-related changes	2019-10-15 21:07:25 -03:00
Lioncash	6947bf8e44	vk_shader_decompiler: Resolve fallthrough within ExprDecompiler's ExprCondCode operator() ... This would previously result in NeverExecute and UnusedIndex being treated as regular predicates.	2019-10-15 19:40:58 -04:00
Lioncash	b42a74ff2c	gl_shader_decompiler: Resolve fallthrough within ExprDecompiler's ExprCondCode operator() ... This would previously result in NeverExecute and UnusedIndex being treated as regular predicates.	2019-10-15 19:38:55 -04:00
Lioncash	a24e8bf9cf	texture_cache: Avoid unnecessary surface copies within PickStrategy() and TryReconstructSurface() ... We can take these by const reference and avoid making unnecessary copies, preventing some atomic reference count increments and decrements.	2019-10-15 19:31:33 -04:00
Lioncash	77b4916b33	control_flow: Silence truncation warnings ... This can be trivially fixed by making the input size a size_t. CFGRebuildState's constructor parameter is already a std::size_t, so this just makes the size type fully conform with it.	2019-10-15 19:10:28 -04:00
Lioncash	4f16ce9294	gl_shader_decompiler: Make ExprDecompiler's GetResult() a const member function ... This is only ever used to read, but not write, the resulting string, so we can enforce this by making it a const member function.	2019-10-15 19:02:59 -04:00
Lioncash	67df3f7742	gl_shader_decompiler: Use a std::string_view with GetDeclarationWithSuffix() ... This allows the function to be completely non-allocating for inputs of all sizes (i.e. there's no heap cost for an input to convert to a std::string_view).	2019-10-15 19:00:48 -04:00
Lioncash	04a1161354	gl_shader_decompiler: Fold flow_var constant into GetFlowVariable() ... This is only ever used within this function, so we can narrow it's scope down.	2019-10-15 18:58:36 -04:00
Lioncash	2f2ab9b5bc	gl_shader_decompiler: Mark ASTDecompiler/ExprDecompiler parameters as const references where applicable ... These member functions don't actually modify the input parameter, so we can make this explicit with the use of const.	2019-10-15 18:57:02 -04:00
Lioncash	b8a62adcf1	gl_shader_decompiler: Pass by reference to GenerateTextureArgument() ... Avoids an unnecessary atomic reference count increment and decrement.	2019-10-15 18:29:37 -04:00
Lioncash	d1d7ce74d2	gl_shader_decompiler: Use std::holds_alternative within GenerateTexture() ... This only ever queries if the type exists within the variant, but doesn't actually do anything with the return value. We can just use std::holds_alternative for this use case.	2019-10-15 18:25:48 -04:00
Lioncash	67658dd6e8	shader/node: std::move Meta instance within OperationNode constructor ... Allows usages of the constructor to avoid an unnecessary copy.	2019-10-15 18:21:59 -04:00
Lioncash	9760795bfb	gl_shader_decompiler: Avoid unnecessary copies of MetaImage ... MetaImage contains a std::vector, so copying here could result in unnecessary reallocations. Given the operation lives throughout the entire scope, this is safe to do.	2019-10-15 18:14:55 -04:00
Lioncash	c9c75f9587	maxwell_3d: Silence truncation warnings ... A trivial warning caused by not using size_t as the argument types instead of u32.	2019-10-15 17:51:35 -04:00
bunnei	2299950de1	Merge pull request #2972 from lioncash/system ... {bcat, gpu, nvflinger}: Remove trivial usages of the global system accessor	2019-10-15 17:49:12 -04:00
Lioncash	b25b94400e	video_core/gpu: Remove use of the global system accessor ... We can just make use of the reference member variable instead of accessing the global system instance.	2019-10-15 16:39:30 -04:00
Lioncash	cc1d7048b5	bcat: Remove use of global system accessors ... Removes all uses of the global system accessor within the BCAT interface.	2019-10-15 16:39:27 -04:00
Lioncash	524eb15513	video_core/texture_cache: Amend Doxygen references ... Amends the doxygen comments so that they properly resolve. While we're at it, we can correct some typos and fix up some of the comments' formatting in order to make them slightly nicer to read.	2019-10-15 15:40:00 -04:00
Lioncash	d5706346d7	common/algorithm: Add description comment indicating intended algorithms ... Makes it explicit that the header is intended for iterator-based algorithms that can ideally operate on any type.	2019-10-15 15:25:23 -04:00
Lioncash	ac4dbd3b25	common: Rename binary_find.h to algorithm.h ... Makes the header more general for other potential algorithms in the future. While we're at it, include a missing <functional> include to satisfy the use of std::less.	2019-10-15 15:24:50 -04:00
Fernando Sahmkow	64e652d8cb	Kernel Thread: Cleanup THREADPROCESSORID_DONT_UPDATE.	2019-10-15 11:55:30 -04:00
Fernando Sahmkow	e28c7f5217	Kernel: Address Feedback 2	2019-10-15 11:55:28 -04:00
Fernando Sahmkow	a3524879be	Kernel: Clang Format	2019-10-15 11:55:27 -04:00
Fernando Sahmkow	c32520ceb7	Kernel: Reverse global accessor removal.	2019-10-15 11:55:26 -04:00
Fernando Sahmkow	3073615dbc	Kernel: Address Feedback.	2019-10-15 11:55:25 -04:00
Fernando Sahmkow	25f8606a6d	Kernel Scheduler: Make sure the global scheduler shutdowns correctly.	2019-10-15 11:55:24 -04:00
Fernando Sahmkow	b3c1deba49	Kernel_Thread: Eliminate most global accessors.	2019-10-15 11:55:23 -04:00
Fernando Sahmkow	0b72b34d89	KernelSVC: Assert that condition variable address is aligned to 4 bytes.	2019-10-15 11:55:22 -04:00
Fernando Sahmkow	96b1b144af	Kernel: Correct Paused scheduling	2019-10-15 11:55:21 -04:00
Fernando Sahmkow	1c6a11ab14	Kernel: Corrections to Wait Objects clearing in which a thread could still be signalled after a timeout or a cancel.	2019-10-15 11:55:20 -04:00
Fernando Sahmkow	27d571c084	Kernel: Correct redundant yields to only advance time forward.	2019-10-15 11:55:20 -04:00
Fernando Sahmkow	7176857177	Kernel: Corrections to ModifyByWaitingCountAndSignalToAddressIfEqual	2019-10-15 11:55:19 -04:00
Fernando Sahmkow	44e09e5f21	Kernel: Correct Results in Condition Variables and Mutexes	2019-10-15 11:55:18 -04:00
Fernando Sahmkow	1ec1e81373	Kernel: Clang Format	2019-10-15 11:55:17 -04:00
Fernando Sahmkow	e05a8c2385	Kernel: Remove global system accessor from WaitObject	2019-10-15 11:55:16 -04:00
Fernando Sahmkow	0cf26cee59	Scheduler: Implement Yield Count and Core migration on Thread Preemption.	2019-10-15 11:55:16 -04:00
Fernando Sahmkow	2d382de6fa	Scheduler: Corrections to YieldAndBalanceLoad and Yield bombing protection.	2019-10-15 11:55:15 -04:00
Fernando Sahmkow	b49c0dab87	Kernel: Initial implementation of thread preemption.	2019-10-15 11:55:14 -04:00
Fernando Sahmkow	103f3a2fe5	Scheduler: Add protections for Yield bombing ... In case of redundant yields, the scheduler will now idle the core for it's timeslice, in order to avoid continuously yielding the same thing over and over.	2019-10-15 11:55:13 -04:00
Fernando Sahmkow	82218c925a	Kernel: Style and Corrections	2019-10-15 11:55:12 -04:00
Fernando Sahmkow	fcc6b34fff	Correct PrepareReschedule	2019-10-15 11:55:12 -04:00
Fernando Sahmkow	3a94e7ea33	Comment and reorganize the scheduler	2019-10-15 11:55:11 -04:00
Fernando Sahmkow	b5d1e44782	Add PrepareReschedule where required.	2019-10-15 11:55:10 -04:00
Fernando Sahmkow	b8b7ebcece	Correct compiling errors and addapt to the new interface.	2019-10-15 11:55:09 -04:00
Fernando Sahmkow	9031502974	Correct Supervisor Calls to work with the new scheduler,	2019-10-15 11:55:08 -04:00
Fernando Sahmkow	47c6c78c03	Redesign CPU Cores to work with the new scheduler	2019-10-15 11:55:07 -04:00
Fernando Sahmkow	57a71f899a	Add interfacing to the Global Scheduler	2019-10-15 11:55:07 -04:00
Fernando Sahmkow	a1ac0c6cb4	Addapt thread class to the new Scheduler	2019-10-15 11:55:06 -04:00
Fernando Sahmkow	b164d8ee53	Implement a new Core Scheduler	2019-10-15 11:55:04 -04:00
bunnei	cab2619aeb	Merge pull request #2965 from FernandoS27/fair-core-timing ... Core Timing: Rework Core Timing to run all cores evenly.	2019-10-15 11:48:30 -04:00
bunnei	0378babd15	Merge pull request #2897 from DarkLordZach/oss-ext-fonts-1 ... pl_u: Move open source font archives and fix NAND error	2019-10-14 15:13:41 -04:00
bunnei	c274fd588d	Merge pull request #2968 from FreddyFunk/fix-zl-zr-analog-triggers ... yuzu/configure_input_player: Fix input handling for ZL and ZR from controllers with analog triggers	2019-10-14 13:04:49 -04:00
bunnei	cd2efed922	Merge pull request #2930 from DarkLordZach/gamecard-partitions ... file_sys: Add code to access raw gamecard partitions and lazily load them	2019-10-14 10:29:10 -04:00
Zach Hilman	e0b9ee9b94	card_image: Implement system update commands in XCI	2019-10-13 14:18:45 -04:00
Zach Hilman	1911f85391	pl_u: Fix mismatched rebase size error in font encryption	2019-10-13 13:46:27 -04:00
Zach Hilman	36d829c27b	pl_u: Use kernel physical memory	2019-10-13 13:46:27 -04:00
Zach Hilman	b3a8a094a5	pl_u: Remove excess static qualifier	2019-10-13 13:46:27 -04:00
Zach Hilman	40284c6868	pl_u: Use OSS system archives if real archives don't exist	2019-10-13 13:46:27 -04:00
Zach Hilman	920742d418	system_archive: Synthesize shared fonts system archives	2019-10-13 13:46:10 -04:00
Zach Hilman	d6d6a87bde	externals: Move OSS font data to file_sys in core	2019-10-13 13:46:10 -04:00
Lioncash	574440d59f	nvflinger/buffer_queue: Remove use of a global system accessor	2019-10-12 09:17:56 -04:00
Fernando Sahmkow	a4ae11d63e	Core_Timing: Address Remaining feedback.	2019-10-12 07:26:38 -04:00
Fernando Sahmkow	91f6333e23	Core_Timing: Fix tests.	2019-10-12 07:23:08 -04:00
Fernando Sahmkow	e0650a2034	Core_Timing: Address Feedback and suppress warnings.	2019-10-11 14:44:14 -04:00
Fernando Sahmkow	cfc2f30dc4	AsyncGpu: Address Feedback	2019-10-11 13:41:15 -04:00
FreddyFunk	be5dc68ca3	fixed clang format & addressed feedback	2019-10-10 23:27:00 +02:00
FreddyFunk	a31c6b2c4e	yuzu/configure_input_player: Fix input handling for ZL and ZR from controllers with analog triggers	2019-10-10 23:12:06 +02:00
bunnei	b41692b69b	Merge pull request #2910 from FearlessTobi/port-4930 ... Port citra-emu/citra#4930: "Pause when in background"	2019-10-09 21:36:51 -04:00
bunnei	2ba273e49e	Merge pull request #2928 from ReinUsesLisp/dirty-depth-bounds ... maxwell_3d: Add dirty flags for depth bounds values	2019-10-09 15:44:30 -04:00
bunnei	6b5e50d20e	Merge pull request #2927 from ReinUsesLisp/polygon-offset-units ... gl_rasterizer: Fix polygon offset units	2019-10-09 15:38:52 -04:00
Fernando Sahmkow	f32a49d3d8	Surfaces: Implement R4G4B4A4U format.	2019-10-09 12:57:02 -04:00
Fernando Sahmkow	b9ddb517b1	Surfaces: Implement ASTC 6x6 10x10 12x12 8x6 6x5	2019-10-09 12:44:31 -04:00
Fernando Sahmkow	96f2b16356	Core Timing: Correct Idle and remove lefting pragma	2019-10-09 12:30:33 -04:00
Fernando Sahmkow	65aff6930b	Core Timing: General corrections and added tests.	2019-10-09 12:30:33 -04:00
Fernando Sahmkow	c9a1129c95	Tests: Eliminate old Core Timing Tests	2019-10-09 12:30:32 -04:00
Fernando Sahmkow	555866f8dc	Core Timing: Rework Core Timing to run all cores evenly.	2019-10-09 12:30:31 -04:00
bunnei	e664c24355	Merge pull request #2921 from FreddyFunk/compiler-warnings-core ... Services::ES fix casting warnings	2019-10-09 10:34:48 -04:00
bunnei	b9c831de62	Merge pull request #2654 from DarkLordZach/lm-log-rewrite ... lm: Rewrite logger to use core reporting services	2019-10-08 20:23:13 -04:00
Fernando Sahmkow	971870b89d	Merge pull request #2959 from ReinUsesLisp/cbuf-hsetp2 ... shader/half_set_predicate: Fix HSETP2 for constant buffers	2019-10-08 12:00:44 -04:00
ReinUsesLisp	3d0f357307	shader/half_set_predicate: Fix HSETP2 for constant buffers ... HSETP2 when used with a constant buffer parses the second operand type as F32. This is not configurable.	2019-10-07 14:49:47 -03:00
ReinUsesLisp	632c9e4ee3	shader/half_set_predicate: Reduce DEBUG_ASSERT to LOG_DEBUG	2019-10-07 14:48:58 -03:00
Morph	29e15601f3	hid: Implement DeactivateNpad ... Makes use of the already existing DeactivateController function.	2019-10-07 04:44:09 -07:00
Morph	c1e9ca4c08	hid: Stub SetNpadJoyAssignmentModeSingle and reorganize service commands	2019-10-07 04:43:34 -07:00
Zach Hilman	5326d3cb3a	Merge pull request #2951 from lioncash/global ... core: Remove Core::CurrentProcess()	2019-10-06 20:47:48 -04:00
Rodrigo Locatti	dcdd887df3	Merge pull request #2952 from lioncash/warning ... bcat: Silence various warnings	2019-10-06 23:35:12 +00:00
Rodrigo Locatti	3cb4c9f08a	Merge pull request #2955 from lioncash/allocator ... alignment: Resolve allocator construction issues on debug	2019-10-06 23:30:54 +00:00
Lioncash	57ffada746	alignment: Resolve allocator construction issues on debug ... This was related to the source allocator being passed into the constructor potentially having a different type than allocator being constructed. We simply need to provide a constructor to handle this case. This resolves issues related to the allocator causing debug builds on MSVC to fail.	2019-10-06 18:49:49 -04:00
Lioncash	9aafb2a277	alignment: Specify trait definitions within the allocator ... Allows containers and other data structures to consider optimizations based off of them. We satisfy all of these requirements anyways.	2019-10-06 18:48:05 -04:00
Fernando Sahmkow	8f407adeeb	Merge pull request #2954 from ReinUsesLisp/fix-invalidation ... gl_shader_disk_cache: Properly ignore existing cache	2019-10-06 17:48:14 -04:00
ReinUsesLisp	58b597c5ec	gl_shader_disk_cache: Properly ignore existing cache ... Previously old entries where appended to the file even if the shader cache was ignored at boot. Address that issue.	2019-10-06 18:00:20 -03:00
Lioncash	0705ce0ed1	bcat/module: Silence truncation warnings ... We need to perform explicit casts here, otherwise we're implicitly truncating a 64-bit type to a 32-bit one.	2019-10-06 15:38:12 -04:00
Lioncash	7e77d1593f	bcat: Take std::function instance by value in NullBackend's constructor ... Without this, the std::move within the constructor initializer list won't be able to actually perform a move.	2019-10-06 15:38:12 -04:00
Lioncash	81adf46d1d	bcat: In-class initialize ProgressServiceBackend's impl member ... Allows us to remove a constructor initializer list.	2019-10-06 15:38:12 -04:00
Lioncash	3fcd2180e4	bcat: Make ProgressServiceBackend's constructor take a std::string_view ... Given the string is appended to another, we can make it a view so a redundant full copy of the string isn't made.	2019-10-06 15:38:09 -04:00
Zach Hilman	81fff7aec0	qt: Fix game name format error	2019-10-06 15:07:04 -04:00
Lioncash	f2fa16b609	bcat: Make ProgressServiceBackend's GetEvent() const ... This member function doesn't modify internal member state, so it can be marked const.	2019-10-06 14:03:18 -04:00
Lioncash	329081fcb7	boxcat: Silence an unused variable warning ... On parse errors, we can log out the explanatory string indicating what the parsing error was, rather than just ignoring the variable and returning an overly broad error code.	2019-10-06 14:00:32 -04:00
Lioncash	839b38c404	core/core: Remove unused header ... This isn't used anywhere in either the cpp or header file.	2019-10-06 13:54:27 -04:00
Lioncash	f1382cf0e7	core: Remove Core::CurrentProcess() ... This only encourages the use of the global system instance (which will be phased out long-term). Instead, we use the direct system function call directly to remove the appealing but discouraged short-hand.	2019-10-06 13:53:12 -04:00
Lioncash	69f16ba50e	hle/service: Replace global system instance calls with instance-based ones ... Migrates the HLE service code off the use of directly accessing the global system instance where trivially able to do so. This removes all usages of Core::CurrentProcess from the service code, only 8 occurrences of this function exist elsewhere. There's still quite a bit of "System::GetInstance()" being used, however this was able to replace a few instances.	2019-10-06 13:42:23 -04:00
bunnei	deecd7f074	Merge pull request #2942 from ReinUsesLisp/clang-warnings ... Silence miscellaneous warnings	2019-10-05 20:41:20 -04:00
bunnei	6f511c8006	Merge pull request #2943 from DarkLordZach/azure-titlebars-v2 ... ci: Add custom titlebars for mainline and patreon	2019-10-05 19:29:35 -04:00
Lioncash	f883cd4f0e	video_core/control_flow: Eliminate variable shadowing warnings	2019-10-05 09:14:27 -04:00
Lioncash	25702b6256	video_core/control_flow: Eliminate pessimizing moves ... These can inhibit the ability of a compiler to perform RVO.	2019-10-05 09:14:27 -04:00
Lioncash	d82b181d44	video_core/ast: Unindent most of IsFullyDecompiled() by one level	2019-10-05 09:14:27 -04:00
Lioncash	6c41d1cd7e	video_core/ast: Make ShowCurrentState() take a string_view instead of std::string ... Allows the function to be non-allocating in terms of the output string.	2019-10-05 09:14:27 -04:00
Lioncash	3c54edae24	video_core/ast: Eliminate variable shadowing warnings	2019-10-05 09:14:26 -04:00
Lioncash	5a0a9c7449	video_core/ast: Replace std::string with a constexpr std::string_view ... Same behavior, but without the need to heap allocate	2019-10-05 09:14:26 -04:00
Lioncash	3a20d9734f	video_core/ast: Default the move constructor and assignment operator ... This is behaviorally equivalent and also fixes a bug where some members weren't being moved over.	2019-10-05 09:14:26 -04:00
Lioncash	43503a69bf	video_core/{ast, expr}: Organize forward declaration ... Keeps them alphabetically sorted for readability.	2019-10-05 09:14:26 -04:00
Lioncash	50ad745585	video_core/expr: Supply operator!= along with operator== ... Provides logical symmetry to the interface.	2019-10-05 09:14:26 -04:00
Lioncash	8eb1398f8d	video_core/{ast, expr}: Use std::move where applicable ... Avoids unnecessary atomic reference count increments and decrements.	2019-10-05 09:14:23 -04:00
Lioncash	8e0c80f269	video_core/ast: Supply const accessors for data where applicable ... Provides const equivalents of data accessors for use within const contexts.	2019-10-05 08:22:03 -04:00
David	3728bbc22a	Merge pull request #2888 from FernandoS27/decompiler2 ... Shader_IR: Implement a full control flow decompiler for the shader IR.	2019-10-05 21:52:20 +10:00
Zach Hilman	57fe7fdec0	qt: Change titlebar formatting	2019-10-05 00:10:04 -04:00
Zach Hilman	3d4a0b94e3	common: Add additional SCM revision fields	2019-10-05 00:09:49 -04:00
ReinUsesLisp	fe7f20e659	maxwell_3d: Add dirty flags for depth bounds values ... This is useful in Vulkan where we want to update depth bounds without caring if it's enabled or disabled through vkCmdSetDepthBounds.	2019-10-05 04:07:47 +00:00
Fernando Sahmkow	538f5880ff	GL_Renderer: Remove lefting snippet.	2019-10-04 19:59:55 -04:00
Fernando Sahmkow	75395605d6	NvFlinger: Remove leftover from corrections and clang format.	2019-10-04 19:59:54 -04:00
Fernando Sahmkow	9f2719d1a4	Gl_Rasterizer: Protect CPU Memory mapping from multiple threads.	2019-10-04 19:59:53 -04:00
Fernando Sahmkow	3f104464de	Core: Wait for GPU to be idle before shutting down.	2019-10-04 19:59:53 -04:00
Fernando Sahmkow	69fa2e6525	Nvdrv: Correct Event setup in Nvdrv ... Events are supposed to be cleared on quering. This fixes that issue.	2019-10-04 19:59:52 -04:00
Fernando Sahmkow	782b7a0ca4	NVFlinger: Reverse the change that only signaled events on buffer acquire. ... This has been hardware tested and it seems that NVFlinger will still signal even if there are no buffers to present.	2019-10-04 19:59:51 -04:00
Fernando Sahmkow	ffc2ce89a0	Nvdrv: Do framelimiting only in the CPU Thread	2019-10-04 19:59:50 -04:00
Fernando Sahmkow	976d9ef43c	NvFlinger: Don't swap buffers if a frame is missing and always trigger event in sync gpu.	2019-10-04 19:59:49 -04:00
Fernando Sahmkow	5b5e60ffec	GPU_Async: Correct fences, display events and more. ... This commit uses guest fences on vSync event instead of an articial fake fence we had. It also corrects to keep signaling display events while loading the game as the OS is suppose to send buffers to vSync during that time.	2019-10-04 19:59:48 -04:00
Fernando Sahmkow	4e9f975935	Nvdrv: Correct Async regression and avoid signaling empty buffer vsyncs	2019-10-04 19:59:47 -04:00
ReinUsesLisp	25ee892d5e	audio/audout_u: Change formatting for old clang-format versions	2019-10-04 23:51:56 +00:00
ReinUsesLisp	e1afeec76d	yuzu/game_list_worker: Silence warnings	2019-10-04 23:41:22 +00:00
ReinUsesLisp	f297e9ff22	yuzu/game_list: Silence -Wswitch and -Wunused-variable	2019-10-04 23:41:22 +00:00
ReinUsesLisp	2b9b695fa7	yuzu/configure_service: Silence -Wswitch	2019-10-04 23:41:22 +00:00
ReinUsesLisp	e03f46fb0e	yuzu_tester: Remove unused variable	2019-10-04 23:41:22 +00:00
ReinUsesLisp	8d0b1a957e	service/nvdrv: Silence -Wswitch	2019-10-04 23:41:22 +00:00
ReinUsesLisp	5c907f85fc	service/nfp: Silence -Wunused and -Wswitch	2019-10-04 23:41:22 +00:00
ReinUsesLisp	0759df0aff	service/hid: Silence -Wunused and -Wswitch	2019-10-04 23:41:22 +00:00
ReinUsesLisp	ab6f8d8a1e	service/am: Silence -Wreorder	2019-10-04 23:41:21 +00:00
ReinUsesLisp	634c6e24b0	service/hid: Remove unused system reference	2019-10-04 23:41:21 +00:00
ReinUsesLisp	1dbd22e695	service/friend: Remove unused field	2019-10-04 23:41:21 +00:00
ReinUsesLisp	99db7d23dd	service/filesystem: Silence -Wunused-variable	2019-10-04 23:41:21 +00:00
ReinUsesLisp	8566096794	service/bcat: Silence -Wreorder and -Wunused	2019-10-04 23:41:21 +00:00
ReinUsesLisp	87e7cc2d5a	service/audio: Silence -Wunused	2019-10-04 23:28:34 +00:00
ReinUsesLisp	aacb473aa2	service/apm: Silence -Wunused and -Wreorder	2019-10-04 23:28:34 +00:00
ReinUsesLisp	f4417eab8f	common/file_util: Silence -Wswitch	2019-10-04 23:28:34 +00:00
Fernando Sahmkow	ab47a660c8	Texture_Cache: Blit Deduction corrections and simplifications.	2019-10-04 18:53:47 -04:00
Fernando Sahmkow	2036504a82	TextureCache: Add the ability to deduce if two textures are depth on blit.	2019-10-04 18:53:46 -04:00
Fernando Sahmkow	e6eae4b815	Shader_ir: Address feedback	2019-10-04 18:52:57 -04:00
Fernando Sahmkow	3c09d9abe6	Shader_Ir: Address Feedback and clang format.	2019-10-04 18:52:57 -04:00
Fernando Sahmkow	507a9c6a40	vk_shader_decompiler: Correct Branches inside conditionals.	2019-10-04 18:52:56 -04:00
Fernando Sahmkow	000ad558dd	vk_shader_decompiler: Clean code and be const correct.	2019-10-04 18:52:55 -04:00
Fernando Sahmkow	7c756baa77	Shader_IR: clean up AST handling and add documentation.	2019-10-04 18:52:55 -04:00
Fernando Sahmkow	5ea740beb5	Shader_IR: Correct OutwardMoves for Ifs	2019-10-04 18:52:54 -04:00
Fernando Sahmkow	100a4bd988	vk_shader_compiler: Don't enclose branches with if(true) to avoid crashing AMD	2019-10-04 18:52:54 -04:00
Fernando Sahmkow	189a50bc2a	gl_shader_decompiler: Refactor and address feedback.	2019-10-04 18:52:53 -04:00
Fernando Sahmkow	b3c46d6948	Shader_IR: corrections and clang-format	2019-10-04 18:52:53 -04:00
Fernando Sahmkow	466cd52ad4	vk_shader_compiler: Correct SPIR-V AST Decompiling	2019-10-04 18:52:52 -04:00
Fernando Sahmkow	2e9a810423	Shader_IR: allow else derivation to be optional.	2019-10-04 18:52:52 -04:00
Fernando Sahmkow	ca9901867e	vk_shader_compiler: Implement the decompiler in SPIR-V	2019-10-04 18:52:51 -04:00
Fernando Sahmkow	0366c18d87	Shader_IR: mark labels as unused for partial decompile.	2019-10-04 18:52:51 -04:00
Fernando Sahmkow	47e4f6a52c	Shader_Ir: Refactor Decompilation process and allow multiple decompilation modes.	2019-10-04 18:52:50 -04:00
Fernando Sahmkow	38fc995f6c	gl_shader_decompiler: Implement AST decompiling	2019-10-04 18:52:50 -04:00
Fernando Sahmkow	6fdd501113	shader_ir: Declare Manager and pass it to appropiate programs.	2019-10-04 18:52:49 -04:00
Fernando Sahmkow	8be6e1c522	shader_ir: Corrections to outward movements and misc stuffs	2019-10-04 18:52:48 -04:00
Fernando Sahmkow	4fde66e609	shader_ir: Add basic goto elimination	2019-10-04 18:52:48 -04:00
Fernando Sahmkow	c17953978b	shader_ir: Initial Decompile Setup	2019-10-04 18:52:47 -04:00
Fernando Sahmkow	678d9ccad6	SDL: Fix missing header ... This fixes linux and mingw builds.	2019-10-04 18:14:11 -04:00
bunnei	94c34f23d7	Merge pull request #2896 from FearlessTobi/port-4950 ... Port citra-emu/citra#4950: "Add FPS to SDL title bar"	2019-10-04 15:51:03 -04:00
bunnei	7fbaf62bac	Merge pull request #2936 from VPeruS/use-isallzeroarray ... [crypto] Use IsAllZeroArray helper function	2019-10-04 15:44:35 -04:00
bunnei	c818728513	Merge pull request #2898 from FearlessTobi/port-4004 ... Port citra-emu/citra#4004: "qt_themes: add two colorful themes"	2019-10-03 21:34:40 -04:00
David	9aac7fbc22	Merge pull request #2539 from DarkLordZach/bcat ... bcat: Implement BCAT service and connect to yuzu Boxcat server	2019-10-03 19:06:13 +10:00
vperus	29b1d0db0f	[crypto] Use IsAllZeroArray helper function	2019-10-02 19:20:45 +03:00
Zach Hilman	e55d086cc9	qt: Add service dialog	2019-10-02 08:35:43 -04:00
bunnei	5e677a3178	Merge pull request #2904 from ogniK5377/better-signal-hid ... Signal styleset changes at a better time	2019-10-01 10:58:02 -04:00
Zach Hilman	5d86c52a3a	boxcat: Use updated game-asset API URL and tags	2019-10-01 09:13:31 -04:00
Zach Hilman	19c466dfb1	bcat: Add FSC accessors for BCAT data ... Ports BCAT to use FSC interface	2019-10-01 09:13:09 -04:00
ReinUsesLisp	69c806feb6	gl_rasterizer: Fix polygon offset units ... For some reason hardware divides polygon offset units by two. This is visible since drivers multiply the application requested polygon offset by two.	2019-10-01 02:00:23 -03:00
Zach Hilman	bcf1eafb8b	boxcat: Implement events global field	2019-09-30 17:28:23 -04:00
Zach Hilman	2d410ddf4d	bcat: Implement DeliveryCacheProgressImpl structure ... Huge thanks to lioncash for re-ing this for me.	2019-09-30 17:27:23 -04:00
Zach Hilman	92b70a3bf9	boxcat: Use Etag header names for file digest	2019-09-30 17:27:23 -04:00
Zach Hilman	e8183f9ef0	boxcat: Add downloading and client for launch parameter data	2019-09-30 17:27:23 -04:00
Zach Hilman	b8ce87103d	bcat: Add backend function for BCAT Indirect (launch parameter) ... Returns the data that should be returned by PopLaunchParameter kind=ApplicationSpecific.	2019-09-30 17:27:23 -04:00
Zach Hilman	ea17b294ea	bcat: Expose CreateBackendFromSettings helper function	2019-09-30 17:27:23 -04:00
Zach Hilman	fe8c7e66e2	am: Unstub PopLaunchParameter and add bcat connection for app-specific data ... Previously we were simply returning the account-preselect structure all times but if passed with a different mode the game expects application-specific data. This also adds a hook for BCAT into this allowing us to send the launch parameter through bcat,	2019-09-30 17:27:23 -04:00
Zach Hilman	02f8f1bb3e	configure_service: Allow Qt to open external links	2019-09-30 17:26:10 -04:00
Zach Hilman	f0551aef09	yuzu: Add UI tab to configure BCAT services ... Also displays current events if boxcat is selected.	2019-09-30 17:26:10 -04:00
Zach Hilman	102db206e0	bcat: Implement cmd 90201 ClearDeliveryCacheStorage ... Takes a title ID and simply deletes all the data for that title ID's bcat. Invokes the respective backend command.	2019-09-30 17:23:26 -04:00
Zach Hilman	1bde5a3c6a	bcat: Implement cmd 30100 SetPassphrase ... Takes a title ID and passphrase (0x40 byte string) and passes it to the backend.	2019-09-30 17:23:26 -04:00
Zach Hilman	86773a7f08	bcat: Implement cmd RequestSyncDeliveryCache and variant ... Variant also supports only updating a single directory. These just both invoke backend commands.	2019-09-30 17:23:26 -04:00
Zach Hilman	cb7c96b96a	bcat: Implement IDeliveryCacheProgressService commands ... Used to query completion status and events for the current delivery task.	2019-09-30 17:23:26 -04:00
Zach Hilman	f352ad5c93	bcat: Implement IDeliveryCacheFileService commands ... Used to read the contents of files and access their metadata.	2019-09-30 17:23:26 -04:00
Zach Hilman	8812018c1d	bcat: Implement IDeliveryCacheDirectoryService commands ... Used to list and get directories at the root level.	2019-09-30 17:23:26 -04:00
Zach Hilman	862131ead9	bcat: Implement IDeliveryCacheStorageService commands ... Used to create subclasses to manage files and directories and to list directories.	2019-09-30 17:23:26 -04:00
Zach Hilman	78d146f907	bcat: Add commands to create IDeliveryCacheStorageService ... Used to access contents of download.	2019-09-30 17:23:26 -04:00
Zach Hilman	68658a8385	module: Create BCAT backend based upon Settings value on construction	2019-09-30 17:23:26 -04:00
Zach Hilman	2903f3524e	bcat: Add BCAT backend for Boxcat service ... Downloads content from yuzu servers and unpacks it into the temporary directory provided. Fully supports all Backend features except passphrase.	2019-09-30 17:21:53 -04:00
Zach Hilman	2c0b75a744	bcat: Add backend class to generify the functions of BCAT ... Provides the most abstract simplified functions of BCAT as functions. Also includes a NullBackend class which is just a no-op.	2019-09-30 17:21:53 -04:00
Zach Hilman	647992e666	settings: Add option to set BCAT backend	2019-09-30 17:21:53 -04:00
Zach Hilman	532ec459b8	nifm: Signal to applications that internet access is available	2019-09-30 17:21:53 -04:00
Zach Hilman	f6c53526b3	core/loader: Track the NSO build ID of the current process	2019-09-30 17:21:53 -04:00
Zach Hilman	943662dc3c	applets: Add accessor for AppletFrontendSet ... Allows other services to call applets without using LLE.	2019-09-30 17:20:49 -04:00
Zach Hilman	f2073217a4	filesystem: Add getter for BCAT temporary directory	2019-09-30 17:20:49 -04:00
Zach Hilman	c00ed8f4ff	vfs: Add function to extract ZIP file into virtual filesystem	2019-09-30 17:18:38 -04:00
bunnei	dc29919bbe	Revert "arm_dynarmic: Check if jit is nullptr when preparing reschedule"	2019-09-29 21:54:19 -04:00
bunnei	28538bba9c	Merge pull request #2574 from DarkLordZach/dynarmic-jit-nullptr ... arm_dynarmic: Check if jit is nullptr when preparing reschedule	2019-09-29 21:44:10 -04:00
FreddyFunk	7b93c4646a	Services::ES fix casting warnings	2019-09-29 22:45:09 +02:00
FearlessTobi	b89fb6e1be	yuzu: Pause when in background ... Co-Authored-By: Vitor K <vitor-k@users.noreply.github.com>	2019-09-26 14:54:31 +02:00
David Marcec	77fbf29047	Signal styleset changes at a better time ... We should signal when a net controller is added and our event should be manual, not automatic.	2019-09-24 17:24:37 +10:00
ReinUsesLisp	f926230ab1	gl_shader_decompiler: Add tailing return for HUnpack2	2019-09-24 01:03:59 -03:00
ReinUsesLisp	25bfaffdff	gl_shader_decompiler: Fix clang build issues	2019-09-24 01:03:27 -03:00
bunnei	376f1a4432	Merge pull request #2869 from ReinUsesLisp/suld ... shader/image: Implement SULD and fix SUATOM	2019-09-23 21:47:03 -04:00
Zach Hilman	c4f3400bea	card_image: Add accessors for raw partitions in XCI	2019-09-22 21:51:46 -04:00
Zach Hilman	3952c73aee	card_image: Lazily load partitions in XCI	2019-09-22 21:50:29 -04:00
Zach Hilman	3895f7e456	pfs: Provide accessors for file sizes and offsets	2019-09-22 21:44:36 -04:00
Zach Hilman	14248685af	cmake: Add SCM detection for Azure	2019-09-22 17:23:10 -04:00
Zach Hilman	6212df3beb	lm: Flush manager output on core shutdown	2019-09-22 12:34:55 -04:00
Zach Hilman	fa6531ab0f	lm: Rename Initialize to Log and implement with manager/reporter ... Allows saving and clearer output of data.	2019-09-22 12:34:55 -04:00
Zach Hilman	ef9a7fa1f5	lm: Implement manager class to output to reporter	2019-09-22 12:34:55 -04:00
Zach Hilman	4153bd8d17	core: Add LM::Manager to system ... Allows centralized control over logging mechanisms.	2019-09-22 12:34:55 -04:00
Zach Hilman	82bf055eca	reporter: Add log output for packaged lm log data ... Takes the vector from head to tail of log data and saves it.	2019-09-22 12:34:33 -04:00
FearlessTobi	855e7237ff	qt_themes: add two colorful themes ... These two colorful themes are based on the Default and Dark themes, and contain icons that are colored rather than black and white. These icons come from icons8.com and they have been slightly revised by me. I'm pretty sure I was licensed to use them for Citra. Co-Authored-By: Pengfei Zhu <zhupengfei321@sina.cn>	2019-09-22 16:42:00 +02:00
David	aaec1562f8	Merge pull request #2683 from DarkLordZach/lock-exit ... am: Implement exit locking and self exit commands	2019-09-23 00:37:12 +10:00
David	a9abf4e7f8	Merge pull request #2889 from FearlessTobi/adwsawdawd ... Add missing include	2019-09-23 00:30:12 +10:00
Zach Hilman	b835d76311	Merge pull request #2876 from ogniK5377/AcquireNpadStyleSetUpdateEventHandle-fix ... AcquireNpadStyleSetUpdateEventHandle should have a separate event for each controller type	2019-09-22 10:06:48 -04:00
Zach Hilman	b7725812ac	Merge pull request #2877 from ogniK5377/framecount-rev7 ... Added frame_count for REV5 audio renderer	2019-09-22 10:05:44 -04:00
Zach Hilman	9f3bf6d157	main: Use const on all variable initializations	2019-09-22 10:02:07 -04:00
David	e31c15606b	Merge pull request #2895 from FearlessTobi/debug-logs ... service/acc: Lower log severity from INFO to DEBUG	2019-09-22 23:50:49 +10:00
jroweboy	64dbc92b61	Add FPS to SDL title bar ... Also fix a small issue with incorrect shutdown ordering in SDL. Previously the system would still be running so the telemetry task didn't launch and detached_tasks would assert(count == 0)	2019-09-22 15:49:39 +02:00
FearlessTobi	e22e0eb8d7	Add missing include	2019-09-22 15:47:21 +02:00
Fernando Sahmkow	a755f24369	Merge pull request #2873 from ogniK5377/new-ioctls ... Initial implementation of Ioctl2 & Ioctl3	2019-09-22 09:45:29 -04:00